Re: Patch 8.0.1531

2018-02-23 Fir de Conversatie Bram Moolenaar 

John Marriott wrote:

> On 23-Feb.-2018 07:07, Bram Moolenaar wrote:
> > Patch 8.0.1531
> > Problem:Cannot use 24 bit colors in MS-Windows console.
> > Solution:   Add support for vcon. (Nobuhiro Takasaki, Ken Takasaki,
> >  fixes #1270, fixes #2060)
> > Files:  runtime/doc/options.txt, src/misc1.c, src/option.c,
> >  src/evalfunc.c, src/os_win32.c, src/proto/os_win32.pro,
> >  src/feature.h, src/proto/term.pro, src/screen.c, src/syntax.c,
> >  src/term.c, src/testdir/gen_opt_test.vim, src/version.c
> >
> >
> After this patch, mingw-64 throws this warning on a GUI build if 
> FEAT_TERMGUICOLORS is not defined:
> gcc -c -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 
> -DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -DFEAT_MBYTE -pipe 
> -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return -s 
> term.c -o objnative/term.o
> term.c:6650:1: warning: 'find_first_tcap' defined but not used 
> [-Wunused-function]
>   find_first_tcap(
>   ^~~
> term.c:6635:24: warning: 'ks_tbl' defined but not used [-Wunused-variable]
>   static struct ks_tbl_s ks_tbl[] =
>      ^~
> 
> The attached patch tries to fix it. Please check.

Thanks.  I also notice there is no check that the function returns NULL.
And those while loops are really for loops.

-- 
Sorry, no fortune today.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Patch 8.0.1531

2018-02-22 Fir de Conversatie John Marriott 


On 23-Feb.-2018 07:07, Bram Moolenaar wrote:

Patch 8.0.1531
Problem:Cannot use 24 bit colors in MS-Windows console.
Solution:   Add support for vcon. (Nobuhiro Takasaki, Ken Takasaki,
 fixes #1270, fixes #2060)
Files:  runtime/doc/options.txt, src/misc1.c, src/option.c,
 src/evalfunc.c, src/os_win32.c, src/proto/os_win32.pro,
 src/feature.h, src/proto/term.pro, src/screen.c, src/syntax.c,
 src/term.c, src/testdir/gen_opt_test.vim, src/version.c


After this patch, mingw-64 throws this warning on a GUI build if 
FEAT_TERMGUICOLORS is not defined:
gcc -c -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603 
-DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -DFEAT_MBYTE -pipe 
-march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return -s 
term.c -o objnative/term.o
term.c:6650:1: warning: 'find_first_tcap' defined but not used 
[-Wunused-function]

 find_first_tcap(
 ^~~
term.c:6635:24: warning: 'ks_tbl' defined but not used [-Wunused-variable]
 static struct ks_tbl_s ks_tbl[] =
    ^~

The attached patch tries to fix it. Please check.

Cheers
John

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--- term.c.orig 2018-02-23 07:17:45.616345200 +1100
+++ term.c  2018-02-23 10:33:29.249539200 +1100
@@ -6624,6 +6624,7 @@
 }
 }
 
+# ifdef FEAT_TERMGUICOLORS
 struct ks_tbl_s
 {
 int code;  /* value of KS_ */
@@ -6662,6 +6663,7 @@
 }
 return NULL;
 }
+# endif
 
 /*
  * For Win32 console: replace the sequence immediately after termguicolors.