Re: Patch 8.0.1689

2018-04-10 Fir de Conversatie Bram Moolenaar

Christian wrote:
> Thanks for merging. I have a comment however:
> 
> On Di, 10 Apr 2018, Bram Moolenaar wrote:
> > + XXDPROG = ../xxd/xxd
> 
> This might need to be adjusted for Windows e.g. needs to be xxd/xxd.exe

I don't think there is an easy way to pass the path to the tests, so I
just let the test find it.  Should work in most situations.

> Also I think now we can include the following change to get full 
> coverage for xxd:
> 
> diff --git a/.travis.yml b/.travis.yml
> index a2b074bde..98f0838f5 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -108,7 +108,7 @@ script:
>- if [ -n "$err" ]; then exit 1; fi
> 
>  after_success:
> -  - if [ "$COVERAGE" = "yes" ]; then ~/.local/bin/coveralls -b $SRCDIR -x 
> .xs -e ${SRCDIR}/xxd -e ${SRCDIR}/if_perl.c --encodings utf-8 latin-1 EUC-KR; 
> fi
> +  - if [ "$COVERAGE" = "yes" ]; then ~/.local/bin/coveralls -b $SRCDIR -x 
> .xs -e ${SRCDIR}/if_perl.c --encodings utf-8 latin-1 EUC-KR; fi
>- if [ "$COVERAGE" = "yes" ]; then  cd $SRCDIR && bash <(curl -s 
> https://codecov.io/bash) ; fi
> 
>  # vim:set sts=2 sw=2 tw=0 et:

Done.  I don't see an effect though.  Hmm, rather the coverage doesn't
seem to work at all.

-- 
hundred-and-one symptoms of being an internet addict:
158. You get a tuner card so you can watch TV while surfing.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.1689

2018-04-10 Fir de Conversatie Christian Brabandt

Bram,

Thanks for merging. I have a comment however:

On Di, 10 Apr 2018, Bram Moolenaar wrote:
> + XXDPROG = ../xxd/xxd

This might need to be adjusted for Windows e.g. needs to be xxd/xxd.exe

Also I think now we can include the following change to get full 
coverage for xxd:

diff --git a/.travis.yml b/.travis.yml
index a2b074bde..98f0838f5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -108,7 +108,7 @@ script:
   - if [ -n "$err" ]; then exit 1; fi

 after_success:
-  - if [ "$COVERAGE" = "yes" ]; then ~/.local/bin/coveralls -b $SRCDIR -x .xs 
-e ${SRCDIR}/xxd -e ${SRCDIR}/if_perl.c --encodings utf-8 latin-1 EUC-KR; fi
+  - if [ "$COVERAGE" = "yes" ]; then ~/.local/bin/coveralls -b $SRCDIR -x .xs 
-e ${SRCDIR}/if_perl.c --encodings utf-8 latin-1 EUC-KR; fi
   - if [ "$COVERAGE" = "yes" ]; then  cd $SRCDIR && bash <(curl -s 
https://codecov.io/bash) ; fi

 # vim:set sts=2 sw=2 tw=0 et:


Best,
Christian
-- 
Der Alltag der meisten Menschen ist stilles Heldentum in Raten.
-- Anna Magnani

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.