Re: Patch 8.0.1711

2018-04-14 Fir de Conversatie Christian Brabandt

On Sa, 14 Apr 2018, Bram Moolenaar wrote:

> 
> Christian wrote:
> 
> > On Sa, 14 Apr 2018, Bram Moolenaar wrote:
> > 
> > > Patch 8.0.1711
> > > Problem:Term_setsize() is not implemented yet.
> > > Solution:   Implement it.
> > > Files:  src/evalfunc.c, src/terminal.c, src/proto/terminal.pro,
> > 
> > Unless stated in the documentation, it does not give an error message 
> > for the case that the buffer is not a terminal buffer.
> 
> Most term_ functions are forgiving, but calling term_setsize() on a
> non-terminal buffer can only be an error.  I'll add it.

I did not imply that an error message is needed. I just noticed that the 
documentation for patch 8.0.1711 talked about an error, while the actual 
code did not show an error message.

Best,
Christian
-- 
Internet? Das ist doch dieses WWW-Netz?
-- IBM Technischer Support, November 1994

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.1711

2018-04-14 Fir de Conversatie Bram Moolenaar

Christian wrote:

> On Sa, 14 Apr 2018, Bram Moolenaar wrote:
> 
> > Patch 8.0.1711
> > Problem:Term_setsize() is not implemented yet.
> > Solution:   Implement it.
> > Files:  src/evalfunc.c, src/terminal.c, src/proto/terminal.pro,
> 
> Unless stated in the documentation, it does not give an error message 
> for the case that the buffer is not a terminal buffer.

Most term_ functions are forgiving, but calling term_setsize() on a
non-terminal buffer can only be an error.  I'll add it.

-- 
hundred-and-one symptoms of being an internet addict:
177. You log off of your system because it's time to go to work.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.1711

2018-04-14 Fir de Conversatie Christian Brabandt

On Sa, 14 Apr 2018, Bram Moolenaar wrote:

> 
> Patch 8.0.1711
> Problem:Term_setsize() is not implemented yet.
> Solution:   Implement it.
> Files:  src/evalfunc.c, src/terminal.c, src/proto/terminal.pro,

Unless stated in the documentation, it does not give an error message 
for the case that the buffer is not a terminal buffer.

Best,
Christian
-- 
Mit Ungeduld bestraft sich zehnfach Ungeduld; man will das Ziel 
heranziehn und entfernt es nur.
-- Goethe, Maximen und Reflektionen, Nr. 802

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.