Re: [PATCH] fix: powershell :! filter commands

2022-10-02 Thread Yegappan Lakshmanan
Hi, On Sat, Oct 1, 2022 at 8:04 AM Enan Ajmain <3nan.ajm...@gmail.com> wrote: > > On Sat, 01 Oct 2022 15:47:40 +0100 > Bram Moolenaar wrote: > > > > Would be good if this can be turned into a PR. Hopefully with a test. > > Can you do that, or would this need to be done by someone else? > > I can

Re: [PATCH] fix: powershell :! filter commands

2022-10-01 Thread Enan Ajmain
On Sat, 01 Oct 2022 15:47:40 +0100 Bram Moolenaar wrote: > Would be good if this can be turned into a PR. Hopefully with a test. > Can you do that, or would this need to be done by someone else? I can't, sorry. Tests take a long time if one is not familiar with the suite beforehand. I can wri

Re: [PATCH] fix: powershell :! filter commands

2022-10-01 Thread Bram Moolenaar
[cc'ing vim-dev] Enan Ajmain wrote: > Problem: filtered bang commands with powershell as `:set shell` doesn't > work. The command structure followed in `make_filter_cmd` is wrong. Try > `:%!sort` on any file to reproduce the bug. > > Solution: Fix the command for the powershell in `make_filter

[PATCH] fix: powershell :! filter commands

2022-10-01 Thread Enan Ajmain
--- Problem: filtered bang commands with powershell as `:set shell` doesn't work. The command structure followed in `make_filter_cmd` is wrong. Try `:%!sort` on any file to reproduce the bug. Solution: Fix the command for the powershell in `make_filter_cmd`. This is not a proper patch. It comes o