Re: [virt-tools-list] [PATCH 2/2] util: Fix the size of sorted_displays allocation

2015-10-21 Thread Jonathon Jongsma
ACK, thanks! On Wed, 2015-10-21 at 15:23 +0200, Fabiano Fidêncio wrote: > As sorted_displays is a vector containing all displays' order, its > allocation size must be the maximum display id + 1 instead of the > maximum display id. > > Valgrind log: > ==15946== Invalid write of size 4 > ==15946==

Re: [virt-tools-list] [PATCH 2/2] util: Fix the size of sorted_displays allocation

2015-10-21 Thread Jonathon Jongsma
Oops, NACK. Eduardo pointed out on IRC that the for loop (later in the function) only loops to max_id-1. So, that should be fixed as well. Thanks Eduardo. Jonathon On Wed, 2015-10-21 at 08:42 -0500, Jonathon Jongsma wrote: > ACK, thanks! > > On Wed, 2015-10-21 at 15:23 +0200, Fabiano Fidêncio

Re: [virt-tools-list] [PATCH 1/2] session: Only create a hashtable if apply_monitor_geometry class exists

2015-10-21 Thread Jonathon Jongsma
ACK, but I'd like a couple changes to the commit log: - in the summary: apply_monitor_geometry is a vfunc, not a class - add a comment to the commit log explaining that this is to avoid a memory leak when we return early. On Wed, 2015-10-21 at 15:23 +0200, Fabiano Fidêncio wrote: > Related:

Re: [virt-tools-list] [PATCH 1/2] session: Only create a hashtable if apply_monitor_geometry class exists

2015-10-21 Thread Eduardo Lima (Etrunko)
ACK Although I think you could add a description for this patch in the message a memory leak on error path. On 10/21/2015 11:23 AM, Fabiano Fidêncio wrote: > Related: rhbz#1267184 > --- > src/virt-viewer-session.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [virt-tools-list] [PATCHv2 2/2] util: Fix the size of sorted_displays allocation

2015-10-21 Thread Fabiano Fidêncio
On Wed, Oct 21, 2015 at 7:50 PM, Jonathon Jongsma wrote: > Looks good to me. ACK both. Pushed, thanks! ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCHv2 2/2] util: Fix the size of sorted_displays allocation

2015-10-21 Thread Jonathon Jongsma
Looks good to me. ACK both. On Wed, 2015-10-21 at 16:08 +0200, Fabiano Fidêncio wrote: > As sorted_displays is a vector containing all displays' order, its > allocation size must be the maximum display id + 1 instead of the > maximum display id. Also, fix the size used for sorting and iterating >

[virt-tools-list] [PATCH 1/2] session: Only create a hashtable if apply_monitor_geometry class exists

2015-10-21 Thread Fabiano Fidêncio
Related: rhbz#1267184 --- src/virt-viewer-session.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/virt-viewer-session.c b/src/virt-viewer-session.c index 2699f41..92ffd3f 100644 --- a/src/virt-viewer-session.c +++ b/src/virt-viewer-session.c @@ -405,13 +405,15 @@

[virt-tools-list] [PATCH 2/2] util: Fix the size of sorted_displays allocation

2015-10-21 Thread Fabiano Fidêncio
As sorted_displays is a vector containing all displays' order, its allocation size must be the maximum display id + 1 instead of the maximum display id. Valgrind log: ==15946== Invalid write of size 4 ==15946==at 0x4169C0: virt_viewer_align_monitors_linear (virt-viewer-util.c:581) ==15946==

Re: [virt-tools-list] Help: I want to know when virt-manager will update and release new version to Ubuntu and redhat or other Distro.

2015-10-21 Thread Kevin Zhao
Great :-) Thanks Gizmo for your information , I will download the newest Distro to check the virt-manager version. On 2015年10月16日 12:13, Gizmo Chicken wrote: For Ubuntu 14.04 LTS (Trusty), which is the most recent Ubuntu LTS release, virt-manager is stuck at 0.9.5 in the official Ubuntu