Re: [virt-tools-list] [PATCH] details: show Channel label by device type

2015-11-10 Thread Cole Robinson
On 11/10/2015 09:01 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Currently we show channel label by its name. > If we use name com.redhat.spice.0 but set it > as unix socket, the label in details keep unchanged. > > This patch will set label according to device type.

[virt-tools-list] [PATCH 1/2] Remove unused 'window-removed' signal

2015-11-10 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer-app.c | 14 -- src/virt-viewer-app.h | 1 - 2 files changed, 15 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 653b30c..b14b509 100644 --- a/src/virt-viewer-app.c +++

[virt-tools-list] [PATCH virt-viewer 0/2] More cleanups

2015-11-10 Thread Eduardo Lima (Etrunko)
Here are a couple more clean-up patches I had on my staging area that I think could be merged as they are independent of any feature. Please take a look. Regards, Eduardo Eduardo Lima (Etrunko) (2): Remove unused 'window-removed' signal Fix spice includes src/remote-viewer-main.c|

[virt-tools-list] [PATCH 2/2] Fix spice includes

2015-11-10 Thread Eduardo Lima (Etrunko)
Recent spice commit requires that only spice-client.h or spice-client-gtk.h should be included directly. As a result, compilation is now throwing warnings like: warning: #warning "Only can be included directly" [-Wcpp] warning: #warning "Only can be included directly" [-Wcpp] Signed-off-by:

Re: [virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

2015-11-10 Thread Cole Robinson
On 11/09/2015 02:02 PM, Pavel Hrdina wrote: > Kernel for ppc64 automatically enables serial console, there is no need > to report any warning. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1247434 > > Signed-off-by: Pavel Hrdina > --- > > Pushed as trivial. > >

Re: [virt-tools-list] [virt-manager PATCH] virt-install: refresh storage pool after disk is created

2015-11-10 Thread Cole Robinson
On 11/10/2015 08:19 AM, Pavel Hrdina wrote: > This fixes an issue where you need to manually refresh storage pool or > restart virt-manager in order to be able delete guest that is currently > installed. This affect remote connection and non-root users. > > Resolves:

Re: [virt-tools-list] [PATCH] Add a watchdog model diag288, listed in the watchdog model list.

2015-11-10 Thread Cole Robinson
On 11/08/2015 09:57 PM, Kevin Zhao wrote: > Since the qemu 2.4 has supported the watchdog device diag288 > for s390x,so add it in the optional model list. Also modefied > the clitest xml to cover this change. > --- > tests/cli-test-xml/compare/virt-install-s390x-cdrom-KVMIBM.xml | 1 + >

Re: [virt-tools-list] [PATCH 2/2] Fix spice includes

2015-11-10 Thread Pavel Grunt
Hi Eduardo, these warnings were introduced after spice-gtk v0.30 release, virt-viewer currently depends on spice-gtk v0.29.35. You can make the code conditional or wait for the spice-gtk v0.31 release. Pavel On Tue, 2015-11-10 at 18:39 -0200, Eduardo Lima (Etrunko) wrote: > Recent spice commit

[virt-tools-list] [PATCH] details: show Channel label by device type

2015-11-10 Thread Chen Hanxiao
From: Chen Hanxiao Currently we show channel label by its name. If we use name com.redhat.spice.0 but set it as unix socket, the label in details keep unchanged. This patch will set label according to device type. Signed-off-by: Chen Hanxiao ---

[virt-tools-list] Questions about cdrom installation in virt-manager

2015-11-10 Thread Kevin Zhao
Hi Cole & all, There is a question just confusing me. When I use virt-install , set the --location parameter like this : --location /tmp/**.iso, virt-install can search the iso and get the tree.info , kernel.img and initrd.img. But when I replace the parameter "--location " with