[virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - Updated build requirements * glib version 2.38 * gtk+ version 3.10 * gio - VirtViewerApp is

[virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

2016-02-12 Thread Eduardo Lima (Etrunko)
With glib requirements now being 2.38, these functions do not make sense anymore Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-glib-compat.c | 15 --- src/virt-glib-compat.h | 27 --- 2 files changed, 42 deletions(-) diff --git

[virt-tools-list] [PATCH v3 2/5] Minor code cleanups

2016-02-12 Thread Eduardo Lima (Etrunko)
- Reuse #ifdef HAVE_SPICE_GTK block for include. - Move declaration of vfunc together with others of the same class. - Move variable declaration to the top of the function. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 13 +++-- 1 file changed, 7

[virt-tools-list] [PATCH v3 4/5] remote-viewer: Remove unused properties

2016-02-12 Thread Eduardo Lima (Etrunko)
The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 101

[virt-tools-list] [PATCH v3 1/5] Drop support to gtk2

2016-02-12 Thread Eduardo Lima (Etrunko)
From: Fabiano FidĂȘncio The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. --- configure.ac | 39 +++

[virt-tools-list] [PATCH virt-viewer v3 0/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
This is the reworked series which should be compatible with glib version 2.38 onwards. Option handling is still done with GOption API's but follows the same ideas proposed on previous versions of the patch. Again, the two first patches are kind of independent from the rest of the series, and it

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
Running remote-viewer will throw some warnings: (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: assertion 'GTK_IS_APPLICATION (application)' failed (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_menubar: assertion 'GTK_IS_APPLICATION (application)' failed This

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote: > Running remote-viewer will throw some warnings: > > (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: > assertion 'GTK_IS_APPLICATION (application)' failed > > (remote-viewer:546): Gtk-CRITICAL **:

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

2016-02-12 Thread Eduardo Lima (Etrunko)
On 02/12/2016 03:26 PM, Eduardo Lima (Etrunko) wrote: > On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote: >> Running remote-viewer will throw some warnings: >> >> (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: >> assertion 'GTK_IS_APPLICATION (application)' failed >> >>