Re: [virt-tools-list] [virt-viewer] configure: Simplify libvirt/libvirt-glib handling

On 02/25/2016 06:24 PM, Fabiano Fidêncio wrote: > Merge libvirt and libvirt-glib checking in PKG_CHECK_MODULES, then we > don't nee the LIBVIRT_GLIB_{CFLAGS,LIBS} in Makefile.am > > Signed-off-by: Fabiano Fidêncio > --- > configure.ac| 5 ++--- > src/Makefile.am | 2 --

Re: [virt-tools-list] [virt-viewer 0/3] Bring back libvirt-glib dependency

Hi, Series looks good! Acked-by: Victor Toso On Tue, Feb 23, 2016 at 03:32:04PM +0100, Fabiano Fidêncio wrote: > A long time ago we used to depend on libvirt-glib for the glib event > loop integration. On commit 296f91c it got dropped in favor of > keeping everything into

Re: [virt-tools-list] [virt-viewer 1/3] Bring back libvirt-glib dependency

On 02/25/2016 06:11 PM, Fabiano Fidêncio wrote: > On Thu, Feb 25, 2016 at 3:04 PM, Eduardo Lima (Etrunko) > wrote: >> On 02/23/2016 11:32 AM, Fabiano Fidêncio wrote: >>> libvirt-glib dependency was dropped in commit 296f91c in favor to >>> maintain the full glib event loop

Re: [virt-tools-list] [virt-viewer 1/3] Bring back libvirt-glib dependency

On Thu, Feb 25, 2016 at 3:04 PM, Eduardo Lima (Etrunko) wrote: > On 02/23/2016 11:32 AM, Fabiano Fidêncio wrote: >> libvirt-glib dependency was dropped in commit 296f91c in favor to >> maintain the full glib event loop integration into virt-viewer tree. >> This decision was

Re: [virt-tools-list] [PATCH] virt-convert: decompress the .gz files before converting

On 02/23/2016 09:55 PM, Lin Ma wrote: > The OVF specification v1.1.0(page 15) indicates that "Each file > referenced by a File element may be compressed using gzip > (see RFC1952)." > > In this case the .gz files should be decompressed first before > converting through qemu-img. > >

Re: [virt-tools-list] [virt-viewer v2 3/3] util: allow loading an in-tree ui file

On Thu, Feb 25, 2016 at 2:26 PM, Fabiano Fidêncio wrote: > On Thu, Feb 25, 2016 at 2:19 PM, Daniel P. Berrange > wrote: >> On Thu, Feb 25, 2016 at 02:03:40PM +0100, Fabiano Fidêncio wrote: >>> This commits allows to load ui files without the need to

Re: [virt-tools-list] [virt-viewer 0/2] Allow loading in-tree ui files

On 02/25/2016 04:20 AM, Fabiano Fidêncio wrote: > The goal of these two patches are the $(subject). > The first one is just doing a small refactoring in the _load_ui() in the way > that introducing a new path to load a file from wouldn't be too confusing. > > As always, the most dificult part of

Re: [virt-tools-list] [virt-viewer 1/2] util: slightly reorganize _load_ui()

On 02/25/2016 04:21 AM, Fabiano Fidêncio wrote: > The function was a bit hard to read and, mainly, hard to expand in a > readable way when adding one more directory to try to load the ui file > from. > > Signed-off-by: Fabiano Fidêncio > --- > src/virt-viewer-util.c | 60 >

Re: [virt-tools-list] [virt-viewer v2 3/3] util: allow loading an in-tree ui file

On Thu, Feb 25, 2016 at 2:19 PM, Daniel P. Berrange wrote: > On Thu, Feb 25, 2016 at 02:03:40PM +0100, Fabiano Fidêncio wrote: >> This commits allows to load ui files without the need to install >> virt-viewer. It helps a lot developers testing changes in the ui files >> and

Re: [virt-tools-list] [virt-viewer v2 3/3] util: allow loading an in-tree ui file

On Thu, Feb 25, 2016 at 02:03:40PM +0100, Fabiano Fidêncio wrote: > This commits allows to load ui files without the need to install > virt-viewer. It helps a lot developers testing changes in the ui files > and also avoid abortions like [0] when running remote-viewer from the > source tree and

[virt-tools-list] [virt-viewer v2 0/3] Allow loading in-tree ui files

With these patches I'm trying to achieve the $(subject). While just adding a new path to load the ui file from I've got a bit confused with the code and then decided to split the _load_ui() function in a way it could be more readable after the 3rd patch. :-) As always, the most difficult part of

[virt-tools-list] [virt-viewer v2 2/3] util: slightly reorganize _load_ui()

_load_ui() was hard to expand, in a readable way, when adding one more directory to (try to) load the ui file from. So, it got split in a way that adding new directories to (try to) load ui files from is more readable. Signed-off-by: Fabiano Fidêncio ---

[virt-tools-list] [virt-viewer v2 3/3] util: allow loading an in-tree ui file

This commits allows to load ui files without the need to install virt-viewer. It helps a lot developers testing changes in the ui files and also avoid abortions like [0] when running remote-viewer from the source tree and without having any previous installation. [0]: fidenci@cat

Re: [virt-tools-list] [virt-viewer 1/2] util: slightly reorganize _load_ui()

On Thu, Feb 25, 2016 at 11:37 AM, Victor Toso wrote: > Hi, > > On Thu, Feb 25, 2016 at 08:21:00AM +0100, Fabiano Fidêncio wrote: >> The function was a bit hard to read and, mainly, hard to expand in a >> readable way when adding one more directory to try to load the ui file