Re: [virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

2016-08-03 Thread Xiaodai Wang
- Original Message - > From: "Fabiano Fidêncio" > To: "Eduardo Lima (Etrunko)" > Cc: "Christophe Fergeau" , "virt" > > Sent: Wednesday, August 3, 2016 10:36:07 PM > Subject: Re: [virt-tools-list]

Re: [virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

2016-08-03 Thread Fabiano Fidêncio
On Wed, Aug 3, 2016 at 3:04 PM, Eduardo Lima (Etrunko) wrote: > On 08/02/2016 01:17 PM, Christophe Fergeau wrote: >> On Fri, Jul 29, 2016 at 06:40:23PM -0300, Eduardo Lima (Etrunko) wrote: >>> I have pushed the first two patches of the series because they were >>> already

Re: [virt-tools-list] [virt-viewer v1] Fix filename leak on transfer dialog

2016-08-03 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Aug 03, 2016 at 03:40:14PM +0200, Victor Toso wrote: > spice_file_transfer_task_get_filename() was wrongly annotated as > transfer none. We can safely free this string after usage. > --- > src/virt-viewer-file-transfer-dialog.c | 5

[virt-tools-list] [virt-viewer v1] Fix filename leak on transfer dialog

2016-08-03 Thread Victor Toso
spice_file_transfer_task_get_filename() was wrongly annotated as transfer none. We can safely free this string after usage. --- src/virt-viewer-file-transfer-dialog.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/virt-viewer-file-transfer-dialog.c

Re: [virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

2016-08-03 Thread Eduardo Lima (Etrunko)
On 08/02/2016 01:17 PM, Christophe Fergeau wrote: > On Fri, Jul 29, 2016 at 06:40:23PM -0300, Eduardo Lima (Etrunko) wrote: >> I have pushed the first two patches of the series because they were >> already acknowledged and were pretty much self-contained. >> >> I tried to replace GtkTreeView in