Re: [virt-tools-list] [PATCH v2] Virtuozzo hypervisor basic support

2017-02-16 Thread Cole Robinson
Thanks for the patch, especially taking a stab at the dogtail tests! Please split this patch up, at least into 3 parts: virtinst/cli test bits, virt-manager misc bits, virt-manager create wizard bits. I just did a quick pass, a couple comments inline below On 02/15/2017 07:01 AM, Mikhail

Re: [virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

2017-02-16 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote: > On 16/02/17 10:06, Pavel Grunt wrote: > > Hi, > > > > On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: > >> This whole series is the result of the initial idea of having the > >> new > >> iso-dialog to use

Re: [virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

2017-02-16 Thread Fabiano FidĂȘncio
On Thu, Feb 16, 2017 at 1:06 PM, Pavel Grunt wrote: > Hi, > > On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: >> This whole series is the result of the initial idea of having the >> new >> iso-dialog to use this widget. Having it done only for the iso- >>

Re: [virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

2017-02-16 Thread Eduardo Lima (Etrunko)
On 16/02/17 10:06, Pavel Grunt wrote: > Hi, > > On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: >> This whole series is the result of the initial idea of having the >> new >> iso-dialog to use this widget. Having it done only for the iso- >> dialog >> would not make much sense,

Re: [virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

2017-02-16 Thread Pavel Grunt
Hi, On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: > This whole series is the result of the initial idea of having the > new > iso-dialog to use this widget. Having it done only for the iso- > dialog > would not make much sense, so I went on and ported all other > dialogs. > The