Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-clone: add support to clone nvram VARS

On 03/06/2017 03:43 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1243335 > > Signed-off-by: Pavel Hrdina > --- > man/virt-clone.pod | 6 ++ > tests/clone-xml/nvram-auto-in.xml | 23 +++ >

Re: [virt-tools-list] [virt-manager PATCH 1/2] domain: add support to rename domain with nvram vars file

On 03/06/2017 03:43 AM, Pavel Hrdina wrote: > Libvirt storage API doesn't support renaming storage volumes so > we need to copy the nvram file and remove the old one. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 > > Signed-off-by: Pavel Hrdina > --- >

Re: [virt-tools-list] [virt-manager PATCH 0/6] cloning improvements and bug fixes

On 03/06/2017 03:28 AM, Pavel Hrdina wrote: > Pavel Hrdina (6): > virtinst.diskbackend: unify how we get disk type > virtinst.storage: improve detection of disk type > virtManager.clone: set new manual path before we populate storage list > virtManager.clone: don't generate clone path if

[virt-tools-list] Status W9 - Feb 27…Mar 3, 2017

Week plan: - Explore Mesa configuration to get virgl working in guest when building from sources - Investigate if the bug is fixed, if not, bisect and attempt a fix - Resume my efforts on Spice for Mac, VNC is just a bit painful Results: - Built Mesa from source in virgl configuration - Bisected

[virt-tools-list] [virt-manager PATCH 0/2] add support for nvram vars required by uefi

Pavel Hrdina (2): domain: add support to rename domain with nvram vars file virt-clone: add support to clone nvram VARS man/virt-clone.pod | 6 + tests/clone-xml/nvram-auto-in.xml | 23 +++ tests/clone-xml/nvram-auto-out.xml | 23 +++

Re: [virt-tools-list] [virt-viewer v1] Avoid harmless warnings due lack of oVirt on build

Ack On Fri, 2017-03-03 at 16:01 +0100, Victor Toso wrote: > From: Victor Toso > > > remote-viewer.c: In function 'remote_viewer_get_property': > > remote-viewer.c:227:26: warning: unused variable 'priv' [-Wunused- > > variable] > >  RemoteViewerPrivate *priv =

Re: [virt-tools-list] [virt-viewer v1 1/2] Fix build when building without oVirt

Ack, Pavel On Fri, 2017-03-03 at 15:37 +0100, Victor Toso wrote: > From: Victor Toso > > As remote_viewer_iso_list_dialog_new() is defined on > remote-viewer-iso-list-dialog.h which is only build with oVirt > integration. > >  > undefined reference to

Re: [virt-tools-list] [virt-viewer v1 2/2] Don't define functiont without oVirt integration

Ack On Fri, 2017-03-03 at 15:37 +0100, Victor Toso wrote: > From: Victor Toso > > Function is not used without oVirt. > > > virt-viewer-window.c:1063:1: warning: 'iso_dialog_response' > > defined > > but not used [-Wunused-function] > > Signed-off-by: Victor Toso

[virt-tools-list] [virt-manager PATCH 2/6] virtinst.storage: improve detection of disk type

Signed-off-by: Pavel Hrdina --- virtinst/diskbackend.py | 11 ++- virtinst/storage.py | 23 ++- 2 files changed, 24 insertions(+), 10 deletions(-) diff --git a/virtinst/diskbackend.py b/virtinst/diskbackend.py index fb8ae7bb..f70f5b21 100644

[virt-tools-list] [virt-manager PATCH 4/6] virtManager.clone: don't generate clone path if we don't default to clone

If we don't default to clone the disk in question don't try to generate and assign default clone_path, this will force user to select the path explicitly and avoid some unnecessary errors in debug log. Signed-off-by: Pavel Hrdina --- virtManager/clone.py | 8 +++- 1 file

[virt-tools-list] [virt-manager PATCH 6/6] virtManager.delete: don't allow deleting SCSI disks

Signed-off-by: Pavel Hrdina --- virtManager/delete.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/virtManager/delete.py b/virtManager/delete.py index 8113e140..9a08e04b 100644 --- a/virtManager/delete.py +++ b/virtManager/delete.py @@ -340,9

[virt-tools-list] [virt-manager PATCH 5/6] virtManager.clone: don't generate default clone_path for some storage pools

Libvirt doesn't support creating volumes for some storage pools, don't generate default clone_path for these storage pools. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420190 Signed-off-by: Pavel Hrdina --- virtManager/clone.py | 8 1 file changed, 8

[virt-tools-list] [virt-manager PATCH 0/6] cloning improvements and bug fixes

Pavel Hrdina (6): virtinst.diskbackend: unify how we get disk type virtinst.storage: improve detection of disk type virtManager.clone: set new manual path before we populate storage list virtManager.clone: don't generate clone path if we don't default to clone virtManager.clone:

[virt-tools-list] [virt-manager PATCH 3/6] virtManager.clone: set new manual path before we populate storage list

Signed-off-by: Pavel Hrdina --- virtManager/clone.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virtManager/clone.py b/virtManager/clone.py index 23d52b66..0704b21a 100644 --- a/virtManager/clone.py +++ b/virtManager/clone.py @@ -713,9 +713,9 @@ class

[virt-tools-list] [virt-manager PATCH 1/6] virtinst.diskbackend: unify how we get disk type

Both StorageCreator and StorageBackend should use the same logic to detect the disk type. Now if the target is block device we will detect it correctly. The check for block type doesn't make sense because that code is executed only for local cloning without Libvirt help which is the only way how