[virt-tools-list] ANNOUNCE: virt-manager 1.4.1 released

2017-03-08 Thread Cole Robinson
I'm happy to announce the release of virt-manager 1.4.1! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - storage/nodedev event API support (Jovanka

Re: [virt-tools-list] [PATCH virt-viewer v3 1/2] virt-viewer: Allow more precise VM selection

2017-03-08 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Fri, 2017-03-03 at 14:08 +0100, Pavel Grunt wrote: > Theoretically a VM name can be a valid VM id or uuid. In that case > connecting to the VMs may be problematic since virt-viewer selects > the VM by its id then by uuid if not found then by

Re: [virt-tools-list] [PATCH virt-viewer v3 2/2] virt-viewer: Adjust name-id-uuid comment

2017-03-08 Thread Jonathon Jongsma
ACK On Fri, 2017-03-03 at 14:08 +0100, Pavel Grunt wrote: > virt-viewer by default chooses the VM by its id, then uuid > and then by name. Adjust the comment to match the implementation. > > Related: rhbz#1399077 > --- >  man/virt-viewer.pod | 2 +- >  src/virt-viewer.c   | 6 +++--- >  2 files

Re: [virt-tools-list] [virt-manager PATCH v3] domain: add support to rename domain with nvram vars file

2017-03-08 Thread Cole Robinson
On 03/08/2017 03:59 AM, Pavel Hrdina wrote: > Libvirt storage API doesn't support renaming storage volumes so > we need to copy the nvram file and remove the old one. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 > > Signed-off-by: Pavel Hrdina ACK

Re: [virt-tools-list] [virt-manager PATCH v3] domain: add support to rename domain with nvram vars file

2017-03-08 Thread Pavel Hrdina
On Wed, Mar 08, 2017 at 09:03:47AM +, Daniel P. Berrange wrote: > On Wed, Mar 08, 2017 at 09:59:57AM +0100, Pavel Hrdina wrote: > > Libvirt storage API doesn't support renaming storage volumes so > > we need to copy the nvram file and remove the old one. > > We really ought to add a

Re: [virt-tools-list] [virt-manager PATCH v3] domain: add support to rename domain with nvram vars file

2017-03-08 Thread Daniel P. Berrange
On Wed, Mar 08, 2017 at 09:59:57AM +0100, Pavel Hrdina wrote: > Libvirt storage API doesn't support renaming storage volumes so > we need to copy the nvram file and remove the old one. We really ought to add a virStorageVolRename API - I'm surprised we did not already have it :-) At least file an

[virt-tools-list] [virt-manager PATCH v3] domain: add support to rename domain with nvram vars file

2017-03-08 Thread Pavel Hrdina
Libvirt storage API doesn't support renaming storage volumes so we need to copy the nvram file and remove the old one. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368922 Signed-off-by: Pavel Hrdina --- new in v3: - always assign some value into new_nvram and