[virt-tools-list] [virt-manager PATCH 1/2] Resolve incorrect label alignment

2017-05-31 Thread Radostin Stoyanov
The "xalign" property determines the horizontal alignment of the label text inside the labels size allocation. Compare this to “halign”, which determines how the labels size allocation is positioned in the space available for the label. [1] When the "width_chars" property is used, labels appear

[virt-tools-list] [virt-manager PATCH 0/2] Resolve UI alignment issues

2017-05-31 Thread Radostin Stoyanov
Commits (2): Resolve incorrect label alignment Use consistent alignment for memory/cpu grid ui/asyncjob.ui | 1 - ui/clone.ui| 3 +-- ui/create.ui | 44 +--- 3 files changed, 10 insertions(+), 38 deletions(-) -- 2.9.4

[virt-tools-list] [virt-manager PATCH 2/2] Use consistent alignment for memory/cpu grid

2017-05-31 Thread Radostin Stoyanov
--- ui/create.ui | 42 +- 1 file changed, 9 insertions(+), 33 deletions(-) diff --git a/ui/create.ui b/ui/create.ui index ded90a7..816ffc7 100644 --- a/ui/create.ui +++ b/ui/create.ui @@ -2103,39 +2103,6 @@ is not yet supported./small

Re: [virt-tools-list] [virt-manager PATCH 0/3] add support for UEFI secure boot features

2017-05-31 Thread Cole Robinson
On 05/31/2017 11:36 AM, Pavel Hrdina wrote: > Pavel Hrdina (3): > virt-install: add support for SMM feature > virt-install: add support for loader secure attribute > virtinst: if required by UEFI enable SMM feature and set q35 machine > type > > man/virt-install.pod

Re: [virt-tools-list] [virt-manager PATCHv2 00/13] Drop Gtk deprecation

2017-05-31 Thread Cole Robinson
On 05/31/2017 09:08 AM, Radostin Stoyanov wrote: > This is revised version of the patch which aims to resolve Gtk deprecations > in the UI files. Glade version 3.20 was used for validation. > > Commits (13): > Format UI files with Glade 3.20 > Use GtkButtonBox instead of GtkHButtonBox >

[virt-tools-list] [virt-manager PATCH 0/3] add support for UEFI secure boot features

2017-05-31 Thread Pavel Hrdina
Pavel Hrdina (3): virt-install: add support for SMM feature virt-install: add support for loader secure attribute virtinst: if required by UEFI enable SMM feature and set q35 machine type man/virt-install.pod | 11 +-

[virt-tools-list] [virt-manager PATCH 3/3] virtinst: if required by UEFI enable SMM feature and set q35 machine type

2017-05-31 Thread Pavel Hrdina
If we detect that the UEFI image is build to require SMM feature we should configure the guest to enable SMM feature and set q35 machine type. Without this user wouldn't be able to boot the guest. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1387479 Signed-off-by: Pavel Hrdina

[virt-tools-list] [virt-manager PATCH 2/3] virt-install: add support for loader secure attribute

2017-05-31 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- man/virt-install.pod | 5 ++-- .../compare/virt-install-boot-loader-secure.xml| 29 ++ tests/clitest.py | 8 ++ virtinst/cli.py

[virt-tools-list] [virt-manager PATCH 1/3] virt-install: add support for SMM feature

2017-05-31 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- man/virt-install.pod | 6 + .../compare/virt-install-features-smm.xml | 29 ++ tests/clitest.py | 9 +++ virt-install

Re: [virt-tools-list] [PATCH virt-viewer v2 2/2] kiosk: Show authentication dialog again if cancelled

2017-05-31 Thread Victor Toso
Hi, On Wed, May 31, 2017 at 10:23:16AM -0300, Eduardo Lima (Etrunko) wrote: > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko) Works fine, Acked-by: Victor Toso > --- > v2: Retry authentication

Re: [virt-tools-list] [PATCH virt-viewer v2 1/2] window: Do not show fullscreen toolbar if in kiosk mode

2017-05-31 Thread Victor Toso
On Wed, May 31, 2017 at 10:23:15AM -0300, Eduardo Lima (Etrunko) wrote: > Regression since commit cc455b7f916110d7cfae6b7af753349e070c9494. > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko) Acked-by: Victor Toso

[virt-tools-list] [PATCH virt-viewer v2 1/2] window: Do not show fullscreen toolbar if in kiosk mode

2017-05-31 Thread Eduardo Lima (Etrunko)
Regression since commit cc455b7f916110d7cfae6b7af753349e070c9494. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer-window.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[virt-tools-list] [PATCH virt-viewer v2 2/2] kiosk: Show authentication dialog again if cancelled

2017-05-31 Thread Eduardo Lima (Etrunko)
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) --- v2: Retry authentication dialog if cancelled instead of quitting the application. --- src/virt-viewer-app.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[virt-tools-list] [virt-manager PATCHv2 13/13] Use GtkPaned instead of GtkHPaned

2017-05-31 Thread Radostin Stoyanov
GtkHPaned was deprecated since Gtk version 3.2 and should not be used in newly-written code.[1] Use GtkPaned instead.[2] By default, GtkPaned's orientation is set to horizontal.[3] [1] https://developer.gnome.org/gtk3/stable/GtkHPaned.html [2]

[virt-tools-list] [virt-manager PATCHv2 07/13] Remove deprecated GtkMisc:xpad property

2017-05-31 Thread Radostin Stoyanov
GtkMisc:xpad was deprecated since Gtk version 3.14 and should not be used in newly-written code. Use 'margin-start' and 'margin-end' instead. https://developer.gnome.org/gtk3/stable/GtkMisc.html#GtkMisc--xpad https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--margin-start

[virt-tools-list] [virt-manager PATCHv2 12/13] Use GtkSeparator instead of GtkHSeparator

2017-05-31 Thread Radostin Stoyanov
GtkHSeparator was deprecated since Gtk version 3.2 and should not be used in newly-written code.[1] Use GtkSeparator instead.[2] By default, GtkSeparator's orientation is set to horizontal.[3] [1] https://developer.gnome.org/gtk3/stable/GtkHSeparator.html [2]

[virt-tools-list] [virt-manager PATCHv2 00/13] Drop Gtk deprecation

2017-05-31 Thread Radostin Stoyanov
This is revised version of the patch which aims to resolve Gtk deprecations in the UI files. Glade version 3.20 was used for validation. Commits (13): Format UI files with Glade 3.20 Use GtkButtonBox instead of GtkHButtonBox Replace xalign='0' with halign='start' Replace xalign='1' with

[virt-tools-list] [virt-manager PATCHv2 06/13] Use valign property instead of yalign

2017-05-31 Thread Radostin Stoyanov
GtkAlignment:yalign was deprecated since Gtk version 3.14 and should not be used in newly-written code. Use valign property instead. The behaviour of yalign='0' is identical to valign='start', similar for yalign='1' and valign='end'. The default value of the property valign is GTK_ALIGN_FILL

[virt-tools-list] [virt-manager PATCHv2 05/13] Remove redundant xalign property

2017-05-31 Thread Radostin Stoyanov
GtkAlignment:xalign was deprecated since Gtk version 3.14 and should not be used in newly-written code. Specifying halign property is not required when xalign='0.5' because the behaviour is identical to the default value of halign.

[virt-tools-list] [virt-manager PATCHv2 02/13] Use GtkButtonBox instead of GtkHButtonBox

2017-05-31 Thread Radostin Stoyanov
GtkHButtonBox was deprecated since Gtk version 3.2 and should not be used in newly-written code. Use GtkButtonBox instead. The property orientation is set by default to horizontal. https://developer.gnome.org/gtk3/stable/GtkHButtonBox.html --- ui/addhardware.ui | 2 +- ui/clone.ui

[virt-tools-list] [virt-manager PATCHv2 11/13] Remove deprecated GtkActivatable:use-action-appearance property

2017-05-31 Thread Radostin Stoyanov
GtkActivatable:use-action-appearance was deprecated since Gtk version 3.10 and should not be used in newly-written code. https://developer.gnome.org/gtk3/stable/GtkActivatable.html#GtkActivatable--use-action-appearance --- ui/migrate.ui | 1 - 1 file changed, 1 deletion(-) diff --git

[virt-tools-list] [virt-manager PATCHv2 08/13] Remove deprecated GtkMisc:ypad property

2017-05-31 Thread Radostin Stoyanov
GtkMisc:ypad was deprecated since Gtk version 3.14 and should not be used in newly-written code. Use margin-top and margin-bottom instead. Both have default value set to 0. https://developer.gnome.org/gtk3/stable/GtkMisc.html#GtkMisc--ypad

[virt-tools-list] [virt-manager PATCHv2 09/13] Fix typo in Pre-requisite software

2017-05-31 Thread Radostin Stoyanov
--- INSTALL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL.md b/INSTALL.md index a34ca77..399dd11 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -37,6 +37,6 @@ Minimum version requirements of major components: - libosinfo >= 0.2.10 On Debian or Ubuntu based

[virt-tools-list] [virt-manager PATCHv2 04/13] Replace xalign='1' with halign='end'

2017-05-31 Thread Radostin Stoyanov
GtkAlignment:xalign was deprecated since Gtk version 3.14 and should not be used in newly-written code. Use halign property instead. https://developer.gnome.org/gtk3/stable/GtkAlignment.html#GtkAlignment--xalign https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--halign ---