Re: [virt-tools-list] [virt-manager] [PATCH 0/9] Integration of virt-bootstrap

2017-06-23 Thread Radostin
Hi Cole, Thank you for the feedback. To solve the problem with virt-bootstrap/skopeo use: virt-bootstrap docker://fedora /tmp/foo --^ (docker:// with two slashes) On 23/06/17 19:43, Cole Robinson wrote: > On 06/23/2017 01:20 PM, Cole Robinson wrote: >> On 06/22/2017 10:53

Re: [virt-tools-list] [virt-manager] [PATCH 0/9] Integration of virt-bootstrap

2017-06-23 Thread Cole Robinson
On 06/23/2017 01:20 PM, Cole Robinson wrote: > On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: >> Hi all, >> >> >> These series of patches aim to integrate virt-bootstrap with virt-manager. >> The goal is to replace the current message: >> >> "The OS directory tree must already exist. Creating an

Re: [virt-tools-list] [virt-manager] [PATCH 9/9] create: Show state/details of container bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > virtManager/create.py | 39 --- > 1 file changed, 36 insertions(+), 3 deletions(-) > > diff --git a/virtManager/create.py b/virtManager/create.py > index 7396aba..d540bae 100644 > ---

Re: [virt-tools-list] [virt-manager] [PATCH 7/9] ui: asyncjob: Align Cancel button at bottom-right

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > ui/asyncjob.ui | 13 ++--- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/ui/asyncjob.ui b/ui/asyncjob.ui > index 5e9ff93..d854246 100644 > --- a/ui/asyncjob.ui > +++ b/ui/asyncjob.ui > @@ -142,17 +142,6 @@ >

Re: [virt-tools-list] [virt-manager] [PATCH 6/9] ui: asyncjob: Add "Details" expander

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > ui/asyncjob.ui | 33 - > 1 file changed, 32 insertions(+), 1 deletion(-) Combine this with patch #8 Thanks, Cole ___ virt-tools-list mailing list

Re: [virt-tools-list] [virt-manager] [PATCH 4/9] create: Call virt-bootstrap asynchronously

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > virtManager/create.py | 74 > +++ > 1 file changed, 74 insertions(+) > > diff --git a/virtManager/create.py b/virtManager/create.py > index 658135c..4bedcfe 100644 > ---

Re: [virt-tools-list] [virt-manager] [PATCH 5/9] create: Populate previous bootstrap source URLs

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > virtManager/create.py | 26 ++ > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/virtManager/create.py b/virtManager/create.py > index 4bedcfe..7396aba 100644 > --- a/virtManager/create.py > +++

Re: [virt-tools-list] [virt-manager] [PATCH 3/9] create: Refactor OS container to enable bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:54 AM, Radostin Stoyanov wrote: > --- > ui/create.ui | 2 ++ > virtManager/create.py | 42 ++ > 2 files changed, 44 insertions(+) > > diff --git a/ui/create.ui b/ui/create.ui > index ae4227b..c9d2637 100644 > --- a/ui/create.ui >

Re: [virt-tools-list] [virt-manager] [PATCH 0/9] Integration of virt-bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: > Hi all, > > > These series of patches aim to integrate virt-bootstrap with virt-manager. > The goal is to replace the current message: > > "The OS directory tree must already exist. Creating an OS directory tree > is not yet supported" > >

Re: [virt-tools-list] [virt-manager] [PATCH 2/9] gschema: Store source URIs for container bootstrap

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: > --- > data/org.virt-manager.virt-manager.gschema.xml | 6 ++ > virtManager/config.py | 4 > 2 files changed, 10 insertions(+) Looks good, but combine this with patch #5 so it's one combined change Thanks, Cole

Re: [virt-tools-list] [virt-manager] [PATCH 1/9] ui: create: Adjust UI to add support for OS tree creation

2017-06-23 Thread Cole Robinson
On 06/22/2017 10:53 AM, Radostin Stoyanov wrote: > --- > ui/create.ui | 183 > ++- > 1 file changed, 180 insertions(+), 3 deletions(-) I say combine this with patch 3 so it's semi testable Thanks, Cole

[virt-tools-list] [PATCH virt-viewer 5/6] remote-viewer: add a --dbus-controller

2017-06-23 Thread marcandre . lureau
From: Marc-André Lureau Allow to set connection details via DBus, and add a Connect method. This is intended to replace the Spice controller. Sample usage: DEST=`remote-viewer --dbus-controller` gdbus call --session --dest $DEST --object-path

[virt-tools-list] [PATCH virt-viewer 3/6] app: add dbus-ctrl property

2017-06-23 Thread marcandre . lureau
From: Marc-André Lureau If the dbus-ctrl property is set, we should call open_uri() without guri set. Signed-off-by: Marc-André Lureau --- src/virt-viewer-app.c | 12 src/virt-viewer-app.h | 1 + 2 files changed, 13

[virt-tools-list] [PATCH virt-viewer 0/6] RFC: add dbus-controller, remove spice-controller

2017-06-23 Thread marcandre . lureau
From: Marc-André Lureau Hi, For the reasons explained in this spice-gtk patch series: https://patchwork.freedesktop.org/patch/161676/, spice-controller should eventually be removed. We developped the .vv file format as an alternative for browsers (and other users)

[virt-tools-list] [PATCH virt-viewer 6/6] remote-viewer: remove --spice-controller

2017-06-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configure.ac| 3 +- data/Makefile.am| 1 - data/spice-xpi-client-remote-viewer | 6 - data/virt-viewer.wxs.in |

[virt-tools-list] [PATCH virt-viewer 2/6] session: remove virt_viewer_session_new() declaration

2017-06-23 Thread marcandre . lureau
From: Marc-André Lureau The function was removed in commit 05333f0e93fb988c2fd9302e67671490941aedb0. Signed-off-by: Marc-André Lureau --- src/virt-viewer-session.h | 1 - 1 file changed, 1 deletion(-) diff --git

[virt-tools-list] [PATCH virt-viewer 4/6] remote-viewer: factor our remote_viewer_initial_connect()

2017-06-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/remote-viewer.c | 70 - 1 file changed, 43 insertions(+), 27 deletions(-) diff --git a/src/remote-viewer.c

[virt-tools-list] [PATCH virt-viewer 1/6] file: make constructor accept NULL location

2017-06-23 Thread marcandre . lureau
From: Marc-André Lureau We are going to make empty/fake VirtViewerFile. Signed-off-by: Marc-André Lureau --- src/virt-viewer-file.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/virt-viewer-file.c