[virt-tools-list] [PATCH virt-viewer 2/3] Report errors when saving screenshot

2017-07-19 Thread Jonathon Jongsma
Currently, the user gets no feedback if the screenshot fails (e.g. if they don't have permission to write in the chosen directory, etc). This patch adds a simple dialog showing the error message when a screenshot fails. --- src/virt-viewer-window.c | 24 1 file changed,

[virt-tools-list] [PATCH virt-viewer 3/3] Screenshot: reject unknown image type filenames

2017-07-19 Thread Jonathon Jongsma
If the image format cannot be determined for a screenshot filename, simply return an error informing the user that this is not a valid image format. In the past, if we couldn't determine the file type, we simply saved it as a PNG, and apended a ".png" file extension to the filename. This has

[virt-tools-list] [PATCH virt-viewer 1/3] Change default screenshot name to "Screenshot.png"

2017-07-19 Thread Jonathon Jongsma
Since the code attempts to append ".png" to filenames without an extension, it doesn't make much sense to have the default filename be extensionless. Including the extension on the default filename makes things more straightforward. Related: rhbz#1455832 --- src/virt-viewer-window.c | 2 +- 1

Re: [virt-tools-list] Adding support for cloud-init in virt-manager

2017-07-19 Thread Alvin Starr
On 07/19/2017 11:45 AM, Daniel P. Berrange wrote: On Wed, Jul 19, 2017 at 11:21:33AM -0400, Alvin Starr wrote: On 07/19/2017 08:48 AM, Cedric Bosdonnat wrote: On Wed, 2017-07-19 at 11:59 +, Delemotte Barthelemy wrote: Hello everybody, What do you think about allowing users to send

Re: [virt-tools-list] [virt-manager PATCH] gfxdetails: add checkbox for password visibility toggle

2017-07-19 Thread Cole Robinson
On 07/18/2017 11:09 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add a checkbox for password visibility toggle. > As we stored password of SPICE/VNC in clear text in XML, > it's easy to use in UI. > > Signed-off-by: Chen Hanxiao

Re: [virt-tools-list] Adding support for cloud-init in virt-manager

2017-07-19 Thread Alvin Starr
On 07/19/2017 08:48 AM, Cedric Bosdonnat wrote: On Wed, 2017-07-19 at 11:59 +, Delemotte Barthelemy wrote: Hello everybody, What do you think about allowing users to send cloud-init customization script directly from virt-manager ? (for instance open-stack's GUI horizon includes this

Re: [virt-tools-list] Adding support for cloud-init in virt-manager

2017-07-19 Thread Cedric Bosdonnat
On Wed, 2017-07-19 at 11:59 +, Delemotte Barthelemy wrote: > Hello everybody, > > What do you think about allowing users to send cloud-init customization > script directly from virt-manager ? (for > instance open-stack's GUI horizon includes this feature) > Here a blog article showing how to

Re: [virt-tools-list] Adding support for cloud-init in virt-manager

2017-07-19 Thread Cole Robinson
On 07/19/2017 07:59 AM, Delemotte Barthelemy wrote: > Hello everybody, > > What do you think about allowing users to send cloud-init customization script > directly from virt-manager ? (for instance open-stack's GUI horizon includes > this feature) > Here a blog article showing how to do with the

[virt-tools-list] Adding support for cloud-init in virt-manager

2017-07-19 Thread Delemotte Barthelemy
Hello everybody, What do you think about allowing users to send cloud-init customization script directly from virt-manager ? (for instance open-stack's GUI horizon includes this feature) Here a blog article showing how to do with the CLI: