Re: [virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Prefer ca-cert from display instead of proxy

On 10/11/19 12:35 PM, Victor Toso wrote: Hi, On Fri, Oct 11, 2019 at 11:07:25AM -0300, Eduardo Lima (Etrunko) wrote: Since oVirt engine version 4.3.2.1, the API returns certificate data for display connection in the VM XML, so users do not need to specify it from the command line anymore

[virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Prefer ca-cert from display instead of proxy

compatibility of older versions of oVirt. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1402909 Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 8eaa72e

[virt-tools-list] [PATCH virt-viewer] remote-viewer: Prefer ca-cert from display instead of proxy

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1402909 Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 5c7a379..71f9a23 100644 --- a/src/remote-viewer.c

Re: [virt-tools-list] [PATCH v4] remote-viewer: fix free on dangling pointer

ri(session); const gchar *mime = virt_viewer_session_mime_type(session); -if (uri == NULL) -uri = g_strdup(guri); - -remote_viewer_recent_add(uri, mime); +remote_viewer_recent_add(uri != NULL ? uri : (char *) guri, mime); Acked-by: Eduardo Lima (Etrunko) IMO, removing the &quo

Re: [virt-tools-list] [PATCH v2] remote-viewer: fix free on dangling pointer

On 10/1/19 12:51 PM, Victor Toso wrote: Hi, On Tue, Oct 01, 2019 at 11:17:22AM -0300, Eduardo Lima (Etrunko) wrote: On 10/1/19 7:09 AM, Victor Toso wrote: Patch builds now, but I started getting some warning when connecting to ovirt:// uri. (remote-viewer:16940): virt-viewer-CRITICAL **: 11

Re: [virt-tools-list] [PATCH v2] remote-viewer: fix free on dangling pointer

On 10/1/19 7:09 AM, Victor Toso wrote: Hi, On Mon, Sep 30, 2019 at 11:01:42AM -0300, Eduardo Lima (Etrunko) wrote: On 9/30/19 5:08 AM, Victor Toso wrote: From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem

Re: [virt-tools-list] [PATCH v2] remote-viewer: fix free on dangling pointer

On 9/30/19 5:08 AM, Victor Toso wrote: From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal, remote-viewer

Re: [virt-tools-list] [remote-viewer v1] remote-viewer: fix free on dangling pointer

On 9/27/19 10:35 AM, Victor Toso wrote: From: Victor Toso On remote_viewer_session_connected() we are passing a dup of URI of connection and freeing it afterwards. Problem is, we don't disconnect from listening "session-connected" and on an eventual second emission of this signal,

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Plug memory leak

On 8/29/19 12:50 PM, Victor Toso wrote: > On Wed, Aug 28, 2019 at 06:18:02PM -0300, Eduardo Lima (Etrunko) wrote: >> Error caught by valgrind, the OvirtCollection object created in function >> ovirt_foreign_menu_fetch_vm_async() was never freed. >> >> 433 (40 direc

[virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Plug memory leak

) by 0x570BC19: ??? (in /usr/lib64/libgio-2.0.so.0.6000.6) by 0x570C7EC: ??? (in /usr/lib64/libgio-2.0.so.0.6000.6) by 0x559005D: call_async_cb (ovirt-proxy.c:279) by 0x55B5A07: ??? (in /usr/lib64/librest-0.7.so.0.0.0) Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 5

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Factor out code to set file collection

On 8/26/19 9:47 AM, Victor Toso wrote: > Hi, > > On Mon, Aug 26, 2019 at 09:38:03AM -0300, Eduardo Lima (Etrunko) wrote: >> On 8/26/19 4:15 AM, Victor Toso wrote: >>> Hi, >>> >>> On Fri, Aug 23, 2019 at 11:38:05AM -0300, Eduardo Lima (Etrunko) wrote:

Re: [virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Factor out code to set file collection

On 8/26/19 4:15 AM, Victor Toso wrote: > Hi, > > On Fri, Aug 23, 2019 at 11:38:05AM -0300, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> src/ovirt-foreign-menu.c | 25 + >> 1 file changed, 17 inserti

[virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Factor out code to set file collection

Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index c2f43e6..190bb3b 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt

Re: [virt-tools-list] [PATCH virt-viewer v2] ovirt-foreign-menu: Only set domain_valid once

On 8/19/19 6:51 AM, Victor Toso wrote: > Hi, > > On Fri, Aug 16, 2019 at 03:25:54PM -0300, Eduardo Lima (Etrunko) wrote: >> In the case of having a valid storage domain without any ISO files, this >> variable can be reset to FALSE again in the next iteration of t

[virt-tools-list] [PATCH virt-viewer v2] ovirt-foreign-menu: Only set domain_valid once

In the case of having a valid storage domain without any ISO files, this variable can be reset to FALSE again in the next iteration of the loop, resulting in a misleading error message presented to the user. Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 7 +-- 1 file

Re: [virt-tools-list] [PATCH virt-viewer 1/2] ovirt-foreign-menu: Debug message in case of valid storage domain

This patch series has been sent from a wrong branch, please disregard. There should be only one patch which is a squashed version of both On 8/16/19 2:44 PM, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > src/ovirt-foreign-menu.c | 1 + > 1 fil

[virt-tools-list] [PATCH virt-viewer 1/2] ovirt-foreign-menu: Debug message in case of valid storage domain

Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 4ec0858..48b7b34 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-foreign-menu.c @@ -669,6 +669,7 @@ static

[virt-tools-list] [PATCH virt-viewer 2/2] ovirt-foreign-menu: Only set domain_valid once

In the case of having a valid storage domain without any ISO files, this variable can be reset to FALSE again in the next iteration of the loop, resulting in a misleading error message presented to the user. Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 6 -- 1 file

Re: [virt-tools-list] [virt-viewer PATCH] ovirt-foreign-menu: Fix warnings on Rawhide

ug("%s", msg); > + g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, "%s", > msg); > g_object_unref(task); > } > } > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - Red Hat etru...@redhat.com ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH virt-viewer v2] ovirt-foreign-menu: Fix endpoint for storage domains query

On 8/12/19 9:48 AM, Victor Toso wrote: > On Mon, Aug 12, 2019 at 09:36:39AM -0300, Eduardo Lima (Etrunko) wrote: >> Instead of fetching toplevel REST API query, we use the one relative >> from the data center, which returns more detailed information, >> especially the status

[virt-tools-list] [PATCH virt-viewer v2] ovirt-foreign-menu: Fix endpoint for storage domains query

Instead of fetching toplevel REST API query, we use the one relative from the data center, which returns more detailed information, especially the status of the storage domain. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427467 Signed-off-by: Eduardo Lima (Etrunko) --- in V2

[virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Fix endpoint for storage domains query

Instead of fetching toplevel REST API query, we use the one relative from the data center, which returns more detailed information, especially the status of the storage domain. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1427467 Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

On 6/7/19 10:37 AM, Christophe Fergeau wrote: > On Fri, Jun 07, 2019 at 10:04:19AM -0300, Eduardo Lima (Etrunko) wrote: >> On 6/6/19 1:22 PM, Christophe Fergeau wrote: >>> Hey, >>> >>> I'm not really comfortable with that patch, which ignores some errors, >

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

middle with an error message about insufficient permissions. Regards, Eduardo. > A few small comments below, > Fixed all leaks. > On Tue, May 28, 2019 at 11:11:41AM -0300, Eduardo Lima (Etrunko) wrote: >> ping >> >> On 4/10/19 5:20 PM, Eduardo Lima (Etrunko) wr

[virt-tools-list] [PATCH virt-viewer] configure: Fix check for govirt functions

Use saved CFLAGS and LIBS to avoid errors in the check programs. Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7b61821..c787e1e 100644 --- a/configure.ac +++ b/configure.ac

Re: [virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

ping On 4/10/19 5:20 PM, Eduardo Lima (Etrunko) wrote: > When accessing ovirt as a regular user, it may happen that queries to > Hosts, Clusters and Data Centers return errors due to insufficient > permissions, while they will work fine if access is done by admin user. > In this c

[virt-tools-list] [PATCH virt-viewer v3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

Lima (Etrunko) --- src/ovirt-foreign-menu.c | 51 ++-- 1 file changed, 39 insertions(+), 12 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 59c3d48..83bdf5b 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-foreign-menu.c

Re: [virt-tools-list] [PATCH virt-viewer 3/3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

Ouch, it looks like I missed this mail in my Inbox, somehow it slipped through the filters and was not moved to the folder. On 2/6/19 8:15 AM, Christophe Fergeau wrote: > On Tue, Feb 05, 2019 at 03:38:35PM -0200, Eduardo Lima (Etrunko) wrote: >> On 7/17/18 11:48 AM, Christophe Ferg

Re: [virt-tools-list] [PATCH virt-viewer v2 1/2] Update usage of GObject private structures

On 2/20/19 12:13 PM, Christophe Fergeau wrote: > Series looks good to me, > Reviewed-by: Christophe Fergeau Pushed, thanks > > On Wed, Feb 20, 2019 at 11:05:36AM -0300, Eduardo Lima (Etrunko) wrote: >> ping >> >> On 2/13/19 12:46 PM, Eduardo Lima (Etrunko) wrote

Re: [virt-tools-list] [PATCH virt-viewer v2 1/2] Update usage of GObject private structures

ping On 2/13/19 12:46 PM, Eduardo Lima (Etrunko) wrote: > New functions and macros have been added in glib 2.38 to better handle > this case. > > https://gitlab.gnome.org/GNOME/glib/blob/c8de2b11bbbf5705ee20bf68d0c11e455b441312/NEWS > > The old method is being deprecated

Re: [virt-tools-list] [virt-viewer PATCH 5/5] Switch to gnulib's compiler warning flags

On 2/13/19 3:27 PM, Marc-André Lureau wrote: > Hi > > On Wed, Feb 13, 2019 at 6:05 PM Daniel P. Berrangé > wrote: >> >> This enables many more compiler warnings than the current code. It also >> ensures that -Werror is enabled by default when building from GIT so >> that maintainers see

Re: [virt-tools-list] [PATCH virt-viewer v2] Update usage of GObject private structures

On 2/11/19 3:31 PM, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 06:24:37PM +0100, Christophe Fergeau wrote: >> Hey, >> >> Looks good to me, 2 comments below: >> >> On Thu, Feb 07, 2019 at 10:54:58AM -0200, Eduardo Lima (Etrunko) wrote: >> >

[virt-tools-list] [PATCH virt-viewer v2 2/2] iso-dialog: Move type definitions from header to source file

There is no reason for this object to define a private structure, so it is fine to make everything private to the dialog itself. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c | 108 +--- src/remote-viewer-iso-list-dialog.h | 13 2

[virt-tools-list] [PATCH virt-viewer v2 1/2] Update usage of GObject private structures

-off-by: Eduardo Lima (Etrunko) --- v2: Removed iso-list dialog patch which is dealt separately. --- src/ovirt-foreign-menu.c | 8 ++-- src/remote-viewer.c| 8 ++-- src/virt-viewer-app.c | 8 ++-- src/virt-viewer-display-spice.c

Re: [virt-tools-list] [PATCH virt-viewer] window: Use proper define from glib for ignoring deprecated warning

Please ignore this one, using the wrong define, it was sent from a wrong branch. On 2/13/19 11:00 AM, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > src/virt-viewer-window.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > dif

[virt-tools-list] [PATCH virt-viewer v2] window: Use proper define from glib for ignoring deprecated warning

Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer-window.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index 96b35f6..4bbe2ca 100644 --- a/src/virt-viewer-window.c +++ b/src/virt-viewer-window.c @@ -600,11

[virt-tools-list] [PATCH virt-viewer] window: Use proper define from glib for ignoring deprecated warning

Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer-window.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index 96b35f6..cbf3f29 100644 --- a/src/virt-viewer-window.c +++ b/src/virt-viewer-window.c @@ -600,11

Re: [virt-tools-list] [PATCH virt-viewer] Disable deprecation warnings for gtk_window_fullscreen_on_monitor

On 2/13/19 7:28 AM, Daniel P. Berrangé wrote: > On Tue, Feb 12, 2019 at 05:34:44PM -0200, Eduardo Lima (Etrunko) wrote: >> On 2/12/19 12:36 PM, Daniel P. Berrangé wrote: >>> We use GLIB_VERSION_MAX_ALLOWED to prevent use of functions from >>> GTK >= 3.12. When we do

Re: [virt-tools-list] [PATCH virt-viewer] Disable deprecation warnings for gtk_window_fullscreen_on_monitor

On 2/12/19 12:36 PM, Daniel P. Berrangé wrote: > We use GLIB_VERSION_MAX_ALLOWED to prevent use of functions from > GTK >= 3.12. When we do conditional compilation based on a GTK > version check, we must thus suppress the warning: > > CC libvirt_viewer_la-virt-viewer-window.lo >

[virt-tools-list] [PATCH virt-viewer v2] Update usage of GObject private structures

-off-by: Eduardo Lima (Etrunko) --- in v2: - Replace GET_PRIVATE macros with appropriate _get_instance_private() --- src/ovirt-foreign-menu.c | 8 ++-- src/remote-viewer-iso-list-dialog.c| 14 +- src/remote-viewer.c| 8 ++-- src/virt

[virt-tools-list] [PATCH virt-viewer v2] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

Lima (Etrunko) --- src/ovirt-foreign-menu.c | 46 +--- 1 file changed, 34 insertions(+), 12 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index d234a27..36ec2ed 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-foreign-menu.c

Re: [virt-tools-list] [PATCH virt-viewer 3/3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

On 7/17/18 11:48 AM, Christophe Fergeau wrote: > On Fri, Jul 06, 2018 at 09:59:23AM -0300, Eduardo Lima (Etrunko) wrote: >> When accessing ovirt as a regular user, it may happen that queries to >> Hosts, Clusters and Data Centers return errors due to insufficient >&g

[virt-tools-list] [PATCH virt-viewer v2] Add missing G_MODULE_EXPORT to signal handler

Fixes the Windows case where the dialog fails to show with the following message: warning: "Could not find signal handler 'virt_viewer_window_menu_change_cd_activate'" Signed-off-by: Eduardo Lima (Etrunko) --- in v2: - Apply similar fix to handlers in remote-viewer-iso-lis

Re: [virt-tools-list] [PATCH virt-viewer] Add missing G_MODULE_EXPORT to signal handler

On 1/18/19 5:30 PM, Marc-André Lureau wrote: > On Fri, Jan 18, 2019 at 6:58 PM Eduardo Lima (Etrunko) > wrote: >> >> Fixes the Windows case where the dialog fails to show with the following >> message: >> >> warning: "Could not find signal handler >&

[virt-tools-list] [PATCH virt-viewer] Add missing G_MODULE_EXPORT to signal handler

Fixes the Windows case where the dialog fails to show with the following message: warning: "Could not find signal handler 'virt_viewer_window_menu_change_cd_activate'" Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer-window.c | 2 +- 1 file changed, 1 insertion(+),

Re: [virt-tools-list] [virt-viewer] ovirt: Fix initial connection

} > -} else > -#endif > -{ > -if (!remote_viewer_initial_connect(self, type, guri, vvfile, > )) > - goto cleanup; > -} > +if (!remote_viewer_initial_connect(self, type, guri, vvfile, )) > +goto cleanup; > } >

Re: [virt-tools-list] [PATCH virt-viewer] Silence coverity warning about dead code

t; ncred ; i++) { > -const char *cred_type_to_str[] = { > -[VIR_CRED_USERNAME] = "Identity to act as", > -[VIR_CRED_AUTHNAME] = "Identify to authorize as", > -[VIR_CRED_PASSPHRASE] = "Passphrase secret", > -

Re: [virt-tools-list] [PATCH virt-viewer] Relax Gtk+ requirement slightly

gdk_screen_get_default(), monitor); > } > +#else > +gtk_window_fullscreen(GTK_WINDOW(priv->window)); > +#endif /* GTK_CHECK_VERSION */ > } > > #define MAX_KEY_COMBO 4 > Acked-by: Eduardo Lima (Etrunko) -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH virt-viewer 0/2] Initial support for building with meson/ninja

On 10/4/18 9:41 AM, Eduardo Lima (Etrunko) wrote: > On 10/4/18 7:48 AM, Daniel P. Berrangé wrote: >> On Wed, Sep 12, 2018 at 11:07:57AM +0200, Eduardo Lima (Etrunko) wrote: >>> The first patch is a preparation for the new build system. As it uses >>> a built in

Re: [virt-tools-list] [PATCH virt-viewer 0/2] Initial support for building with meson/ninja

On 10/4/18 7:48 AM, Daniel P. Berrangé wrote: > On Wed, Sep 12, 2018 at 11:07:57AM +0200, Eduardo Lima (Etrunko) wrote: >> The first patch is a preparation for the new build system. As it uses >> a built in function provided by meson for generating the enum files, it >> is no

[virt-tools-list] [PATCH virt-viewer v2] Add support for building with meson/ninja

Signed-off-by: Eduardo Lima (Etrunko) --- In v2: - Add meson.build files to EXTRA_DIST - Fix typo meson meson_vesrion -> meson_version - Minimal cleanups --- Makefile.am | 3 + data/Makefile.am | 1 + data/meson.build | 16 icons/Makefile.am | 2 + icons/meson.bu

Re: [virt-tools-list] [PATCH virt-viewer] fixup! Typo: meson_vesrion -> meson_version

On 09/14/2018 09:47 AM, Eduardo Lima (Etrunko) wrote: > --- > meson.build | 2 +- > subprojects/spice-single.wrap | 4 > 2 files changed, 5 insertions(+), 1 deletion(-) > create mode 100644 subprojects/spice-single.wrap > > diff --git a/meson.build

[virt-tools-list] [PATCH virt-viewer] fixup! Typo: meson_vesrion -> meson_version

--- meson.build | 2 +- subprojects/spice-single.wrap | 4 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 subprojects/spice-single.wrap diff --git a/meson.build b/meson.build index 4c6729d..3b7ed7e 100644 --- a/meson.build +++ b/meson.build @@ -1,7

[virt-tools-list] [PATCH virt-viewer 0/2] Initial support for building with meson/ninja

, which I don't really know how to implement, but should not be difficult. Eduardo Lima (Etrunko) (2): build: Keep original type name as generated from glib-mkenums Add support for building with meson/ninja data/meson.build | 16 +++ icons/meson.build | 14 +++ man/meson.build

[virt-tools-list] [PATCH virt-viewer 2/2] Add support for building with meson/ninja

Signed-off-by: Eduardo Lima (Etrunko) --- data/meson.build | 16 icons/meson.build | 14 man/meson.build | 16 meson.build | 206 ++ meson_options.txt | 25 ++ po/meson.build| 2 + src/meson.build | 116

[virt-tools-list] [PATCH virt-viewer 1/2] build: Keep original type name as generated from glib-mkenums

Signed-off-by: Eduardo Lima (Etrunko) --- src/Makefile.am | 4 ++-- src/virt-viewer-display.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0a3cbbf..0472908 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -40,8

Re: [virt-tools-list] [virt-viewer] ovirt: Filter everything which does not end in .iso

.qcow2 files in it, which can't be assigned to a VM either. > This commit filters every file which does not have a .iso extension as > it's unlikely to be possible to use it. > > Signed-off-by: Christophe Fergeau Acked-by: Eduardo Lima (Etrunko) > --- > src/ovirt-foreign-menu.

[virt-tools-list] [PATCH virt-viewer 2/3] ovirt-foreign-menu: New function storage_domain_validate()

It may be useful to know why the storage domain has not been listed, given that there are different reasons for that. To make it easier to provide more detailed debug messages, we move code from the callback function to this new one. Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign

[virt-tools-list] [PATCH virt-viewer 1/3] build: Update govirt and rest requirements

With these new values, 0.3.3 for libgovirt and 0.8 for librest, we can remove checks for OVIRT_REST_CALL_ERROR_CANCELLED and correspondent rest_proxy_auth_cancel(). Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac| 11 --- src/remote-viewer.c | 4 2 files changed, 4

[virt-tools-list] [PATCH virt-viewer 3/3] ovirt-foreign-menu: Bypass errors from Host/Cluster/Data Center

Lima (Etrunko) --- src/ovirt-foreign-menu.c | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 70a0b50..8ed08c9 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-foreign

Re: [virt-tools-list] [virt-viewer 2/4] spice: Stop using deprecated SpiceMainChannel API

On 29/06/18 05:12, Christophe Fergeau wrote: > On Thu, Jun 28, 2018 at 05:09:48PM -0300, Eduardo Lima (Etrunko) wrote: >> On 14/06/18 13:01, Christophe Fergeau wrote: >>> spice_main_set_display and spice_main_set_display_enabled have been >>> superseded by spice_

Re: [virt-tools-list] [virt-viewer v2] ovirt: Improve handling of g_strv_contains()

Acked-by: Eduardo Lima (Etrunko) On 29/06/18 05:13, Christophe Fergeau wrote: > The ovirt code uses g_strv_contains() with fallback code in > glib-compat.h when we are using a glib version where it's not available. > However, when we use a glib version where g_strv_contains is availa

Re: [virt-tools-list] [virt-viewer 2/4] spice: Stop using deprecated SpiceMainChannel API

On 14/06/18 13:01, Christophe Fergeau wrote: > spice_main_set_display and spice_main_set_display_enabled have been > superseded by spice_main_channel_update_display and > spice_main_channel_update_display_enabled > May I ask the reasoning for keeping compatibility with older version instead of

Re: [virt-tools-list] [virt-viewer 4/4] ovirt: Improve handling of g_strv_contains()

TNESS FOR A PARTICULAR PURPOSE. See the > - * GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 59 Temple Pl

Re: [virt-tools-list] [virt-viewer 3/4] window: Adjust get_image_format() prototype

Acked-by: Eduardo Lima (Etrunko) On 14/06/18 13:01, Christophe Fergeau wrote: > This adds an unused parameter, but lets us get rid of this new warning > with gcc 8: > > virt-viewer-window.c: In function 'get_image_format': > virt-viewer-window.c:930:33: warning: cast betwe

Re: [virt-tools-list] [virt-viewer 1/4] app: Remove VirtViewerApp::has-focus

Acked-by: Eduardo Lima (Etrunko) On 14/06/18 13:01, Christophe Fergeau wrote: > This is no longer needed since 140cb84 > 'remote-viewer: remove --spice-controller' > > Signed-off-by: Christophe Fergeau > --- > src/virt-viewer-app.c | 44 ---

[virt-tools-list] [PATCH virt-viewer] build: Explicitly link against librest

-viewer.o: undefined reference to symbol 'rest_proxy_auth_cancel' /home/elima/install/govirt-usr/lib/librest-0.7.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status Signed-off-by: Eduardo Lima (Etrunko) --- configure.ac| 3 ++- src/Makefile.am | 2

Re: [virt-tools-list] [remote-viewer] remote-viewer-connect: centralize window

On 30/05/18 09:47, Victor Toso wrote: > From: Victor Toso > > Instead of top-left corner. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1508274 > > Signed-off-by: Victor Toso Acked-by: Eduardo Lima (Etrunko) > --- > src/resources/ui/remote-viewer

Re: [virt-tools-list] [PATCH virt-viewer v3] Fixes to spec file

On 27/11/17 07:37, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau <cferg...@redhat.com> Pushed, Thanks. > > On Thu, Nov 23, 2017 at 11:52:53AM -0200, Eduardo Lima (Etrunko) wrote: >> - Use macros for paths instead of absolute paths. >> - Re

Re: [virt-tools-list] [PATCH virt-viewer v2] Fixes to spec file

On 22/11/17 16:35, Christophe Fergeau wrote: > On Wed, Nov 22, 2017 at 04:21:49PM -0200, Eduardo Lima (Etrunko) wrote: >> - Use macros for paths instead of absolute paths. >> - Fix scope of enable_autotools macro to avoid warning during build. >> warning: Macro %ena

[virt-tools-list] [PATCH virt-viewer v3] Fixes to spec file

- Use macros for paths instead of absolute paths. - Remove dangling %{gtk_arg} macro in configure. - Fix scope of enable_autotools macro to avoid warning during build. warning: Macro %enable_autotools defined but not used within scope Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.

[virt-tools-list] [PATCH virt-viewer v2] Fixes to spec file

- Use macros for paths instead of absolute paths. - Fix scope of enable_autotools macro to avoid warning during build. warning: Macro %enable_autotools defined but not used within scope Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- virt-viewer.spec.i

[virt-tools-list] [PATCH virt-viewer] doc: Adjust reference to spice-gtk man page for remote-viewer

Similar to last commit, as noticed by reporter in bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1477966 Man page should reference spice-client, not spice-gtk. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- man/remote-viewer.pod | 2 +- 1 file changed, 1 insertion

Re: [virt-tools-list] [virt-viewer] doc: Adjust reference to spice-gtk man page

On 21/09/17 06:12, Daniel P. Berrange wrote: > On Thu, Sep 21, 2017 at 10:16:56AM +0200, Christophe Fergeau wrote: >> The man page spice-gtk ships is named "spice-client", not "spice-gtk" >> >> Signed-off-by: Christophe Fergeau >> >>

Re: [virt-tools-list] [PATCH virt-viewer] Fixes to spec file

On 17/11/17 11:39, Eduardo Lima (Etrunko) wrote: > - Use macros for paths instead of absolute paths. > - Fix scope of enable_autotools macro to avoid warning during build. > warning: Macro %enable_autotools defined but not used within scope > - Remove references to spice-xpi-clien

Re: [virt-tools-list] Status of virt-viewer headerbar conversion ?

On 17/11/17 11:45, Daniel P. Berrange wrote: > A while ago now we had patches going through review that switched over to > use Gtk HeaderBar concept. I was wondering what the status of that is, as > I think it would be a nice step forward for virt-viewer UI. > As far as I remember, the idea was

[virt-tools-list] [PATCH virt-viewer] Fixes to spec file

- Use macros for paths instead of absolute paths. - Fix scope of enable_autotools macro to avoid warning during build. warning: Macro %enable_autotools defined but not used within scope - Remove references to spice-xpi-client Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> ---

Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Pass guri to remote_viewer_session_connected

On 14/11/17 15:01, Victor Toso wrote: > Hi, > > On Tue, Nov 14, 2017 at 02:54:30PM -0200, Eduardo Lima (Etrunko) wrote: >> When connecting to a VM via oVirt instance, the original uri can not be >> retrieved using virt_viewer_session_get_uri(). Consequently, it was >&g

[virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Pass guri to remote_viewer_session_connected

To solve this problem, we always pass a copy of the guri as user-data parameter for the callback, and if the call to virt_viewer_session_get_uri() returns NULL, the parameter is used instead. Resolves: https://bugzilla.redhat.com/1459792 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

Re: [virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Pass guri to remote_viewer_session_connected

On 14/11/17 14:38, Victor Toso wrote: > Hi, > > On Tue, Nov 14, 2017 at 02:14:25PM -0200, Eduardo Lima (Etrunko) wrote: >> On 14/11/17 13:47, Victor Toso wrote: >>> On Thu, Oct 26, 2017 at 03:39:31PM +0200, Eduardo Lima (Etrunko) wrote: >>>> When c

Re: [virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Pass guri to remote_viewer_session_connected

On 14/11/17 13:47, Victor Toso wrote: > On Thu, Oct 26, 2017 at 03:39:31PM +0200, Eduardo Lima (Etrunko) wrote: >> When connecting to a VM via oVirt instance, the original uri can not be >> retrieved using virt_viewer_session_get_uri(). Consequently, it was >> nev

Re: [virt-tools-list] virt-viewer 6.0 download problems

On 31/10/17 17:32, Wow Zaza wrote: > Thank you for the replies. I was able to download using Firefox. I tried > using Chrome, Edge, and Internet Explorer. None of them worked. Although > my problem is solved, could it be a compilation issue on your end? Only > one of the major browser is able to

Re: [virt-tools-list] virt-viewer 6.0 download problems

On 31/10/17 16:13, Daniel P. Berrange wrote: > On Mon, Oct 30, 2017 at 08:27:46PM +, Wow Zaza wrote: >> I want to bring to your attention that the virt-viewer 6.0 (x86 and x64) >> download aren't currently accessible via the download link. When you >> click on the download link, all you see is

[virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Pass guri to remote_viewer_session_connected

To solve this problem, we always pass a copy of the guri as user-data parameter for the callback, and if the call to virt_viewer_session_get_uri() returns NULL, the parameter is used instead. Resolves: https://bugzilla.redhat.com/1459792 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

Re: [virt-tools-list] [PATCH virt-viewer] remote-viewer: Pass guri to remote_viewer_session_connected

On 20/10/17 15:10, Eduardo Lima (Etrunko) wrote: > When connecting to a VM via oVirt instance, the original uri can not be > retrieved using virt_viewer_session_get_uri(). Consequently, it was > never saved, even though the connection succeeds and the actual callback > for "

[virt-tools-list] [PATCH virt-viewer] remote-viewer: Pass guri to remote_viewer_session_connected

To solve this problem, we always pass a copy of the guri as user-data parameter for the callback, and if the call to virt_viewer_session_get_uri() returns NULL, the parameter is used instead. Resolves: https://bugzilla.redhat.com/1459792 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

Re: [virt-tools-list] [PATCH virt-viewer v2 0/4] Support for ovirt data center related functions

On 06/10/17 09:43, Victor Toso wrote: > Ack > Pushed, thanks > - Original Message - >> v2: >> - Check for new functions in configure. >> - Added #ifdef guards for the new functions. >> >> Eduardo Lima (Etrunko) (4): >> configure: chec

[virt-tools-list] [PATCH virt-viewer v2 0/4] Support for ovirt data center related functions

v2: - Check for new functions in configure. - Added #ifdef guards for the new functions. Eduardo Lima (Etrunko) (4): configure: check for new functions in libgovirt foreign-menu: Use query for fetching virtual machines ovirt-foreign-menu: Fetch host, cluster and data center information

[virt-tools-list] [PATCH virt-viewer v2 3/4] ovirt-foreign-menu: Fetch host, cluster and data center information

with that scenario. We fix this problem by making use of new functions in libgovirt, adding support or hosts, clusters and data centers. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467 https://bugzilla.redhat.com/show_bug.cgi?id=1428401 Signed-off-by: Eduardo Lima (Etrunko) <e

[virt-tools-list] [PATCH virt-viewer v2 2/4] foreign-menu: Use query for fetching virtual machines

This can save us some bandwidth, as we are searching for the specific virtual machine instead of retrieving the collection with all VMs, and then iterating over the results after the transfer finishes. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu

[virt-tools-list] [PATCH virt-viewer v2 1/4] configure: check for new functions in libgovirt

Lima (Etrunko) <etru...@redhat.com> --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 9ca6cb6..61374fa 100644 --- a/configure.ac +++ b/configure.ac @@ -190,6 +190,10 @@ AS_IF([test "x$with_ovirt" = "xyes&q

[virt-tools-list] [PATCH virt-viewer v2 4/4] foreign-menu: Check if storage domain is active for data center

. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467 https://bugzilla.redhat.com/show_bug.cgi?id=1428401 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am | 2 ++ src/glib-compat.c| 35 +++ sr

Re: [virt-tools-list] [PATCH virt-viewer 1/3] foreign-menu: Use query for fetching virtual machines

On 06/08/17 18:53, Pavel Grunt wrote: > Hi, > > 2017-08-04 23:53 GMT+02:00 Eduardo Lima (Etrunko) <etru...@redhat.com > <mailto:etru...@redhat.com>>: > > This can save us some bandwidth, as we are searching for the specific > virtual machine instead of r

[virt-tools-list] [PATCH virt-viewer 3/3] foreign-menu: Check if storage domain is active for data center

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am | 2 ++ src/glib-compat.c| 35 +++ src/glib-compat.h| 39 +++ src/ovirt-foreign-menu.c | 22 ++ 4

[virt-tools-list] [PATCH virt-viewer 2/3] ovirt-foreign-menu: Fetch host, cluster and data center information

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467 https://bugzilla.redhat.com/show_bug.cgi?id=1428401 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 141 +++ 1 file changed, 141 inse

[virt-tools-list] [PATCH virt-viewer 1/3] foreign-menu: Use query for fetching virtual machines

This can save us some bandwidth, as we are searching for the specific virtual machine instead of retrieving the collection with all VMs, and then iterating over the results after the transfer finishes. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu

Re: [virt-tools-list] [PATCH virt-viewer 5/6] remote-viewer: add a --dbus-controller

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Allow to set connection details via DBus, and add a Connect method. > This is intended to replace the Spice controller. > > Sample usage: > > DEST=`remote-viewer --dbus-controller`

Re: [virt-tools-list] [PATCH virt-viewer 4/6] remote-viewer: factor our remote_viewer_initial_connect()

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > -

Re: [virt-tools-list] [PATCH virt-viewer 3/6] app: add dbus-ctrl property

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > If the dbus-ctrl property is set, we should call open_uri() without > guri set. > My general feeling is that this patch could be merged with the option parsing on the follow up

Re: [virt-tools-list] [PATCH virt-viewer 2/6] session: remove virt_viewer_session_new() declaration

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > The function was removed in commit > 05333f0e93fb988c2fd9302e67671490941aedb0. Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > > Si

  1   2   3   4   >