Re: [virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

2016-06-23 Thread Eduardo Lima (Etrunko)
On 06/23/2016 01:35 PM, Christophe Fergeau wrote: > This looks fine to me, however I'd rephrase the shortlog (or add to the > long log) that we get the Change CD menu from the UI file rather than > manually creating it. Before looking at the commit, I was not sure what > this was about. Okay

Re: [virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

2016-06-23 Thread Christophe Fergeau
This looks fine to me, however I'd rephrase the shortlog (or add to the long log) that we get the Change CD menu from the UI file rather than manually creating it. Before looking at the commit, I was not sure what this was about. Christophe On Thu, Jun 23, 2016 at 11:23:11AM -0300, Eduardo Lima

[virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

2016-06-23 Thread Eduardo Lima (Etrunko)
This patch is a preparation for a upcoming UI change that will present the ISO list in a separate dialog, instead of a submenu. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 23 +++ src/resources/ui/virt-viewer.ui | 8