Re: [virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

2016-02-15 Thread Eduardo Lima (Etrunko)
On 02/15/2016 11:57 AM, Fabiano Fidêncio wrote: > > NACK from me. > There is no reason for keeping an empty virt-glib-compat.c file. > virt-glib-compat.h also could be removed entirely as g_clear_pointer() > was introduced in 2.34. So, please, remove both files from the tree. > > Reviewed-by:

Re: [virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

2016-02-15 Thread Fabiano Fidêncio
On Fri, 2016-02-12 at 09:35 -0200, Eduardo Lima (Etrunko) wrote: > With glib requirements now being 2.38, these functions do not make > sense anymore > > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/virt-glib-compat.c | 15 --- >  src/virt-glib-compat.h | 27

[virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

2016-02-12 Thread Eduardo Lima (Etrunko)
With glib requirements now being 2.38, these functions do not make sense anymore Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-glib-compat.c | 15 --- src/virt-glib-compat.h | 27 --- 2 files changed, 42 deletions(-) diff --git