Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-19 Thread Christophe Fergeau
On Mon, Jul 18, 2016 at 11:15:03AM +0200, Pavel Grunt wrote: > Hi Eduardo, > > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: > > Use switch/case instead of lots of conditional blocks > Yes, it is more readable > > > > Signed-off-by: Eduardo Lima (Etrunko) > > --- > >  src/ovir

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-18 Thread Pavel Grunt
On Mon, 2016-07-18 at 12:18 -0300, Eduardo Lima (Etrunko) wrote: > On 07/18/2016 11:58 AM, Pavel Grunt wrote: > > > > On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote: > > > > > > On 07/18/2016 06:15 AM, Pavel Grunt wrote: > > > > > > > > > > > > Hi Eduardo, > > > > > > > > On S

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-18 Thread Eduardo Lima (Etrunko)
On 07/18/2016 11:58 AM, Pavel Grunt wrote: > On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote: >> On 07/18/2016 06:15 AM, Pavel Grunt wrote: >>> >>> Hi Eduardo, >>> >>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: Use switch/case instead of lots of condi

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-18 Thread Pavel Grunt
On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote: > On 07/18/2016 06:15 AM, Pavel Grunt wrote: > > > > Hi Eduardo, > > > > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: > > > > > > Use switch/case instead of lots of conditional blocks > > Yes, it is more readabl

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-18 Thread Eduardo Lima (Etrunko)
On 07/18/2016 06:15 AM, Pavel Grunt wrote: > Hi Eduardo, > > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: >> Use switch/case instead of lots of conditional blocks > Yes, it is more readable >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> src/ovirt-foreign-menu.c | 76 ++

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-18 Thread Pavel Grunt
Hi Eduardo, On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: > Use switch/case instead of lots of conditional blocks Yes, it is more readable > > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/ovirt-foreign-menu.c | 76 +++-- > --- >  1

[virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

2016-07-17 Thread Eduardo Lima (Etrunko)
Use switch/case instead of lots of conditional blocks Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 76 +++- 1 file changed, 36 insertions(+), 40 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c inde