Re: [virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

2016-07-20 Thread Christophe Fergeau
On Tue, Jul 19, 2016 at 03:04:58PM -0300, Eduardo Lima (Etrunko) wrote: > On 07/19/2016 02:54 PM, Eduardo Lima (Etrunko) wrote: > > On 07/19/2016 12:57 PM, Christophe Fergeau wrote: > >>> + > >>> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog); > >>> +self->priv->foreign_menu = foreign_menu;

Re: [virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

2016-07-19 Thread Eduardo Lima (Etrunko)
On 07/19/2016 02:54 PM, Eduardo Lima (Etrunko) wrote: > On 07/19/2016 12:57 PM, Christophe Fergeau wrote: >>> + >>> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog); >>> +self->priv->foreign_menu = foreign_menu; >> >> I'd g_object_ref it if you need to have it around (together with >>

Re: [virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

2016-07-19 Thread Eduardo Lima (Etrunko)
On 07/19/2016 12:57 PM, Christophe Fergeau wrote: >> + >> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog); >> +self->priv->foreign_menu = foreign_menu; > > I'd g_object_ref it if you need to have it around (together with > g_clear_object > in dispose/finalize). Okay, fixed. >> + >>

Re: [virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

2016-07-19 Thread Christophe Fergeau
On Sun, Jul 17, 2016 at 11:13:10PM -0300, Eduardo Lima (Etrunko) wrote: > The OvirtForeignMenu pointer is needed by the new ISO list dialog, and > we make it acessible via property to avoid interdependency between > objects. > > Signed-off-by: Eduardo Lima (Etrunko) > --- >

[virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

2016-07-17 Thread Eduardo Lima (Etrunko)
The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer-iso-list-dialog.c | 20 +++-