Re: [virt-tools-list] ANNOUNCE: virt-manager 0.8.5 and virtinst 0.500.4

Hi Cole, Is there a problem with the Virt-manager build system ? u...@debian:~/debian/virt-manager/virt-manager-0.8.5$ ./configure checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /bin/mkdir -p

Re: [virt-tools-list] VirtManager iSCSI

On 08/25/2010 01:26 AM, Mike Hall wrote: I successfully added an iSCSI target in VirtManager using '/dev/disk/by-path' as the Target Path, and can now see the LUN on that target in the Volumes listing. However, I do not appear able to use this LUN as a location to store a file image when

[virt-tools-list] virt-manager reporting wrong virtinst version and refuse to start

I'v installed virtinst 0.500.4(sudo python setup.py install ), but virt-manager 0.8.5 is still reporting virtinst version 0.500.1 is too old on launch. ___ virt-tools-list mailing list virt-tools-list@redhat.com

Re: [virt-tools-list] ANNOUNCE: virt-manager 0.8 .5 and virtinst 0.500.4

Le mercredi 25 août 2010 15:40:27, Cole Robinson a écrit : On 08/25/2010 08:33 AM, Laurent Léonard wrote: Hi Cole, Is there a problem with the Virt-manager build system ? u...@debian:~/debian/virt-manager/virt-manager-0.8.5$ ./configure checking for a BSD-compatible install...

[virt-tools-list] [PATCH 00/47] Restructure libosinfo codebase

This (huge) patch series updates libosinfo to more closely follow common GLib/GObject design practice/coding standards. The bulk of this is re-engineering the public API and object relationships. The current code has created separate objects and classes for all major functional items, but the

[virt-tools-list] [PATCH 02/47] Move Makefile.am into each sub-dir

Move Makefile.am into each sub-dir so that built objects end up in the same directory as the sources, instead of polluting the top level. This will also enable the gobject introspection makefile rules to be imported later * .gitignore: test-skeleton test-skeleton.sh * Makefile.am: Remove all

[virt-tools-list] [PATCH 06/47] Sanitize API naming for OsinfoEntity class

The GObject naming conversion is lowercase, separated by underscores. This needs to be followed to allow gobject introspection to be auto-generated easily. * osinfo/osinfo_common.h: Remove declaration of methods that belong in osinfo_entity.h * osinfo/osinfo_entity.c, osinfo/osinfo_entity.h:

[virt-tools-list] [PATCH 18/47] Add constructors for all objects. Remove constructor for abstract list object

While using g_object_new() is functionally fine, it is not type-safe/checked. It should generally only be used by bindings for non-C language. Add explicit constructors for every object and update all callers of g_object_new to use the new constructors. * osinfo/osinfo.h,

[virt-tools-list] [PATCH 10/47] Remove more malloc failure checks

GLib will always abort() upon malloc failure, so there is no need to check return value of any g_object_new, g_new or g_strdup API call. Remove all this redundant ENOMEM checking * osinfo/osinfo_common.c, osinfo/osinfo_dataread.c, osinfo/osinfo_db.c, osinfo/osinfo_devicelist.c,

[virt-tools-list] [PATCH 09/47] Sanitize naming of filter object APIs

The GObject naming conversion is lowercase, separated by underscores. This needs to be followed to allow gobject introspection to be auto-generated easily. * osinfo/osinfo_filter.c, osinfo/osinfo_filter.h: Convert API naming to use lowercase + underscores. Add an explicit constructor. ---

[virt-tools-list] [PATCH 12/47] Make osinfo_list_add into a public API

Make osinfo_list_add a public API on OsinfoList since apps should be allowed to manipulate objects at will if they're not using the XML loader. This also avoids compile warnings from other objects using this API without it being declared * osinfo/osinfo_list.h, osinfo/osinfo_list.c: Make

[virt-tools-list] [PATCH 15/47] Remove unused error variables from more iterators

The iterators used in the OsinfoDb class pass around an GError object but none of the codepaths can ever fail, since all the ENOMEM code was remove. The GError variable is thus redundant * osinfo/osinfo_common.h, osinfo/osinfo_db.c: Remove GError from the iterators --- osinfo/osinfo_common.h |

[virt-tools-list] [PATCH 21/47] Remove unused error strings

Since most of the GError code was remove, the method __osinfoErrorToString is now unused, as are all the error strings. Remove them all * osinfo/osinfo_common.c, osinfo/osinfo_common.h: Remove __osinfoErrorToString and all strings --- osinfo/osinfo_common.c |8

[virt-tools-list] [PATCH 20/47] Make device object struct fully private

Classes should not expose their private bits to each other. Make the OsinfoDevice private struct truely private. * osinfo/osinfo_common.h: Remove OsinfoDevicePrivate * osinfo/osinfo_device.c: Add OsinfoDevicePrivate * osinfo/osinfo_devicelist.c, osinfo/osinfo_hypervisorlist.c,

[virt-tools-list] [PATCH 26/47] Remove 2 unused struct definitions

The __osinfoPopulateListArgs and __osinfoFilterPassArgs structs are not used anymore. * osinfo/osinfo_common.h: Remove unused structs --- osinfo/osinfo_common.h |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/osinfo/osinfo_common.h b/osinfo/osinfo_common.h index

[virt-tools-list] [PATCH 19/47] Make osinfo DB struct private change to use a OsinfoList internally

Classes should expose their private bits to each other. Make the OsinfoDb private struct truely private. Switch from using a GTree in OsinfoDb over to a OsinfoList to simplify the code. * osinfo/osinfo_db.c, osinfo/osinfo_db.h: Add private data struct convert from OsinfoList instead of GTree *

[virt-tools-list] [PATCH 22/47] Replace some temporary GTree objects with GHashTable

Using a GHashTable + GList combination instead of GTree and GPtrArray results in shorter, simpler code and is more inline with normal GLib practice. * osinfo/osinfo_common.h, osinfo/osinfo_db.c, osinfo/osinfo_db.h, osinfo/osinfo_list.c: Replace several GTree objects with GHashTable ---

[virt-tools-list] [PATCH 36/47] Remove osinfo common module

Finally all objects are fully private and the common code module can be banished. * osinfo/osinfo_common.c, osinfo/osinfo_common.h: Delete * osinfo/Makefile.am, osinfo/osinfo.h: Remove osinfo_common.h * configure.ac: Use osinfo/osinfo_db.c in CONFIG_SRCDIR * osinfo/osinfo_dataread.c,

[virt-tools-list] [PATCH 29/47] Remove sections from hypervisor device list

Arranging devices in sections against hypervisors duplicates information already available via the 'class' attribute on the device object. Removing this unneccessary data simplifies the code, allowing a pair of GTree maps to be replaced by a single GList. * data/libosinfo-dummy-data.xml: Remove

[virt-tools-list] [PATCH 42/47] Use pkg-config for checking for libxml

Rather than creating huge amounts of m4 logic, just use pkg-config to check for libxml2 library. Make libxml2 compulsory * configure.ac: Simplify libxml2 check --- configure.ac | 47 + osinfo/osinfo_dataread.c | 10 - 2 files

[virt-tools-list] [PATCH 31/47] Turn OS relationships into a GList structure

Simplify storage of OS relationships by using a single GList instead of a pair of GTree objects. The data access patterns mean there is no change in access efficiency * osinfo/osinfo_common.h, osinfo/osinfo_dataread.c, osinfo/osinfo_db.c, osinfo/osinfo_entity.c, osinfo/osinfo_os.c,

[virt-tools-list] [PATCH 23/47] Turn filter matching functions into formal APIs

Instead of having the osinfo_common.c module poking into the private parts of OsinfoFilter and OsinfoEntity objects, move the code into OsinfoEntity and use formal APIs for all data access * osinfo/osinfo_filter.c, osinfo/osinfo_filter.h, osinfo/osinfo_entity.c, osinfo/osinfo_entity.h: Add

[virt-tools-list] [PATCH 24/47] Fix reference count handling in device list

When adding an OsinfoEntity to an OsinfoList, an explicit reference should be taken on the entity, rather than relying on the caller to have done it. * osinfo/osinfo_list.c: Take an extra reference when adding an entity to the list * osinfo/osinfo_dataread.c: Release a reference after adding

[virt-tools-list] [PATCH 47/47] Add LGPLv2+ header to all source files

* osinfo/*.h, osinfo/*.c: Add license header text * COPYING.LIB: LGPLv2+ license * libosinfo.spec.in, mingw32-libosinfo.spec.in, Makefile.am: Use COPYING.LIB instead of COPYING --- COPYING.LIB| 508 Makefile.am|

[virt-tools-list] [PATCH 30/47] Remove sections from OS device list

Arranging devices in sections against operating systems duplicates information already available via the 'class' attribute on the device object. Removing this unneccessary data simplifies the code, allowing a pair of GTree maps to be replaced by a single GList. * data/libosinfo-dummy-data.xml:

[virt-tools-list] [PATCH 35/47] Convert filter constraints from GTree to GHashTable

Simply code and follow more normal GLib practice by using a GHashTable of GLists for filter property storage, instead of a GTree of GPtrArrays * osinfo/osinfo_filter.c, osinfo/osinfo_filter.h: Convert to use a GHashTable of GLists for filter properties * osinfo/osinfo_common.c,

[virt-tools-list] [PATCH 40/47] Run configure at end of autogen.sh

It is usual practice to run configure at the end of autogen.sh to save having to manually run it afterwards * autogen.sh: Run configure --- autogen.sh |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/autogen.sh b/autogen.sh index 2bacd4c..de14206 100755 --- a/autogen.sh

[virt-tools-list] [PATCH 37/47] Fix filter class/object inheritance add constructor

The OsinfoFilter structs mistakenly included the OsinfoEntity structs, even though the type inherits direct from GObject. * osinfo/osinfo_filter.c, osinfo/osinfo_filter.h: Fix struct parent, and add an explicit constructor --- osinfo/osinfo_filter.c |6 ++ osinfo/osinfo_filter.h |6

[virt-tools-list] [PATCH 43/47] Add a pkg-config data file for building apps

* configure.ac: Generate libosinfo.pc * osinfo/Makefile.am: Install pkg-config file * osinfo/libosinfo-1.0.pc.in: Master pkg-config template --- .gitignore |1 + configure.ac |1 + osinfo/Makefile.am |5 - osinfo/libosinfo-1.0.pc.in | 11

[virt-tools-list] [PATCH 46/47] Add formal RPM build infrastructure

* autogen.sh: Rewrite to use gnome-autogen.sh * autobuild.sh: Automated RPM build control script * configure.ac: Generate RPM specfiles * Makefile.am: Distribute RPM specfile templates * libosinfo.spec.in, mingw32-libosinfo.spec.in: RPM specs * osinfo/Makefile.am, osinfo/libosinfo.syms: Fix Win32