Re: [virt-tools-list] [virt-manager PATCH] pycodestyle: fix all E203 warnings

[Cole Robinson]

On 08/09/2017 10:47 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao 
> 
>Fix all E203 whitespace before ':'
> 
> Signed-off-by: Chen Hanxiao 
> ---
> v2: fix a small indent

ACK, but amend the patch to also remove E203 from the pycodestyle.cfg so we
test for it in the future too

- Cole

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

[virt-tools-list] [virt-manager PATCH] pycodestyle: fix all E203 warnings

[Chen Hanxiao]

From: Chen Hanxiao 

   Fix all E203 whitespace before ':'

Signed-off-by: Chen Hanxiao 
---
v2: fix a small indent

 setup.py   |   4 +-
 tests/clitest.py   |  66 +++
 tests/clonetest.py |   4 +-
 tests/nodedev.py   |   2 +-
 virt-install   |   4 +-
 virtManager/addhardware.py |  50 +-
 virtManager/asyncjob.py|   4 +-
 virtManager/clone.py   |  18 +++
 virtManager/config.py  |  40 +++---
 virtManager/connection.py  |  38 +++---
 virtManager/create.py  |   8 +--
 virtManager/createinterface.py |  18 +++
 virtManager/createnet.py   |  20 +++
 virtManager/createpool.py  |  18 +++
 virtManager/createvol.py   |  20 +++
 virtManager/delete.py  |   8 +--
 virtManager/details.py |  30 +--
 virtManager/domain.py  | 116 -
 virtManager/gfxdetails.py  |   2 +-
 virtManager/graphwidgets.py|   8 +--
 virtManager/host.py|  14 ++---
 virtManager/keyring.py |   4 +-
 virtManager/manager.py |   2 +-
 virtManager/migrate.py |  16 +++---
 virtManager/preferences.py |   2 +-
 virtManager/snapshots.py   |   4 +-
 virtManager/storagebrowse.py   |   2 +-
 virtManager/storagelist.py |  12 ++---
 virtinst/capabilities.py   |   2 +-
 virtinst/cli.py|   6 +--
 virtinst/cloner.py |   4 +-
 virtinst/devicechar.py |  22 
 virtinst/devicecontroller.py   |  16 +++---
 virtinst/devicerng.py  |  24 -
 virtinst/devicetpm.py  |   2 +-
 virtinst/diskbackend.py|   4 +-
 virtinst/network.py|   2 +-
 virtinst/osdict.py |  84 ++---
 virtinst/storage.py|   2 +-
 virtinst/urlfetcher.py |   2 +-
 40 files changed, 352 insertions(+), 352 deletions(-)

diff --git a/setup.py b/setup.py
index 6f4b37b..762a056 100755
--- a/setup.py
+++ b/setup.py
@@ -673,8 +673,8 @@ distutils.core.setup(
 'rpm': my_rpm,
 'test': TestCommand,
 'test_ui': TestUI,
-'test_urls' : TestURLFetch,
-'test_initrd_inject' : TestInitrdInject,
+'test_urls': TestURLFetch,
+'test_initrd_inject': TestInitrdInject,
 },
 
 distclass=VMMDistribution,
diff --git a/tests/clitest.py b/tests/clitest.py
index 696ca64..ca2ca1f 100644
--- a/tests/clitest.py
+++ b/tests/clitest.py
@@ -75,43 +75,43 @@ test_files = {
 'URI-KVM-SESSION': utils.uri_kvm_session,
 'URI-KVM-REMOTE': utils.uri_kvm + ",remote",
 'URI-KVM-NODOMCAPS': utils.uri_kvm_nodomcaps,
-'URI-KVM-ARMV7L' : utils.uri_kvm_armv7l,
-'URI-KVM-AARCH64' : utils.uri_kvm_aarch64,
-'URI-KVM-PPC64LE' : utils.uri_kvm_ppc64le,
-'URI-KVM-S390X' : utils.uri_kvm_s390x,
-'URI-KVM-S390X-KVMIBM' : utils.uri_kvm_s390x_KVMIBM,
+'URI-KVM-ARMV7L': utils.uri_kvm_armv7l,
+'URI-KVM-AARCH64': utils.uri_kvm_aarch64,
+'URI-KVM-PPC64LE': utils.uri_kvm_ppc64le,
+'URI-KVM-S390X': utils.uri_kvm_s390x,
+'URI-KVM-S390X-KVMIBM': utils.uri_kvm_s390x_KVMIBM,
 'URI-XEN': utils.uri_xen,
 'URI-LXC': utils.uri_lxc,
 'URI-VZ': utils.uri_vz,
 
-'CLONE_DISK_XML': "%s/clone-disk.xml" % xmldir,
-'CLONE_STORAGE_XML' : "%s/clone-disk-managed.xml" % xmldir,
-'CLONE_NOEXIST_XML' : "%s/clone-disk-noexist.xml" % xmldir,
-'IMAGE_XML' : "%s/image.xml" % xmldir,
-'IMAGE_NOGFX_XML'   : "%s/image-nogfx.xml" % xmldir,
-'OVF_IMG1'   : "%s/tests/virtconv-files/ovf_input/test1.ovf" % 
os.getcwd(),
-'VMX_IMG1'  : "%s/tests/virtconv-files/vmx_input/test1.vmx" % 
os.getcwd(),
-
-'NEWIMG1'   : "/dev/default-pool/new1.img",
-'NEWIMG2'   : "/dev/default-pool/new2.img",
-'NEWCLONEIMG1'  : new_images[0],
-'NEWCLONEIMG2'  : new_images[1],
-'NEWCLONEIMG3'  : new_images[2],
-'AUTOMANAGEIMG' : "/some/new/pool/dir/new",
-'BLOCKVOL'  : '/iscsi-pool/diskvol1',
-'EXISTIMG1' : "/dev/default-pool/testvol1.img",
-'EXISTIMG2' : "/dev/default-pool/testvol2.img",
-'EXISTIMG3' : exist_images[0],
-'EXISTIMG4' : exist_images[1],
-'EXISTUPPER': "/dev/default-pool/UPPER",
-'POOL'  : "default-pool",
-'VOL'   : "testvol1.img",
-'DIR'   : "/var",
-'TREEDIR'   : treedir,
-'MANAGEDNEW1'   : "/dev/default-pool/clonevol",
-'MANAGEDDISKNEW1'   : "/dev/disk-pool/newvol1.img",
-'COLLIDE'   : "/dev/default-pool/collidevol1.img",
-'SHARE' : "/dev/default-pool/sharevol.img",
+'CLONE_DISK_XML': "%s/clone-disk.xml" % xmldir,
+'CLONE_STORAGE_XML':  "%s/clone-disk-managed.xml" % xmldir,
+'CLONE_NOEXIST_XML':