Re: [virt-tools-list] [PATCH 1/4] Add inspection thread.

2011-07-18 Thread Richard W.M. Jones
On Thu, Jul 07, 2011 at 10:37:16AM -0400, Cole Robinson wrote: --- a/src/virtManager/manager.py +++ b/src/virtManager/manager.py @@ -685,6 +685,9 @@ class vmmManager(vmmGObjectUI): self._append_vm(model, vm, connection) +if self.engine.inspection_thread: +

Re: [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

2011-07-18 Thread Daniel P. Berrange
On Sun, Jul 17, 2011 at 08:46:53PM +0100, Richard W.M. Jones wrote: On Thu, Jul 14, 2011 at 10:41:43AM -0400, Whit Blauvelt wrote: Hi, Apologies to those who may receive this twice. I posted this and a couple of followups to libvirt-users last Monday with no response. Since it's a

[virt-tools-list] [PATCH 2/4] Add inspection data to the domain object.

2011-07-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com Create a new (sub-)object vmmInspectionData, and add an instance of this data to each domain object. This data is passed up from from the inspection thread. Also an inspection-changed signal has been added so that UI elements can find out when

[virt-tools-list] [PATCH virt-manager v3] Add inspection to virt-manager

2011-07-18 Thread Richard W.M. Jones
Comments on the previous patches are here: https://www.redhat.com/archives/virt-tools-list/2011-July/thread.html#00016 This updated patch series makes all of the changes outlined in the previous replies, with the exception below. In patch 3/4 (see [1]) I *didn't* combine the inspection-changed

[virt-tools-list] [PATCH 3/4] Display operating system inspection icons in main vmlist.

2011-07-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com --- src/virtManager/manager.py | 43 +-- 1 files changed, 41 insertions(+), 2 deletions(-) diff --git a/src/virtManager/manager.py b/src/virtManager/manager.py index f10879d..f6cd0d9 100644 ---

Re: [virt-tools-list] [PATCH] Fixed the accidental Grid lingering in addnetwork.py.

2011-07-18 Thread Cole Robinson
On 07/15/2011 10:39 AM, Darryl L. Pierce wrote: From: Darryl L. Pierce dpie...@redhat.com --- src/virtManagerTui/addnetwork.py |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) This and the series look fine, though please install python-pep8 and rerun 'make check-pylint' to

Re: [virt-tools-list] [PATCH virt-manager v3] Add inspection to virt-manager

2011-07-18 Thread Cole Robinson
On 07/18/2011 10:18 AM, Richard W.M. Jones wrote: Comments on the previous patches are here: https://www.redhat.com/archives/virt-tools-list/2011-July/thread.html#00016 This updated patch series makes all of the changes outlined in the previous replies, with the exception below. In patch

[virt-tools-list] [PATCH 2/4] Add inspection data to the domain object.

2011-07-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com Create a new (sub-)object vmmInspectionData, and add an instance of this data to each domain object. This data is passed up from from the inspection thread. Also an inspection-changed signal has been added so that UI elements can find out when

[virt-tools-list] [PATCH virt-manager v4] Add inspection to virt-manager

2011-07-18 Thread Richard W.M. Jones
This updates 1/4 with the fixes you suggested. Also, all check-pylint warnings and errors have been fixed. Rich. ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

[virt-tools-list] [PATCH 4/4] Add basic operating system inspection data to the VMM details page.

2011-07-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com This adds hostname, product name, and list of applications. --- src/virtManager/details.py | 61 +++ src/vmm-details.glade | 137 +++- 2 files changed, 196 insertions(+), 2 deletions(-)

[virt-tools-list] [PATCH 3/4] Display operating system inspection icons in main vmlist.

2011-07-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com --- src/virtManager/manager.py | 43 +-- 1 files changed, 41 insertions(+), 2 deletions(-) diff --git a/src/virtManager/manager.py b/src/virtManager/manager.py index f10879d..f6cd0d9 100644 ---

[virt-tools-list] [PATCH 1/4] Add inspection thread.

2011-07-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com This commit adds an inspection daemon thread which performs libguestfs inspection on domains when they first appear in the manager UI. python-guestfs is not required. --- src/virtManager/config.py | 31 ++ src/virtManager/engine.py | 17

Re: [virt-tools-list] [PATCH virt-manager v4] Add inspection to virt-manager

2011-07-18 Thread Cole Robinson
On 07/18/2011 02:53 PM, Richard W.M. Jones wrote: This updates 1/4 with the fixes you suggested. Also, all check-pylint warnings and errors have been fixed. Rich. Thanks! Pushed the series. - Cole ___ virt-tools-list mailing list

Re: [virt-tools-list] [PATCH virt-manager v4] Add inspection to virt-manager

2011-07-18 Thread Richard W.M. Jones
On Mon, Jul 18, 2011 at 05:41:00PM -0400, Cole Robinson wrote: On 07/18/2011 02:53 PM, Richard W.M. Jones wrote: This updates 1/4 with the fixes you suggested. Also, all check-pylint warnings and errors have been fixed. Rich. Thanks! Pushed the series. Thanks. I've updated this