Re: [virt-tools-list] [PATCH] virt-manager: Modified some features for s390x

2015-10-29 Thread Cole Robinson
On 10/28/2015 11:06 PM, Kevin Zhao wrote: > Hi Cole, > Thanks for your advices. I will modify the code and submit the patch > later. > For your comment, as I know, in KVMIBM Distro,s390-ccw-kvmibm-1.1.1 is > the alias name of s390-ccw-virtioo, so they are the same. :-) > If

[virt-tools-list] [PATCH 1/5] Call intltoolize after autoreconf

2015-10-29 Thread Eduardo Lima (Etrunko)
After a calling 'git clean -d -x -f' I got this error: ln: failed to create symbolic link ‘m4/intltool.m4’: No such file or directory cp: cannot create regular file ‘m4/intltool.m4’: No such file or directory intltoolize: cannot copy '/usr/share/aclocal/intltool.m4' to 'm4/intltool.m4' With this

[virt-tools-list] Some cosmetic fixes

2015-10-29 Thread Eduardo Lima (Etrunko)
While working on adding support to GtkApplication for virt-viewer and remote-viewer, I fixed some small things. I figured it was time to flush them to avoid those to pile up. Regards, Eduardo -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com

[virt-tools-list] [PATCH 5/5] Remove useless {get, set}_property functions

2015-10-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/virt-viewer.c b/src/virt-viewer.c index dd8dbba..10f624d 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -74,26 +74,6 @@ static

[virt-tools-list] [PATCH 2/5] Fix MAINTAINERCLEANFILES variable

2015-10-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- man/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/Makefile.am b/man/Makefile.am index 6ee3116..39b6019 100644 --- a/man/Makefile.am +++ b/man/Makefile.am @@ -10,7 +10,7 @@ EXTRA_DIST =

[virt-tools-list] [PATCH 4/5] Move declaration to the beginning of the file

2015-10-29 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/virt-viewer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/virt-viewer.c b/src/virt-viewer.c index ca264c8..dd8dbba 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -71,6 +71,7 @@ static