Re: [virt-tools-list] [PATCH 2/2] Fix spice includes

On 11/11/2015 05:11 AM, Pavel Grunt wrote: > Hi Eduardo, > > these warnings were introduced after spice-gtk v0.30 release, virt-viewer > currently depends on spice-gtk v0.29.35. You can make the code conditional or > wait for the spice-gtk v0.31 release. > Alright, I guess it is better to wait

Re: [virt-tools-list] [PATCH 1/2] Remove unused 'window-removed' signal

Ok, ack. Pavel On Tue, 2015-11-10 at 18:39 -0200, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/virt-viewer-app.c | 14 -- >  src/virt-viewer-app.h |  1 - >  2 files changed, 15 deletions(-) > > diff --git

Re: [virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

On Tue, Nov 10, 2015 at 04:20:51PM -0500, Cole Robinson wrote: > On 11/09/2015 02:02 PM, Pavel Hrdina wrote: > > Kernel for ppc64 automatically enables serial console, there is no need > > to report any warning. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1247434 > > > >

Re: [virt-tools-list] [virt-manager v2] details: show Channel label by device type

On 11/11/2015 07:26 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Currently we show channel label by its name. > If we use name com.redhat.spice.0 but set it > as unix socket, the label in details keep unchanged. > > This patch will set label according to device type >

Re: [virt-tools-list] [virt-manager PATCH] virt-install: refresh storage pool after disk is created

On Tue, Nov 10, 2015 at 04:51:25PM -0500, Cole Robinson wrote: > On 11/10/2015 08:19 AM, Pavel Hrdina wrote: > > This fixes an issue where you need to manually refresh storage pool or > > restart virt-manager in order to be able delete guest that is currently > > installed. This affect remote

Re: [virt-tools-list] [virt-manager PATCH] ui: improve pause/resume tooltip

On Tue, Nov 10, 2015 at 04:23:35PM -0500, Cole Robinson wrote: > On 11/09/2015 02:06 PM, Pavel Hrdina wrote: > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1238618 > > > > Signed-off-by: Pavel Hrdina > > --- > > ui/details.ui | 2 +- > > ui/manager.ui | 2 +- > >

[virt-tools-list] [virt-manager v2] details: show Channel label by device type

From: Chen Hanxiao Currently we show channel label by its name. If we use name com.redhat.spice.0 but set it as unix socket, the label in details keep unchanged. This patch will set label according to device type if we failed matching target_name Signed-off-by: Chen

Re: [virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

On 11/11/2015 08:17 AM, Pavel Hrdina wrote: > On Tue, Nov 10, 2015 at 04:20:51PM -0500, Cole Robinson wrote: >> On 11/09/2015 02:02 PM, Pavel Hrdina wrote: >>> Kernel for ppc64 automatically enables serial console, there is no need >>> to report any warning. >>> >>> Resolves:

Re: [virt-tools-list] [virt-manager PATCH 1/2] virt-install: warn user about missing console while installing on arm

On 11/11/2015 03:32 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > > Pushed as trivial. > > virt-install | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/virt-install b/virt-install > index 3656835..e465c46 100755 > ---

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

On Wed, Nov 11, 2015 at 03:50:30PM -0500, Cole Robinson wrote: > On 11/11/2015 03:32 PM, Pavel Hrdina wrote: > > Function get_devices() always returns a list, if there is no requested > > device the list is empty. > > > > Signed-off-by: Pavel Hrdina > > --- > > > > Pushed as

Re: [virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

On Wed, Nov 11, 2015 at 02:58:16PM -0500, Cole Robinson wrote: > On 11/11/2015 08:17 AM, Pavel Hrdina wrote: > > On Tue, Nov 10, 2015 at 04:20:51PM -0500, Cole Robinson wrote: > >> On 11/09/2015 02:02 PM, Pavel Hrdina wrote: > >>> Kernel for ppc64 automatically enables serial console, there is no

[virt-tools-list] [virt-manager PATCH 0/2] some minor virt-install fixes

Pavel Hrdina (2): virt-install: warn user about missing console while installing on arm virt-install: fix condition that detect if console is present virt-install | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.6.3 ___

[virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

Function get_devices() always returns a list, if there is no requested device the list is empty. Signed-off-by: Pavel Hrdina --- Pushed as trivial. virt-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt-install b/virt-install index

[virt-tools-list] [virt-manager PATCH 1/2] virt-install: warn user about missing console while installing on arm

Signed-off-by: Pavel Hrdina --- Pushed as trivial. virt-install | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/virt-install b/virt-install index 3656835..e465c46 100755 --- a/virt-install +++ b/virt-install @@ -488,10 +488,6 @@ def

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

On 11/11/2015 03:32 PM, Pavel Hrdina wrote: > Function get_devices() always returns a list, if there is no requested > device the list is empty. > > Signed-off-by: Pavel Hrdina > --- > > Pushed as trivial. > > virt-install | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

On 11/11/2015 04:01 PM, Pavel Hrdina wrote: > On Wed, Nov 11, 2015 at 03:50:30PM -0500, Cole Robinson wrote: >> On 11/11/2015 03:32 PM, Pavel Hrdina wrote: >>> Function get_devices() always returns a list, if there is no requested >>> device the list is empty. >>> >>> Signed-off-by: Pavel Hrdina