Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote: > This is not actually necessary as of C99. You only need to initialize > any field of a structure to get all other fields initialized too. yes, I was just annoyed by the warning.. > > On 06/22/2016 03:17 AM, Pavel Grunt wrote: >

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

This is not actually necessary as of C99. You only need to initialize any field of a structure to get all other fields initialized too. On 06/22/2016 03:17 AM, Pavel Grunt wrote: > --- > src/virt-viewer-display-spice.c | 2 +- > src/virt-viewer-display-vnc.c | 2 +- > src/virt-viewer-window.c

[virt-tools-list] [virt-viewer] mingw,spec: Bump msitools version

Fedora 24 has GLib 2.48.0, which brings a new dependency: PCRE. The new dependency is already added to the wxi file (in msitools) and a new msitools build including the fix is already done [0]. Let's just bump the version in our spec file and make sure we will be using the msitools which includes

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On Wed, Jun 22, 2016 at 8:17 AM, Pavel Grunt wrote: > --- > src/virt-viewer-display-spice.c | 2 +- > src/virt-viewer-display-vnc.c | 2 +- > src/virt-viewer-window.c| 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On Wed, 2016-06-22 at 10:59 +0200, Fabiano Fidêncio wrote: > On Wed, Jun 22, 2016 at 8:17 AM, Pavel Grunt wrote: > > --- > >  src/virt-viewer-display-spice.c | 2 +- > >  src/virt-viewer-display-vnc.c   | 2 +- > >  src/virt-viewer-window.c| 2 +- > >  3 files changed, 3

Re: [virt-tools-list] [PATCH virt-viewer 3/4] window: Use loop instead of multiple ifs

On Wed, Jun 22, 2016 at 8:17 AM, Pavel Grunt wrote: > Binds modifier's mask and key, also fixes a compile time warning: > warning: cast from 'gchar *' (aka 'char *') to 'guint *' (aka 'unsigned > int *') increases required alignment from 1 to 4 [-Wcast-align] > return

Re: [virt-tools-list] [PATCH virt-viewer 2/4] window: Move definition from header

On Wed, Jun 22, 2016 at 8:17 AM, Pavel Grunt wrote: > --- > src/virt-viewer-window.c | 2 ++ > src/virt-viewer-window.h | 1 - > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c > index e03df65..60a1675 100644

Re: [virt-tools-list] [PATCH virt-viewer 1/4] window: Do not use constant

I'd prefer a commit message as: "window: Use a predefined macro instead of constant", but that's not a big deal. On Wed, Jun 22, 2016 at 8:17 AM, Pavel Grunt wrote: > --- > src/virt-viewer-window.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

--- src/virt-viewer-display-spice.c | 2 +- src/virt-viewer-display-vnc.c | 2 +- src/virt-viewer-window.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/virt-viewer-display-spice.c b/src/virt-viewer-display-spice.c index ee07507..a604230 100644 ---

[virt-tools-list] [PATCH virt-viewer 3/4] window: Use loop instead of multiple ifs

Binds modifier's mask and key, also fixes a compile time warning: warning: cast from 'gchar *' (aka 'char *') to 'guint *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align] return (guint*)g_array_free(a, FALSE); --- src/virt-viewer-window.c | 39

[virt-tools-list] [PATCH virt-viewer 2/4] window: Move definition from header

--- src/virt-viewer-window.c | 2 ++ src/virt-viewer-window.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index e03df65..60a1675 100644 --- a/src/virt-viewer-window.c +++ b/src/virt-viewer-window.c @@ -43,6 +43,8 @@

[virt-tools-list] [PATCH virt-viewer 1/4] window: Do not use constant

--- src/virt-viewer-window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index 8ec2521..e03df65 100644 --- a/src/virt-viewer-window.c +++ b/src/virt-viewer-window.c @@ -378,7 +378,7 @@