Re: [virt-tools-list] [PATCH virt-viewer v2 0/2] Changes to ovirt-foreign menu

On Thu, Jun 23, 2016 at 7:15 PM, Eduardo Lima (Etrunko) wrote: > In this version: > - Rebase to latest master > - Better commit messages > - Additional debug message if returning NULL in patch 2 > > Eduardo Lima (Etrunko) (2): > Get ovirt foreign menu item from UI file >

[virt-tools-list] [PATCH virt-viewer v2 1/2] Get ovirt foreign menu item from UI file

Currently the menu item is created manually, while this patch changes it to be retrieved from the UI file, and decides if it needs to be shown or hidden if the ISO list is received from ovirt. This a preparation for a upcoming UI change that will present the ISO list in a separate dialog, instead

[virt-tools-list] [PATCH virt-viewer v2 2/2] Use more accurate debug messages for foreign menu

Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 9b552eb..2d286fb 100644 --- a/src/ovirt-foreign-menu.c +++

[virt-tools-list] [PATCH virt-viewer v2 0/2] Changes to ovirt-foreign menu

In this version: - Rebase to latest master - Better commit messages - Additional debug message if returning NULL in patch 2 Eduardo Lima (Etrunko) (2): Get ovirt foreign menu item from UI file Use more accurate debug messages for foreign menu src/ovirt-foreign-menu.c| 3 ++-

Re: [virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

On 06/23/2016 01:35 PM, Christophe Fergeau wrote: > This looks fine to me, however I'd rephrase the shortlog (or add to the > long log) that we get the Change CD menu from the UI file rather than > manually creating it. Before looking at the commit, I was not sure what > this was about. Okay

Re: [virt-tools-list] [PATCH 2/2] Avoid unecessary debug message if returning NULL

On 06/23/2016 01:36 PM, Christophe Fergeau wrote: > On Thu, Jun 23, 2016 at 10:13:25AM -0300, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> src/ovirt-foreign-menu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: [virt-tools-list] [PATCH 2/2] package: Add appdata metadata for Gnome Software

On Thu, Jun 23, 2016 at 4:53 PM, Lukáš Venhoda wrote: > Adds metadata to be used with Gnome Software. > Includes name, summary, description and three screenshots of remote-viewer. > Adds the new file to PO files, and adds instalation of appdata file. I'd remove this last

Re: [virt-tools-list] [PATCH 2/2] Avoid unecessary debug message if returning NULL

On Thu, Jun 23, 2016 at 10:13:25AM -0300, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > src/ovirt-foreign-menu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c >

Re: [virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

This looks fine to me, however I'd rephrase the shortlog (or add to the long log) that we get the Change CD menu from the UI file rather than manually creating it. Before looking at the commit, I was not sure what this was about. Christophe On Thu, Jun 23, 2016 at 11:23:11AM -0300, Eduardo Lima

Re: [virt-tools-list] [PATCH 1/2] package: Add Provides remote-viewer

Hey! On Thu, Jun 23, 2016 at 4:53 PM, Lukáš Venhoda wrote: > Enables usage of dnf install remote-viewer and dnf remove remote-viewer > for the virt-viewer package > --- > virt-viewer.spec.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/virt-viewer.spec.in

Re: [virt-tools-list] [PATCH 1/2] package: Add Provides remote-viewer

Hi Lukas, I tested it and it works nicely, On Thu, 2016-06-23 at 16:53 +0200, Lukáš Venhoda wrote: > Enables usage of dnf install remote-viewer and dnf remove remote-viewer > for the virt-viewer package Acked-by: Pavel Grunt Thanks, Pavel > --- >  virt-viewer.spec.in | 2 ++

Re: [virt-tools-list] [virt-viewer] mingw, spec: Bump msitools version

On 06/22/2016 07:59 AM, Fabiano Fidêncio wrote: > Fedora 24 has GLib 2.48.0, which brings a new dependency: PCRE. > The new dependency is already added to the wxi file (in msitools) and a > new msitools build including the fix is already done [0]. > > Let's just bump the version in our spec file

[virt-tools-list] [PATCH 1/2] package: Add Provides remote-viewer

Enables usage of dnf install remote-viewer and dnf remove remote-viewer for the virt-viewer package --- virt-viewer.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virt-viewer.spec.in b/virt-viewer.spec.in index f3661d2..ed0b14d 100644 --- a/virt-viewer.spec.in +++

[virt-tools-list] [PATCH 2/2] package: Add appdata metadata for Gnome Software

Adds metadata to be used with Gnome Software. Includes name, summary, description and three screenshots of remote-viewer. Adds the new file to PO files, and adds instalation of appdata file. --- data/Makefile.am | 9 +++-- data/remote-viewer.appdata.xml.in | 28

[virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

This patch is a preparation for a upcoming UI change that will present the ISO list in a separate dialog, instead of a submenu. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 23 +++ src/resources/ui/virt-viewer.ui | 8

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On 06/23/2016 10:26 AM, Pavel Grunt wrote: > On Thu, 2016-06-23 at 10:15 -0300, Eduardo Lima (Etrunko) wrote: >> On 06/22/2016 05:16 PM, Pavel Grunt wrote: >>> On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote: This is not actually necessary as of C99. You only need to

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On Thu, 2016-06-23 at 10:15 -0300, Eduardo Lima (Etrunko) wrote: > On 06/22/2016 05:16 PM, Pavel Grunt wrote: > > On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote: > > > This is not actually necessary as of C99. You only need to initialize > > > any field of a structure to get all

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On 06/22/2016 05:16 PM, Pavel Grunt wrote: > On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote: >> This is not actually necessary as of C99. You only need to initialize >> any field of a structure to get all other fields initialized too. > > yes, I was just annoyed by the warning..

[virt-tools-list] [PATCH 2/2] Avoid unecessary debug message if returning NULL

Signed-off-by: Eduardo Lima (Etrunko) --- src/ovirt-foreign-menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 9b552eb..959804d 100644 --- a/src/ovirt-foreign-menu.c +++

[virt-tools-list] [PATCH 1/2] Avoid creating ovirt foreign menu item manually

This patch is a preparation for a upcoming UI change that will present the ISO list in a separate dialog, instead of a submenu. Signed-off-by: Eduardo Lima (Etrunko) --- src/remote-viewer.c | 26 -- src/resources/ui/virt-viewer.ui | 8