Re: [virt-tools-list] [PATCH] virtinst: add KVM feature kvm_hint_dedicated

On 8/13/19 2:57 AM, Menno Lageman wrote: > QEMU version 2.12.1 introduced a performance feature under commit > be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint"). > Support for this performance hint was added in libvirt 5.7.0 by commit > cb12c59dac04 ("qemu: support for

Re: [virt-tools-list] [virt-manager PATCH v2] cloudinit: Move random password printing and sleeping to virt-install

On 8/14/19 5:16 AM, athina.plaskasov...@gmail.com wrote: > From: Athina Plaskasoviti > > Fixed: > - Added a do_log flag to print_stdout(), to avoid logging of printed random > password. > - Excluded timeout in virt-install from testing > > Signed-off-by: Athina Plaskasoviti Thanks, pushed to

Re: [virt-tools-list] [PATCH] virtinst: add KVM feature kvm_hint_dedicated

On 8/13/19 2:57 AM, Menno Lageman wrote: > QEMU version 2.12.1 introduced a performance feature under commit > be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint"). > Support for this performance hint was added in libvirt 5.7.0 by commit > cb12c59dac04 ("qemu: support for

Re: [virt-tools-list] [virt-manager PATCH] cloudinit: Scrub password from logs

On 7/28/19 4:40 AM, athina.plaskasov...@gmail.com wrote: > From: Athina Plaskasoviti > > Signed-off-by: Athina Plaskasoviti > --- > virtinst/install/cloudinit.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/virtinst/install/cloudinit.py

Re: [virt-tools-list] [virt-install PATCH] cloudinit: Fix password expiration

On 7/28/19 5:01 AM, athina.plaskasov...@gmail.com wrote: > From: Athina Plaskasoviti > > Password expiration happens in case of one time random password generation. > When user provides password from file, don't expire the password. > Yes this seems like the correct thing to do. I've pushed

Re: [virt-tools-list] [virt-manager PATCH] cloudinit: Add ssh-key=/path/to/key cli option

On 7/25/19 5:07 AM, athina.plaskasov...@gmail.com wrote: > From: AthinaPl > > Login to VM with: > ssh root@vm_ip_address > > Signed-off-by: AthinaPl > --- > tests/cli-test-xml/ssh-key.txt | 1 + > tests/clitest.py | 2 ++ > virtinst/cli.py| 1 + >

Re: [virt-tools-list] [virt-manager PATCH] cloudinit: Add root-password-generate=yes|no instead of root-password=xxxx

On 7/16/19 9:00 AM, Fabiano Fidêncio wrote: > On Tue, Jul 16, 2019 at 2:46 PM Athina Plaskasoviti > wrote: >> >> Now --cloud-init defaults to root-password-generate=yes,disable=yes. >> Option for plaintext password given through the cli is completely removed. >> >> Signed-off-by: Athina

Re: [virt-tools-list] [virt-manager PATCH 0/9] Use generate_*_for_tree

+++ > virtinst/install/urldetect.py | 10 +- > virtinst/osdict.py | 23 +++ > 5 files changed, 59 insertions(+), 12 deletions(-) > Reviewed-by: Cole Robinson And pushed Thanks, Cole ___

Re: [virt-tools-list] Problem with version 5.5.x

On 7/21/19 6:58 PM, Raghav Gururajan wrote: > Hello Folks! > > The distro I use (Guix System) has updated it's virt-manager version > from > 5.4.x to 5.5.x, few days ago. > > After the update, there is this following error: > "libvirt.libvirtError: Unable to read from >

Re: [virt-tools-list] [virt-manager PATCH][RFC] cloudinit: Move random password printing and sleeping to virt-install

On 7/22/19 6:34 AM, Athina Plaskasoviti wrote: > Added a 10 second delay when printing random password for first login, > which can be bypassed when pressing Enter. > > Signed-off-by: Athina Plaskasoviti > --- > virt-install | 10 ++ > virtinst/install/installer.py | 5

Re: [virt-tools-list] [virt-manager PATCH] cli: Add --keywrap cipher[0-9]*.name=aes|des, cipher[0-9]*.state=on|off

ed, 56 insertions(+), 1 deletion(-) > create mode 100644 virtinst/domain/keywrap.py > Reviewed-by: Cole Robinson And pushed now Thanks, Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-manager PATCH] cloudinit: Add cli option root-password-file=/path/to/file.txt

On 7/15/19 9:33 AM, Athina Plaskasoviti wrote: > Signed-off-by: Athina Plaskasoviti > --- > tests/cli-test-xml/root-password.txt | 1 + > tests/clitest.py | 4 +++- > virtinst/cli.py | 1 + > virtinst/install/cloudinit.py| 7 +++ > 4 files

Re: [virt-tools-list] [virt-manager PATCH v2] cloudinit: Move password generation inside class CloudInitData

On 7/14/19 10:07 AM, Athina Plaskasoviti wrote: > Function generate_password() provides random 16 digit password and > get_root_password() handling root_password assignment. > > Signed-off-by: Athina Plaskasoviti > --- > virtinst/install/cloudinit.py | 22 ++ > 1 file

Re: [virt-tools-list] [virt-manager PATCH] cli: Add --clock timer[0-9]*.track, timer[0-9]*.mode, timer[0-9]*.frequency options

On 7/14/19 7:49 AM, Athina Plaskasoviti wrote: > XML Mapping: > > > ... > > ... > > > Signed-off-by: Athina Plaskasoviti Thanks, pushed now - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com

Re: [virt-tools-list] [virt-manager PATCH] virt-install: Use minutes instead of seconds on get_time_string()

timestr = _(" %d minutes") % self._wait_mins > if self._wait_forever: > timestr = "" > ret = _("Waiting%(time_string)s for installation to complete.") % { > Oops Reviewed-by: Cole Robinson And pushed - Cole ___

Re: [virt-tools-list] [virt-manager PATCH] cli: Add --blkiotune device[0-9]*.read_bytes_sec/write_bytes_sec/read_iops_sec/write_iops_sec options

On 7/25/19 6:15 AM, athina.plaskasov...@gmail.com wrote: > From: AthinaPl > > XML Mapping: > > > > ... > X > X > X > X > ... > > > Reviewed-by: Cole Robinson But your From: line is different, I fixed that before

Re: [virt-tools-list] Saved VM state not part of snapshot?

On 11/14/19 10:11 AM, Michael Weiser wrote: > Hello Cole, > > thanks for getting back to me. > > On Tue, Nov 12, 2019 at 12:08:20PM -0500, Cole Robinson wrote: > >>> - create a snapshot of this suspended state including disk and memory >> Since the VM

Re: [virt-tools-list] Guest time sync on snapshot resume

On 11/14/19 10:30 AM, Michael Weiser wrote: > Hello, > > I expect this pops up every couple of months and apologise if indeed it > does. But I couldn't find a discussion specific to virt-manager and so > it goes: > > When working with snapshots, guests will have outdated date and time > upon

Re: [virt-tools-list] [PATCH 1/1] connection: Avoid repeated default pool creation attempts

On 10/25/19 3:27 PM, Michael Weiser wrote: > During startup virtinst.StoragePool.build_default_pool() tries to > determine whether the default storage pool already exists. Because > events have not yet been processed, the list of existing storage pools > is still empty. Therefore it seems as if it

Re: [virt-tools-list] Saved VM state not part of snapshot?

On 10/25/19 2:28 PM, Michael Weiser wrote: > Hello, > > as an end user I today realized and was quite surprised that the saved > VM state of qemu/KVM VMs in virt-manager/libvirt does not seem to be > part of internal qcow2 snapshots. Is that understanding correct? > > The libvirt Wiki says as

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

On 11/21/19 9:51 PM, Dusty Mabe wrote: > > > On 11/21/19 5:34 AM, Daniel P. Berrangé wrote: >> On Wed, Nov 20, 2019 at 08:18:01PM -0500, Dusty Mabe wrote: >>> >>> >>> On 11/20/19 5:49 PM, Cole Robinson wrote: > >>>> * Any other ideas, t

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

On 11/22/19 5:12 AM, Daniel P. Berrangé wrote: > On Thu, Nov 21, 2019 at 07:44:38PM -0500, Cole Robinson wrote: >> On 11/21/19 5:28 AM, Daniel P. Berrangé wrote: >>> One option is to take the lazy approach and always enable cloud init >>> if we are g

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

Thanks for the feedback Dusty! I think Dan's response covered the tricky bit, I'll cover some response about ssh keys elsewhere in the thread. One bit here though: On 11/20/19 8:18 PM, Dusty Mabe wrote: > > > On 11/20/19 5:49 PM, Cole Robinson wrote: >> Hi all. The purpo

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

On 11/21/19 10:49 AM, Ryan Harper wrote: > * Cole Robinson [2019-11-20 17:48]: >> Hi all. The purpose of this mail is to get some feedback on pending >> cloud-init support in virt-install. If you're on the CC list here, I >> either pulled your email from a cloud-init discussi

Re: [virt-tools-list] virt-install and cloud-init, feedback wanted

On 11/21/19 5:28 AM, Daniel P. Berrangé wrote: > On Wed, Nov 20, 2019 at 05:49:45PM -0500, Cole Robinson wrote: >> Hi all. The purpose of this mail is to get some feedback on pending >> cloud-init support in virt-install. If you're on the CC list here, I >> either pulled yo

Re: [virt-tools-list] virt-manager test suite hangs on FreeBSD

On 12/12/19 5:17 AM, Daniel P. Berrangé wrote: > On Thu, Dec 12, 2019 at 09:47:42AM +0100, Andrea Bolognani wrote: >> On Wed, 2019-12-11 at 18:01 -0500, Cole Robinson wrote: >>> On 12/11/19 7:40 AM, Andrea Bolognani wrote: >>>> On Wed, 2019-12-11 at 07:28 -0500, Cole

Re: [virt-tools-list] [virt-manager][PATCH] domcapabilities: Whitelist upstream qemu edk2 paths

On 12/14/19 6:48 AM, Michal Privoznik wrote: > Upstream qemu installs > /usr/share/qemu/edk2-$ARCH-(?secure-)code.fd FW images. Whitelist > them too. > > Signed-off-by: Michal Privoznik Reviewed-by: Cole Robinson And pushed - Cole ___

Re: [virt-tools-list] [RFC PATCH v3 0/7] Guest time sync on snapshot resume

On 12/9/19 4:53 PM, Michael Weiser wrote: > Hello Cole, > > this is the third iteration of implementing guest time sync as per > your suggestions. The only change compared to v2 is in the way the last > patch blocks the toggled signal. > > These patches do: > * add method _set_time() calling the

Re: [virt-tools-list] virt-manager test suite hangs on FreeBSD

On 12/11/19 5:22 AM, Andrea Bolognani wrote: > In the libvirt-jenkins-ci repo, which contains the configuration for > the CI environment used by libvirt and related project, in the > virt-manager specific configuration we've had this comment for a > while: > > # libxml2's Python 3 bindings

Re: [virt-tools-list] virt-manager test suite hangs on FreeBSD

On 12/11/19 7:40 AM, Andrea Bolognani wrote: > On Wed, 2019-12-11 at 07:28 -0500, Cole Robinson wrote: >> On 12/11/19 5:22 AM, Andrea Bolognani wrote: >>> I have no idea how to debug this thing. Can an actual virt-manager >>> developer jump in? I'll gladly provid

Re: [virt-tools-list] [virt-manager PATCH v2] controller: don't set default controller index

root-port \ > $VM > > Signed-off-by: Pavel Hrdina Reviewed-by: Cole Robinson - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] Checking on plans for cloud-init

On 10/23/19 9:21 AM, Christian Ehrhardt wrote: > Hi, > I was seeing activity on cloud-init for virtinst ending up in a > 'cloudinit' branch that still is in the project [1]. I know that this > was due to a GSOC [2] project and wanted to thank all of you for that. > But according to [3] I'd guess

Re: [virt-tools-list] Saved VM state not part of snapshot?

On 11/19/19 11:15 AM, Michael Weiser wrote: > Hello Cole, > > On Thu, Nov 14, 2019 at 10:43:58AM -0500, Cole Robinson wrote: >>> Instead of handling the symptoms, might it be easier to try and make the >>> saved memory state become part of the snapshot then? I could th

[virt-tools-list] virt-install and cloud-init, feedback wanted

Hi all. The purpose of this mail is to get some feedback on pending cloud-init support in virt-install. If you're on the CC list here, I either pulled your email from a cloud-init discussion on the the virt-tools-list mailing list, or from the CC list of this virt-install bug: RFE: Provide

Re: [virt-tools-list] virt-manager 2.2.1 does nothing when I click “New Virtual Machine”

On 10/10/19 2:39 PM, Michael wrote: Hi All, Newbie with virt-manager, 20+ yrs w/ Linux. I tried the Debian 9 (stretch) default install (virt-manager 1.4.0-5), but it wasn’t working [“python 3.4 or later is required, your's is sys.version_info(major=2, minor=7, micro=13, releaselevel='final',

Re: ERROR Could not find an installable distribution at ....

On 2/13/20 12:18 PM, Kaushal Shriyan wrote: > Hi, > > I am trying to set up alpine Linux Guest OS using the below command > > #virt-install --name=mfecdrupalalphine > --file=/linuxkvmguestosdisk/var/lib/libvirt/images/mfecdrupalalphine.img > --file-size=100 --nonsparse --vcpus=2 --ram=6096

Re: ERROR Could not find an installable distribution at ....

On 2/13/20 2:24 PM, Kaushal Shriyan wrote: > > > On Thu, Feb 13, 2020 at 11:01 PM Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 2/13/20 12:18 PM, Kaushal Shriyan wrote: > > Hi, > > > > I am trying to set up alp

Re: [virt-tools-list] [virt-manager PATCH v2] details: Fix showing the firmware type in case of firmware auto selection

gt; +firmware = 'UEFI' > +else: > +firmware = domcaps.label_for_firmware_path( > +self.vm.get_xmlobj().os.loader) > if self.widget("overview-firmware").is_visible(): > uiutil.set_list_selection( >

Re: [virt-tools-list] [virt-manager PATCH] Install the AppStream file to the canonical location

cano Reviewed-by: Cole Robinson and pushed Thanks, Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-manager PATCH] Avoid string puzzle

no Toscano Reviewed-by: Cole Robinson and pushed Thanks, Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH] virtManager: Folder sharing implementation for SPICE session

On 12/28/19 7:12 AM, Jitao Lu wrote: > * This implements folder sharing for the built-in Spice client, tested >working with Win10 guest. > * The basic idea is taken from virt-viewer. > > Signed-off-by: Jitao Lu > --- > Feel free to improve the patch! > Nice work! This looks pretty good.

Re: [virt-tools-list] [virt-manager RFC PATCH 0/2] Warn about saved state behaviour with snapshots

On 12/19/19 4:52 PM, Michael Weiser wrote: > Hello Cole, > > I've done a bit of work on the issue of saved memory state not becoming > part of snapshots: > > On 10/25/19 2:28 PM, Michael Weiser wrote: > >> * Run/Revert of a snapshot should be rejected if the VM is in the >> 'Saved' state, aka

Re: [virt-tools-list] [virt-manager PATCH 2/2] virtManager: object: domain: Async set guest time

timeout > to 30 seconds. > I pushed patch one. Some comments here > Signed-off-by: Michael Weiser > Suggested-by: Cole Robinson > --- > virtManager/object/domain.py | 49 > 1 file changed, 38 insertions(+), 11 deletions(-) > &g

Re: [virt-tools-list] Need virt-install to boot Ubuntu netboot initrd

On 12/23/19 12:07 PM, Orion Poplawski wrote: > I'm trying to use koan with cobbler to install a Ubuntu 16.04 VM. koan > invokes virt-install with: > > 'virt-install', '--connect', 'qemu:///system', '--name', 'vmub16', '--ram', > '2000', '--vcpus', '1', '--graphics', 'spice', '--virt-type',

Re: [virt-tools-list] [virt-manager RFC PATCH 2/2] details: snapshots: Warn of saved state on creation

On 12/19/19 4:52 PM, Michael Weiser wrote: > Add a confirmation dialog when creating a new snapshot if there is saved > memory state so the user is aware that memory state will not be part of > the snapshot. > > Signed-off-by: Michael Weiser > Suggested-by: Cole Robinson &g

Re: [PATCH virt-manager] rng: add builtin rng backend model

On 4/19/20 9:39 AM, Han Han wrote: > The builtin rng backend uses getrandom syscall to generate random, no > external rng source needed, introduced from libvirt v6.1.0. > Thanks, pushed now - Cole

Re: Adding an "Enable Launch Security" checkbox to the Memory Details dialog

CCing Erik who knows more about that launchSecurity/sev than I do On 3/27/20 11:44 AM, Charles Arnold wrote: > What is the opinion of adding a checkbox called "Enable Launch > Security" under the 'Current allocation' and 'Maximum allocation' boxes > on the Details->Memory dialog? It would only be

Re: [virt-manager PATCH] disk: Support disk io mode io_uring

On 4/26/20 11:55 PM, Han Han wrote: > Support the io_uring io mode, introduced since Libvirt v6.3.0. > > Signed-off-by: Han Han > --- > man/virt-install.pod | 2 +- > virtinst/devices/disk.py | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man/virt-install.pod

Re: Black Screen with Spice and OpenGL acceleration in virt-manager with QEMU/KVM

orks even like that but I can use it only > blindly through the keyboard, because the screen is just black. > > > Dňa st 6. 5. 2020, 20:14 Cole Robinson <mailto:crobi...@redhat.com>> napísal(a): > > On 5/1/20 7:28 AM, Filip Banák wrote: > &g

ANNOUNCE: virt-manager 3.0.0 released

Plaskasoviti, Cole Robinson) - The virt-convert tool has been removed. Please use virt-v2v instead - A handful of UI XML configuration options have been removed. The XML editor can be used instead. For a larger discussion see this thread: https://www.redhat.com/archives/virt-tools-list/2019-June

Re: [virt-manager PATCH 0/3] Improve Mageia tree detection

On 8/26/20 6:44 AM, Pino Toscano wrote: > Detect the version, and slightly improve the tests for it. > > Pino Toscano (3): > tests: tweak mageia detection > urldetect: add version detection for Mageia > tests: add Mageia 5 detection test > > tests/data/urldetect/mageia/5/VERSION |

Re: [virt-manager PATCH] osdict: extend non-EOL distros range to 10 years

On 8/18/20 12:47 PM, Pino Toscano wrote: > Commit d52d9885c85623b8d924dbf0aceecb08b33e9122 added a logic to > consider as EOL a distribution with no EOL date set and release date > earlier than 5 years from the current day. This was done because there > were (and still are, even if fewer now) many

Re: virt-install: changing default --os-variant behavior

On 9/21/20 4:01 PM, Charles Arnold wrote: > On Sun, 2020-09-20 at 16:09 -0400, Cole Robinson wrote: >> Hi virt-tools-list + CCd libosinfo developers too >> >> Use of virt-install without a detected guest OS, and without manually >> specified --os-variant, is a never end

Re: virt-install: changing default --os-variant behavior

On 9/22/20 11:53 AM, Pino Toscano wrote: > On Sunday, 20 September 2020 22:09:54 CEST Cole Robinson wrote: >> Use of virt-install without a detected guest OS, and without manually >> specified --os-variant, is a never ending source of bugs and user >> confusion and poorly

Re: virt-install: changing default --os-variant behavior

On 9/20/20 4:46 PM, Peter Crowther wrote: > On Sun, 20 Sep 2020 at 21:10, Cole Robinson <mailto:crobi...@redhat.com>> wrote: > [...] > > 2) Default to --os-variant detect=on,name=. 'give me > virtio' is representative of what most virt-install users want. But

Re: virt-install: changing default --os-variant behavior

On 9/22/20 11:59 AM, Peter Crowther wrote: > On Tue, 22 Sep 2020 at 16:48, Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 9/20/20 4:46 PM, Peter Crowther wrote: > > On Sun, 20 Sep 2020 at 21:10, Cole Robinson <mailto:crobi...@redhat

Re: [virt-manager PATCH 8/9] i18n: use a single string for error message

On 9/17/20 2:44 AM, Pino Toscano wrote: > Signed-off-by: Pino Toscano > --- > virtManager/virtmanager.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/virtManager/virtmanager.py b/virtManager/virtmanager.py > index ee7d4d89..2c8ccbb8 100755 > ---

Re: [virt-manager PATCH 0/9] Various i18n fixes, part #4

On 9/17/20 2:43 AM, Pino Toscano wrote: > This patch series remove some more of the i18n issues, mostly > untranslatable strings, and string puzzles. > > Pino Toscano (9): > i18n: fix string puzzle in volume creation dialog > i18n: improve title of connection dialog > i18n: fix string

Re: [virt-manager PATCH 2/9] i18n: improve title of connection dialog

On 9/17/20 2:43 AM, Pino Toscano wrote: > Instead of using the title of the dialog and prepending the connection > label, create a new title as a single string. This way it is possible to > translate this title as single sentence. > > Signed-off-by: Pino Toscano > --- > virtManager/host.py | 5

virt-install: changing default --os-variant behavior

Hi virt-tools-list + CCd libosinfo developers too Use of virt-install without a detected guest OS, and without manually specified --os-variant, is a never ending source of bugs and user confusion and poorly performing VM configs. This mail is intended to start a discussion about how to improve

Re: [PATCH] Correct two translations for zh_CN

On 8/6/20 1:44 AM, Huacai Chen wrote: > Hi, Daniel, > > On Wed, Aug 5, 2020 at 10:57 PM Daniel P. Berrangé > wrote: >> >> On Wed, Aug 05, 2020 at 10:42:22AM -0400, Cole Robinson wrote: >>> On 8/5/20 4:32 AM, Pavel Hrdina wrote: >>>> On Wed, Aug 05

Re: [PATCH] virtManager: Folder sharing implementation for SPICE session

On 7/25/20 9:30 AM, Jitao Lu wrote: > * This implements folder sharing for the built-in Spice client, tested >working with Win10 guest. > * The basic idea is taken from virt-viewer. > > Signed-off-by: Jitao Lu > --- > ui/spicewebdav.ui | 129 +

Re: [PATCH] Correct two translations for zh_CN

On 8/13/20 12:21 AM, Huacai Chen wrote: > Hi, Cole, > > On Thu, Aug 13, 2020 at 2:07 AM Cole Robinson wrote: >> >> On 8/6/20 1:44 AM, Huacai Chen wrote: >>> Hi, Daniel, >>> >>> On Wed, Aug 5, 2020 at 10:57 PM Daniel P. Berrangé >>>

Re: [PATCH] virtManager: Folder sharing implementation for SPICE session

ger would only cover a common subset, to save us from having to maintain a duplicate feature set. Thanks, Cole > 閸︼拷 2020/8/13 娑撳﹤宕�4:29, Cole Robinson 閸愭瑩浜�: >> On 7/25/20 9:30 AM, Jitao Lu wrote: >>>   * This implements folder sharing for the built-in Spice client, tested >>>

Re: [PATCH] virtManager: Folder sharing implementation for SPICE session

h > over "port-opened" [0] for that. > > [0] > https://www.spice-space.org/api/spice-gtk/SpicePortChannel.html#SpicePortChannel--port-opened > No, what we mean is some notification from spice that there is actually a webdav agent listening/ready in the VM. Something

Re: [PATCH] Correct two translations for zh_CN

On 8/5/20 4:32 AM, Pavel Hrdina wrote: > On Wed, Aug 05, 2020 at 12:44:24PM +0800, Huacai Chen wrote: >> Hi, Pavel, >> >> On Mon, Aug 3, 2020 at 8:06 PM Pavel Hrdina wrote: >>> >>> On Mon, Aug 03, 2020 at 04:45:03PM +0800, Huacai Chen wrote: There is no "Error" in "Refresh snapshot list" and

Re: [virt-manager PATCH v2 0/5] Improve translations

On 7/7/20 4:53 PM, Pino Toscano wrote: > This patch series improve the handling of translations. > > Split the current virt-manager catalog in two: > - a virt-manager one, containing only the messages for the GUI; its > translations are still build and installed as usual > - a virt-manager-meta

Re: [virt-manager PATCH v4 0/9] Improve translations

On 7/13/20 4:58 AM, Pino Toscano wrote: > On Sunday, 12 July 2020 15:12:24 CEST Cole Robinson wrote: >> On 7/8/20 10:54 AM, Pino Toscano wrote: >>> This patch series improve the handling of translations. >>> >>> Use the gettext tools to: >>> - extr

Re: [virt-manager PATCH 00/21] Various i18n fixes

On 7/13/20 4:25 AM, Pino Toscano wrote: > This patch series tries to remove some of the i18n issues, mostly > untranslatable strings, and string puzzles. > > Not all the issues are fixed: there are still some string puzzles > around (for example the labels for disks in the VM details); they will

Re: [virt-manager PATCH 00/16] Various i18n fixes, part #2

On 7/14/20 3:41 AM, Pino Toscano wrote: > This patch series remove some more of the i18n issues, mostly > untranslatable strings, string puzzles, and plural forms. > > Also a couple of bugs related to i18n are fixed. > Thanks! I pushed with this squashed into the details.py controller patch, so

Re: [virt-manager PATCH 1/2] ci: commit the catalog only if changed

On 7/14/20 9:08 AM, Pino Toscano wrote: > Compare the newly generated catalog with the old one: if it actually > changed (i.e. there are changes beside the creation date), then push it > to the 'translations' branch. Thanks, I pushed these two - Cole

Re: [virt-manager PATCH 0/3] Various i18n fixes, part #3

On 7/15/20 8:48 AM, Pino Toscano wrote: > This patch series remove some more of the i18n issues, mostly > untranslatable strings, and string puzzles. > > Pino Toscano (3): > i18n: add missing placeholder name in string > i18n: create single strings for texts/messages > i18n: translate UI

Re: Plans for the new Ubuntu installer and a new release?

On 5/28/20 2:35 AM, Christian Ehrhardt wrote: > Hi, > I was writing a very minor patch [1] clearing the remaining Ubuntu > Delta. And then realized I was adding way too much content into the PR > text that doesn't match the context there. > That is better as a ML submission I guess :-) > > > On

Re: [virt-manager PATCH v2 0/2] Mention io_uring support

On 5/7/20 3:45 AM, Han Han wrote: > v1: > https://www.redhat.com/archives/virt-tools-list/2020-April/msg00019.html > > Diff from v1: Remove unused constant. > > Han Han (2): > disk: Remove unused constant IO_MODE_THREADS > docs: Add disk io mode io_uring > > man/virt-install.pod | 2 +-

Re: [PATCH v2 0/7] change default TPM for ppc64 + pylint fixes

On 6/3/20 9:14 AM, Daniel Henrique Barboza wrote: > Changes in v2: > - a fellow brazilian programmer informed me in private that I was > using 'forth' instead of 'fourth' all around the commit message > of patch 06. Let's avoid the irony of all the typos in a codespell > fix series. > > v1 link:

Re: [virt-manager PATCH v4 0/9] Improve translations

On 7/8/20 10:54 AM, Pino Toscano wrote: > This patch series improve the handling of translations. > > Use the gettext tools to: > - extract the messages from all the various sources > - merge old translations with the new catalog > - build translations as mo files > - merge translations to

Re: [PATCH] virtinst: add support for configuring the IOMMU

On 7/7/20 3:55 AM, Menno Lageman wrote: > Add a --iommu option to configure IOMMU parameters as described in > https://libvirt.org/formatdomain.html#elementsIommu > > E.g. 'virt-install --iommu model=intel,driver.aw_bits=48,driver.iotlb=on ...' > will generate the following domain XML: > > >

Re: [virt-manager RFC PATCH 3/3] Add GUI support for enabling Secure Encrypted Virtualization

Sorry for the long review delay, I've been hoarding virt-manager bits in a folder until I could find the time. I pushed patch #1 The interconnected sev + iommu=on + locked memory requirement scares me. Let's say user clicks the sev checkbox but it the VM fails to boot for some reason. They

Re: [virt-manager PATCH] bash completion: remove shebang

On 7/19/20 6:10 AM, Pino Toscano wrote: > The bash completion file is not a script to be executed directly, but > it is sourced by bash. Hence, remove its shebang. > > Signed-off-by: Pino Toscano > --- > data/bash-completion.sh.in | 2 -- > 1 file changed, 2 deletions(-) Thanks, pushed now -

Re: [virt-manager PATCH] about: use the standard license type

On 7/18/20 4:09 AM, Pino Toscano wrote: > Use the standard gpl-2-0 license type of GtkAboutDialog, instead of the > custom license text: this way, the dialog will show a translated text > with the license type, and a link to the full license text. > > Signed-off-by: Pino Toscano Thanks, pushed

Re: [PATCH] virtmanager: Fixed the legacy firmware installation error

On 1/5/21 2:34 AM, Cho, Yu-Chen wrote: > When we choose /usr/share/qemu/bios.bin or /usr/share/qemu/bios-256k.bin > in Customize configuration before install, show this error message: > > Unable to complete install: 'operation failed: unable to find any master var > store for loader:

Re: [virt-manager PATCH 0/3] Create pool: show only available types

On 11/24/20 9:21 AM, Pino Toscano wrote: > Hi, > > this series adds a minimal StoragePoolCapabilities handling using the > virConnect.getStoragePoolCapabilities libvirt API; this is used to > filter the available pool types in the "Create pool" dialog, so it does > not offer anymore pool types

Re: [virt-manager PATCH 0/3] Create pool: show only available types

On 12/8/20 9:09 AM, Pino Toscano wrote: > Hi Cole, > > I'm reordering the paragraphs of your answer to ease mine. > > On Monday, 7 December 2020 20:39:29 CET Cole Robinson wrote: >> Can you explain your motivation a bit: Has this caused you issues >> before? > &

Re: [virt-manager PATCH 0/3] Create pool: show only available types

ine source, in which case having clicky (and limited) UI doesn't add much over the XML editor or the command line. - Cole > Cheers, > > - Peter > > On Mon, 7 Dec 2020 at 19:39, Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 11/24/20 9:21 AM, Pino

ANNOUNCE: virt-manager 3.2.0 released

ANNOUNCE: virt-manager 3.2.0 released I'm happy to announce the release of virt-manager 3.2.0! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - Slim

Re: [virt-manager PATCH] Add /usr/sbin to search path for non-root user

On 10/23/20 5:20 PM, Charles Arnold wrote: > On a fresh install where no previous connection has been made a > non-root user starting virt-manager won't find the installed libvirtd > because the location is not in the user path. > > Signed-off-by: Charles Arnold > --- >

Re: virt-install: changing default --os-variant behavior

Following on from this I submitted a linux2020 entry to osinfo-db: https://gitlab.com/libosinfo/osinfo-db/-/merge_requests/237 Thanks, Cole On 9/20/20 4:09 PM, Cole Robinson wrote: > Hi virt-tools-list + CCd libosinfo developers too > > Use of virt-install without a detected

Re: [PATCH] virtmanager: Fixed the legacy firmware installation error

On 1/13/21 1:40 AM, Al Cho wrote: > Hi, > > That's before the last step during install new VM, > and there is a checkbutton "Customize Configure before install" > and Apply after choose Frimware bios.bin or bios-256k.bin, Click "Begin > Installation" > show up the error message, list virt-manager

Re: [PATCH] virtmanager: Fixed the legacy firmware installation error

On 12/22/20 3:24 AM, Cho, Yu-Chen wrote: > When we choose /usr/share/qemu/bios.bin or /usr/share/qemu/bios-256k.bin > in Customize configuration before install, show this error message: > > Unable to complete install: 'operation failed: unable to find any master var > store for loader:

Re: ERROR internal error: Unexpected enum value 0 for virDomainDeviceAddressType

On 6/4/21 5:40 AM, Mario Marietto wrote: > Hello. > > I want to emulate the raspberry pi 3 on my Jetson nano (aarch64) using > virt-install. I'm learning how to do that by reading heavily here : > > https://github.com/dhruvvyas90/qemu-rpi-kernel >

Re: [PATCH] cloner: mark transient_shareBacking disk as shareable

On 6/17/21 4:40 AM, Liu Yiding wrote: > libvirt 7.4.0 added support for sharing base image of disks, > multiple VMs can share the same image > https://libvirt.org/news.html#v7-4-0-2021-06-01 > > Signed-off-by: Liu Yiding > --- > virtinst/cloner.py | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [virt-manager][PATCH v2] virtinst: Support missing NVDIMM knobs

On 6/21/21 12:31 PM, Michal Privoznik wrote: > There are two domain XML knobs specific to NVDIMMs that > virt-install doesn't allow to set: and . > Implement them. > > Closes: https://github.com/virt-manager/virt-manager/issues/267 > Signed-off-by: Michal Privoznik > --- > > v2 of: > >

Re: [virt-manager PATCH] spec: use %autosetup

On 6/21/21 5:53 PM, Jonathon Jongsma wrote: > Make sure potential patches get applied by using %autosetup instead of > plain %setup > > Signed-off-by: Jonathon Jongsma > --- > virt-manager.spec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt-manager.spec

Re: [PATCH virt-manager v3] virt-manager: enable MDEV support

On 6/7/21 5:34 AM, Shalini Chellathurai Saroja wrote: > Enable virt-manager GUI to support add, edit, remove, hot-plug and > hot-unplug of mediated devices (like DASDs, APQNs and PCIs) in virtual > server. > > It is not possible to edit MDEV when a virtual server is in > running state, as this is

Re: ERROR internal error: Unexpected enum value 0 for virDomainDeviceAddressType

On 6/8/21 4:43 AM, Mario Marietto wrote: > root@zi-desktop:~/Desktop/zi/Work/I9/qemu-rpi-kernel# virsh --version > 7.4.0 > > virt-install \ >     --debug \ >     --name pi \ >     --machine raspi3 \ >     --cpu arm1176 \ >     --memory 1024 \ >     --import \ >     --disk >

Re: [PATCH virt-install v1 3/3] virtxml: prevent defining same hostdev again

On 4/14/21 11:18 AM, Shalini Chellathurai Saroja wrote: > Currently, it is possible to add same device multiple times, when the > guest domain is in shut-off state. This patch prevents this unexpected > behavior for all hostdev devices, including mdev devices. > If this is an invalid config,

Re: [PATCH virt-install v1 2/3] virt-xml: add support for mediated devices

On 4/14/21 11:18 AM, Shalini Chellathurai Saroja wrote: > Provide support to add/remove mdev in a guest domain, which is in > shut-off or running state (hotplug/unplug). Also support update of > already existing mdev device, when the guest domain is in shut-off > state. Please note that libvirt

Re: [PATCH virt-install v1 1/3] virt-install: add mediated device

On 4/14/21 11:18 AM, Shalini Chellathurai Saroja wrote: > Add support to install a virtual server with passed-through mediated > device. Mediated device can be created using vGPU attached to > vfio_pci driver or DASD attached to vfio_ccw driver or APQNs attached > to vfio_ap driver. > >

Re: [PATCH virt-install] virtinst: Support rotation_rate attrib in target

On 5/18/21 2:36 AM, Han Han wrote: > Support rotation_rate attrib which is introduced since libvirt v7.3. > > Signed-off-by: Han Han Thanks! But you need to extend tests/test_cli.py --disk examples as well otherwise test suite is failing (but I didn't confirm) Thanks, Cole > --- >

Re: [PATCH] cli: --feature: Support kvm.poll-control.state

On 5/27/21 12:01 AM, Han Han wrote: > Implement kvm.poll-control.state to `virt-install --feature`. It requires > libvirt >= v6.10.0. > > Signed-off-by: Han Han > --- > tests/data/cli/compare/virt-install-singleton-config-3.xml | 1 + > tests/test_cli.py

<    13   14   15   16   17   18   19   >