[virt-tools-list] [PATCH v5 2/3] remote-viewer: Remove unused properties

The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c

[virt-tools-list] [PATCH v5 virt-viewer 0/3] Port to GtkApplication API's

In this version: Rebased to latest master Eduardo Lima (Etrunko) (3): Port to GtkApplication API's remote-viewer: Remove unused properties Drop old compatibility code configure.ac| 6 +- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1

[virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

emoved' signals, as those will be emited by GtkApplication whenever gtk_application_add_window() and gtk_application_remove_window() are called. Also, 'window-removed' was not being used anywhere. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac |

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

On 02/16/2016 10:41 AM, Pavel Grunt wrote: > Hi, > > On Mon, 2016-02-15 at 19:22 -0200, Eduardo Lima (Etrunko) wrote: >> Most of this patch consists in code being shuffled around to fit the >> expected flow while using the new APIs. I tried my best to make this >&g

[virt-tools-list] [PATCH v6 1/3] Port to GtkApplication API's

emoved' signals, as those will be emited by GtkApplication whenever gtk_application_add_window() and gtk_application_remove_window() are called. Also, 'window-removed' was not being used anywhere. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac |

[virt-tools-list] [PATCH v6 virt-viewer 0/3] Port to GtkApplication API's

g_object_new() directly. Eduardo Lima (Etrunko) (3): Port to GtkApplication API's remote-viewer: Remove unused properties Drop old compatibility code configure.ac| 6 +- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 - src/remote

[virt-tools-list] [PATCH v6 3/3] Drop old compatibility code

With glib requirements now being 2.38, these functions do not make sense anymore. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 - src/virt-glib-compat.c | 34 - src/vir

[virt-tools-list] [PATCH v6 2/3] remote-viewer: Remove unused properties

The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c

Re: [virt-tools-list] [PATCH v5 1/3] Port to GtkApplication API's

On 02/17/2016 01:22 PM, Jonathon Jongsma wrote: >>> I disagree, but again, I think it is basically a matter of >>> preference. >> >> It is. From the macro name it is not clear for me how is different >> "GOTO_END" from "goto end" > > For what it's worth, I agree with Pavel here. I think it

Re: [virt-tools-list] [PATCH virt-viewer] display: Set value of desktop width and height property directly

On 02/02/2016 10:59 AM, Pavel Grunt wrote: > Hi, > > On Tue, 2016-02-02 at 09:47 -0200, Eduardo Lima (Etrunko) wrote: >> On 01/27/2016 03:33 PM, Pavel Grunt wrote: >>> Avoid calling gtk_widget_queue_resize() and emitting >>> the "display-desktop-resize

Re: [virt-tools-list] [PATCH 2/2] configure: cleanup {GLIB2, GTK}_CFLAGS

On 03/22/2016 08:02 AM, Pavel Grunt wrote: > Hi, > > imo with the change the line is too long > > About the AC_SUBST calls - iirc they are defined automatically when > pkg-config is >= 0.24 (not the case of rhel6). > Or is it about something else (why just _LIBS and not _CFLAGS) ? > About line

Re: [virt-tools-list] [PATCH 2/2] configure: cleanup {GLIB2, GTK}_CFLAGS

On 03/22/2016 10:42 AM, Eduardo Lima (Etrunko) wrote: > On 03/22/2016 08:02 AM, Pavel Grunt wrote: >> Hi, >> >> imo with the change the line is too long >> >> About the AC_SUBST calls - iirc they are defined automatically when >> pkg-config is >= 0.24

Re: [virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote: > On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote: >> Let's take advantage of GResource for loading ui files in a better and >> cleaner way than virt_viewer_util_load_ui() was doing. >> It also brings the benefit, at

Re: [virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

er.png">../icons/16x16/virt-viewer.png > + alias="icons/22x22/virt-viewer.png">../icons/22x22/virt-viewer.png > + alias="icons/24x24/virt-viewer.png">../icons/24x24/virt-viewer.png > + alias="icons/24x24/virt-viewer-usb.png">../icons/24x24/virt-viewer-usb.png > + alias="icons/32x32/virt-viewer.png">../icons/32x32/virt-viewer.png > + alias="icons/48x48/virt-viewer.png">../icons/48x48/virt-viewer.png > + alias="icons/256x256/virt-viewer.png">../icons/256x256/virt-viewer.png > + > + > diff --git a/virt-viewer.spec.in b/virt-viewer.spec.in > index 274e7e7..3c483ea 100644 > --- a/virt-viewer.spec.in > +++ b/virt-viewer.spec.in > @@ -122,15 +122,6 @@ fi > %doc README COPYING AUTHORS ChangeLog NEWS > %{_bindir}/%{name} > %{_bindir}/remote-viewer > -%dir %{_datadir}/%{name} > -%dir %{_datadir}/%{name}/ui/ > -%{_datadir}/%{name}/ui/virt-viewer.xml > -%{_datadir}/%{name}/ui/virt-viewer-auth.xml > -%{_datadir}/%{name}/ui/virt-viewer-about.xml > -%{_datadir}/%{name}/ui/virt-viewer-guest-details.xml > -%{_datadir}/%{name}/ui/virt-viewer-vm-connection.xml > -%{_datadir}/%{name}/ui/virt-viewer-preferences.xml > -%{_datadir}/%{name}/ui/remote-viewer-connect.xml > %{_datadir}/icons/hicolor/*/apps/* > %{_datadir}/icons/hicolor/*/devices/* > %{_datadir}/applications/remote-viewer.desktop > Looking good from my side. :) Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

On 03/02/2016 05:24 PM, Fabiano Fidêncio wrote: > On Wed, Mar 2, 2016 at 8:05 PM, Eduardo Lima (Etrunko) > <etru...@redhat.com> wrote: >> On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote: >>> On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote: >>>> Let's tak

Re: [virt-tools-list] [virt-viewer] app: Remove useless libxml includes

r-app.c > @@ -36,9 +36,6 @@ > #include > #include > > -#include > -#include > - > #ifdef HAVE_SYS_SOCKET_H > #include > #endif > Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> -- Eduardo de Barr

Re: [virt-tools-list] [virt-viewer] ovirt: Only use active ISO domains for foreign menu

On 03/01/2016 10:36 AM, Christophe Fergeau wrote: > oVirt storage domains can be in various states (inactive, in > maintainance, ...). We only want to show the ISOs it contains in the > foreign menu when the storage domain is actually active, not in the > other states. > --- >

Re: [virt-tools-list] [virt-viewer v2] ovirt: Only use active ISO domains for foreign menu

; Changes since v1: >>> - added new condition to an existing if() block >> >> Fwiw, I prefer the v1 way which I find much easier to read. > > Same here. V1 it is then :) Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> -- Eduardo de Barros Lima (Etrunko)

[virt-tools-list] [PATCH v2 virt-viewer 1/2] Fix spice includes

[-Wcpp] This patch also bumps spice version requirement to 0.31, to ensure those files are available. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac| 2 +- src/virt-viewer-display-spice.c | 2 +- src/virt-viewer-display-spice.h | 3 +-

[virt-tools-list] [PATCH virt-viewer v2 09/12] Run iso-dialog when 'Change CD' menu is activated

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 1 + src/virt-viewer-window.c| 24 2 files changed, 25 insertions(+) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index a

[virt-tools-list] [PATCH virt-viewer v2 10/12] remote-viewer: Make ovirt-foreign-menu a property

The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c | 31 +++ src/

[virt-tools-list] [PATCH virt-viewer v3 05/10] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..af3ae46 100644 --- a/src/res

[virt-tools-list] [PATCH virt-viewer v3 04/10] ovirt-foreign-menu: Notify of new files even if nothing changed

When user presses the Refresh button in ISO dialog, the list is cleared, and currently, the only way it is informed of the new list is by the notify signal. The same applies when an error occurs while trying to change the current ISO. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.

[virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

- Removed "Select ISO" label and alignment in header bar patch. Eduardo Lima (Etrunko) (10): ovirt-foreign-menu: Remove timer used to refresh iso list ovirt-foreign-menu: Add accessors for current iso and iso list ovirt-foreign-menu: Remove GtkMenu related functions ovirt-foreign

[virt-tools-list] [PATCH virt-viewer v3 09/10] iso-dialog: Implement functionality provided by oVirt foreign menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c| 180 - src/resources/ui/remote-viewer-iso-list.ui | 5 +- 2 files changed, 181 insertions(+), 4 deletions(-) diff --git a/src/remote-viewer-iso-list-di

[virt-tools-list] [PATCH virt-viewer v3 03/10] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

[virt-tools-list] [PATCH virt-viewer v3 08/10] remote-viewer: Make ovirt-foreign-menu a property

The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c | 31 +++ src/

[virt-tools-list] [PATCH virt-viewer v3 01/10] ovirt-foreign-menu: Remove timer used to refresh iso list

With the new ISO dialog, the user triggers the refresh manually. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-f

[virt-tools-list] [PATCH virt-viewer v3 10/10] iso-dialog: Use header bar for buttons

s gone too. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac | 4 +- src/remote-viewer-iso-list-dialog.c| 31 +-- src/resources/ui/remote-viewer-iso-list.ui | 87 +++--- 3 files changed, 60 insertions(

[virt-tools-list] [PATCH virt-viewer v3 06/10] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 106 src/remote-viewer-iso-list-dialog.h

[virt-tools-list] [PATCH virt-viewer v3 02/10] ovirt-foreign-menu: Add accessors for current iso and iso list

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 49 ++-- src/ovirt-foreign-menu.h | 5 - 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-

[virt-tools-list] [PATCH virt-viewer v3 07/10] Run iso-dialog when 'Change CD' menu is activated

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 1 + src/virt-viewer-window.c| 24 2 files changed, 25 insertions(+) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index a

Re: [virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

On 08/10/2016 07:41 AM, Pavel Grunt wrote: > On Tue, 2016-08-09 at 17:44 +0200, Christophe Fergeau wrote: >> On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote: >>> >>> Just connect to the signal >> >> I'm tempted to ask "why?". I think it's recommended (more efficient) to >> just

Re: [virt-tools-list] [PATCH virt-viewer] display: Do not override size-allocate handler

On 08/09/2016 12:44 PM, Christophe Fergeau wrote: > On Tue, Aug 09, 2016 at 05:17:31PM +0200, Pavel Grunt wrote: >> Just connect to the signal > > I'm tempted to ask "why?". I think it's recommended (more efficient) to > just override the vfunc directly when you can (ie when you derive a new >

[virt-tools-list] [PATCH virt-viewer v2 01/11] ovirt-foreign-menu: Rework states logic

Use switch/case instead of lots of conditional blocks Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src

Re: [virt-tools-list] [PATCH virt-viewer 03/11] ovirt-foreign-menu: Remove timer used to refresh iso list

On 07/18/2016 09:14 AM, Pavel Grunt wrote: > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: >> With the new ISO dialog, the user triggers the refresh manually. > > This should come after the dialog is introduced> Well, I have no plans in merging an

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

On 07/18/2016 06:15 AM, Pavel Grunt wrote: > Hi Eduardo, > > On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: >> Use switch/case instead of lots of conditional blocks > Yes, it is more readable >> >> Signed-off-by: Eduardo Lima (Etrunko) <etru...

Re: [virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

On 07/18/2016 11:58 AM, Pavel Grunt wrote: > On Mon, 2016-07-18 at 10:22 -0300, Eduardo Lima (Etrunko) wrote: >> On 07/18/2016 06:15 AM, Pavel Grunt wrote: >>> >>> Hi Eduardo, >>> >>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wro

[virt-tools-list] [PATCH virt-viewer 00/11] Replace oVirt foreign menu with dedicated dialog

programming the whole UI manually. Eduardo Lima (Etrunko) (11): ovirt-foreign-menu: Rework states logic ovirt-foreign-menu: Use g_clear_pointer/g_clear_object ovirt-foreign-menu: Remove timer used to refresh iso list ovirt-foreign-menu: Add accessors for current iso and iso list ovirt

[virt-tools-list] [PATCH virt-viewer 08/11] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 115 +++ src/remote-viewer-iso-list-dialog.h| 58 ++ src/resources/ui/remote-viewer-iso-list.ui

[virt-tools-list] [PATCH virt-viewer 01/11] ovirt-foreign-menu: Rework states logic

Use switch/case instead of lots of conditional blocks Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 76 +++- 1 file changed, 36 insertions(+), 40 deletions(-) diff --git a/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer 06/11] ovirt-foreign-menu: Notify of new files even if list did not change

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 24b5af2..75154bb 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-f

[virt-tools-list] [PATCH virt-viewer 04/11] ovirt-foreign-menu: Add accessors for current iso and iso list

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 49 ++-- src/ovirt-foreign-menu.h | 5 - 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-

[virt-tools-list] [PATCH virt-viewer 02/11] ovirt-foreign-menu: Use g_clear_pointer/g_clear_object

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 68 1 file changed, 16 insertions(+), 52 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index b0b8fec..889e7bc

[virt-tools-list] [PATCH virt-viewer 07/11] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 57 +++-- 1 file changed, 21 insertions(+), 36 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..e

[virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c | 20 +++- src/remote-view

[virt-tools-list] [PATCH virt-viewer 05/11] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

[virt-tools-list] [PATCH virt-viewer 11/11] iso-dialog: Implement functionality provided by oVirt foreign menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c| 149 + src/resources/ui/remote-viewer-iso-list.ui | 4 +- 2 files changed, 152 insertions(+), 1 deletion(-) diff --git a/src/remote-viewer-iso-list-di

[virt-tools-list] [PATCH virt-viewer 03/11] ovirt-foreign-menu: Remove timer used to refresh iso list

With the new ISO dialog, the user triggers the refresh manually. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-f

[virt-tools-list] [PATCH virt-viewer 09/11] Run iso-dialog when 'Change CD' menu is activated

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 1 + src/virt-viewer-window.c| 29 + 2 files changed, 30 insertions(+) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui

Re: [virt-tools-list] [PATCH virt-viewer 05/11] ovirt-foreign-menu: Remove GtkMenu related functions

On 07/19/2016 12:43 PM, Christophe Fergeau wrote: > On Sun, Jul 17, 2016 at 11:13:05PM -0300, Eduardo Lima (Etrunko) wrote: >> With this commit, we finish cleaning up ovirt foreign menu code, which >> only deals with data, leaving the UI bits to be handled properly in the >>

Re: [virt-tools-list] [PATCH virt-viewer 08/11] Introduce ISO List dialog

On 07/19/2016 01:13 PM, Christophe Fergeau wrote: > On Sun, Jul 17, 2016 at 11:13:08PM -0300, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> src/Makefile.am| 3 + >> sr

Re: [virt-tools-list] [PATCH virt-viewer 07/11] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

On 07/19/2016 12:46 PM, Christophe Fergeau wrote: > Your glade seems to have added unrelated changes to that commit. If > newer versions of glade are always going to make these changes, we can > commit them separately. > Dunno why all those changes got in, most likely because of different

Re: [virt-tools-list] [PATCH virt-viewer 03/11] ovirt-foreign-menu: Remove timer used to refresh iso list

On 07/19/2016 12:11 PM, Christophe Fergeau wrote: > On Mon, Jul 18, 2016 at 10:18:14AM -0300, Eduardo Lima (Etrunko) wrote: >> On 07/18/2016 09:14 AM, Pavel Grunt wrote: >>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote: >>>> With the new ISO dialog,

Re: [virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

On 07/19/2016 12:57 PM, Christophe Fergeau wrote: >> + >> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog); >> +self->priv->foreign_menu = foreign_menu; > > I'd g_object_ref it if you need to have it around (together with > g_clear_object > in dispose/finalize). Okay, fixed. >> + >>

Re: [virt-tools-list] [PATCH virt-viewer 10/11] remote-viewer: Make ovirt-foreign-menu a property

On 07/19/2016 02:54 PM, Eduardo Lima (Etrunko) wrote: > On 07/19/2016 12:57 PM, Christophe Fergeau wrote: >>> + >>> +self = REMOTE_VIEWER_ISO_LIST_DIALOG(dialog); >>> +self->priv->foreign_menu = foreign_menu; >> >> I'd g_objec

[virt-tools-list] [PATCH virt-viewer v2 10/11] remote-viewer: Make ovirt-foreign-menu a property

The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c | 25 - src/remote-

[virt-tools-list] [PATCH virt-viewer v2 07/11] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..af3ae46 100644 --- a/src/res

Re: [virt-tools-list] [PATCH virt-viewer 04/11] ovirt-foreign-menu: Add accessors for current iso and iso list

On 07/19/2016 12:32 PM, Christophe Fergeau wrote: > On Sun, Jul 17, 2016 at 11:13:04PM -0300, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> src/ovirt-foreign-menu.c | 49 >> +

Re: [virt-tools-list] [PATCH] Get rid of deprecated functions to customize widget colors

On 06/28/2016 07:21 AM, Fabiano Fidêncio wrote: > On Tue, Jun 28, 2016 at 12:08 PM, Pavel Grunt <pgr...@redhat.com> wrote: >> Hi Eduardo, >> >> On Mon, 2016-06-27 at 18:00 -0300, Eduardo Lima (Etrunko) wrote: >>> Fixes https://bugs.freedesktop.org/show

[virt-tools-list] [PATCH v2 virt-viewer] Get rid of deprecated functions to customize widget colors

Let's just stick with default theme colors. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer-notebook.c | 13 ++--- src/virt-viewer-window.c | 10 -- 2 files changed, 2 insertions(

Re: [virt-tools-list] [PATCH virt-viewer] window: Factor out common code for toolbar items

On 06/28/2016 12:16 PM, Fabiano Fidêncio wrote: > On Tue, Jun 28, 2016 at 5:10 PM, Pavel Grunt wrote: >> Create toolbar widget in the loop > > NACK from my side. > There is any gain on re-factoring a code that will be removed as soon > as we do the release. > Actually, it just

[virt-tools-list] [PATCH virt-viewer v2 12/12] iso-dialog: Use header bar for buttons

It seems to give more modern look to the dialog, but it requires Gtk+ 3.12, thus I will am keeping this commit separated. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac| 4 ++-- src/remote-viewer-iso-list-dialog.

[virt-tools-list] [PATCH virt-viewer v2 03/12] ovirt-foreign-menu: Remove timer used to refresh iso list

With the new ISO dialog, the user triggers the refresh manually. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-f

[virt-tools-list] [PATCH virt-viewer v2 07/12] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..af3ae46 100644 --- a/src/res

[virt-tools-list] [PATCH virt-viewer v2 11/12] iso-dialog: Implement functionality provided by oVirt foreign menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c| 157 - src/resources/ui/remote-viewer-iso-list.ui | 5 +- 2 files changed, 158 insertions(+), 4 deletions(-) diff --git a/src/remote-viewer-iso-list-di

[virt-tools-list] [PATCH virt-viewer v2 02/12] ovirt-foreign-menu: Use g_clear_pointer/g_clear_object

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> Acked-by: Christophe Fergeau <cferg...@redhat.com> --- src/ovirt-foreign-menu.c | 68 1 file changed, 16 insertions(+), 52 deletions(-) diff --git a/src/ovirt-foreign-menu.c

[virt-tools-list] [PATCH virt-viewer v2 01/12] ovirt-foreign-menu: Rework states logic

Use switch/case instead of lots of conditional blocks Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> Acked-by: Pavel Grunt <pgr...@redhat.com> --- src/ovirt-foreign-menu.c | 46 -- 1 file changed, 20 insertions(+), 26 deleti

[virt-tools-list] [PATCH virt-viewer v2 06/12] ovirt-foreign-menu: Notify of new files even if nothing changed

When user presses the Refresh button in ISO dialog, the list is cleared, and currently, the only way it is informed of the new list is by the notify signal. The same applies when an error occurs while trying to change the current ISO. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.

[virt-tools-list] [PATCH virt-viewer v2 05/12] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

[virt-tools-list] [PATCH virt-viewer v2 08/12] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 112 + src/remote-viewer-iso-list-dialog.h

[virt-tools-list] [PATCH virt-viewer v2 04/12] ovirt-foreign-menu: Add accessors for current iso and iso list

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 49 ++-- src/ovirt-foreign-menu.h | 5 - 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-

[virt-tools-list] [PATCH virt-viewer v2 00/12] Replace oVirt foreign menu with dedicated dialog

, making it more robust in case of errors. Eduardo Lima (Etrunko) (12): ovirt-foreign-menu: Rework states logic ovirt-foreign-menu: Use g_clear_pointer/g_clear_object ovirt-foreign-menu: Remove timer used to refresh iso list ovirt-foreign-menu: Add accessors for current iso and iso list ovirt

Re: [virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

On 08/02/2016 01:17 PM, Christophe Fergeau wrote: > On Fri, Jul 29, 2016 at 06:40:23PM -0300, Eduardo Lima (Etrunko) wrote: >> I have pushed the first two patches of the series because they were >> already acknowledged and were pretty much self-contained. >> >> I t

[virt-tools-list] [PATCH] Adjust timer to refresh ovirt foreign menu

-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 2d286fb..33ff4f1 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-foreign-menu.c @@ -797,7

Re: [virt-tools-list] [PATCH] Adjust timer to refresh ovirt foreign menu

On 06/30/2016 09:03 AM, Fabiano Fidêncio wrote: > On Thu, Jun 30, 2016 at 2:01 PM, Eduardo Lima (Etrunko) > <etru...@redhat.com> wrote: >> This is a temporary solution, as discussed in the bug. We will adjust >> the timer to refresh the ISO list from 15 seconds to 5 minutes

Re: [virt-tools-list] [PATCH v2 virt-viewer] Get rid of deprecated functions to customize widget colors

On 06/29/2016 05:08 AM, Pavel Grunt wrote: > Hi, > > Imo the commit message should say that there are issues with the font / > background colour since commit ... in some gtk versions - like you said in the > comment for v1, because that is the reason for this patch. Getting rid of > deprecated

Re: [virt-tools-list] [PATCH] timed-revealer: listen to the "grab-notify" signal

On 06/29/2016 10:36 AM, Fabiano Fidêncio wrote: > The "grab-notify" signal lets us know when our widget becomes > shadowed by a Gtk+ grab on another widget, or when it becomes unshadowed > due to a grab being removed. > > That's exactly the case we face when dealing with "usb-redirection" and >

[virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

a GCancellable to the asynchronous operations, so they can be cancelled if the dialog happens to get closed before they complete. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- v2: * Move call to g_cancellable_cancel() to response handler. * Don't leak error objects if ope

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Do not use string directly

Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> On 06/02/17 10:02, Pavel Grunt wrote: > Fixes -Werror=format-security used when creating the rpm > --- > see: > https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-v

Re: [virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

age before dereferencing it, but I don't really know what others think about it. Reviewed-by: Eduardo Lima (Etrunko) <etru...@redhat.com> -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

On 03/02/17 14:34, Christophe Fergeau wrote: > Hey, > > On Thu, Jan 26, 2017 at 06:01:23PM -0200, Eduardo Lima (Etrunko) wrote: >> We must take into account that users can close the dialog at anytime, >> even during an operation of fetch or set ISO has not been finishe

Re: [virt-tools-list] [PATCH virt-viewer 1/5] ovirt-foreign-menu: Add accessors for current iso and iso list

On 20/01/17 13:16, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau <cferg...@redhat.com> Pushed, thanks. > > On Thu, Jan 19, 2017 at 01:42:10PM -0200, Eduardo Lima (Etrunko) wrote: >> Also, to keep consistency around the codebase,

Re: [virt-tools-list] [PATCH virt-viewer 2/5] Introduce ISO List dialog

, 2017 at 01:42:11PM -0200, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> po/POTFILES.in | 2 + >> src/Makefile.am| 3 + >>

[virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

a GCancellable to the asynchronous operations, so they can be cancelled if the dialog happens to get closed before they complete. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c | 30 +++--- 1 file changed, 27 insertions

Re: [virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

On 16/02/17 20:57, Daniel P. Berrange wrote: > On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote: >> On 16/02/17 10:06, Pavel Grunt wrote: >>> Hi, >>> >>> On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: >>>> Thi

Re: [virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

On 16/02/17 20:57, Daniel P. Berrange wrote: > On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote: >> On 16/02/17 10:06, Pavel Grunt wrote: >>> Hi, >>> >>> On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: >>>> Thi

Re: [virt-tools-list] [PATCH virt-viewer v2] iso-dialog: Avoid crash when closing dialog early

On 09/02/17 17:19, Pavel Grunt wrote: > Hi Eduardo, > > On Thu, 2017-02-09 at 15:13 -0200, Eduardo Lima (Etrunko) wrote: >> We must take into account that users can close the dialog at >> anytime, >> even during an operation of fetch or set ISO has not been fini

[virt-tools-list] [PATCH virt-viewer 08/10] virt-viewer-auth: Use GtkHeaderBar

The auxiliary text is now presented as the subtitle of the dialog Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer-auth.ui | 148 --- src/virt-viewer-auth.c | 35 + 2 files changed, 86 inse

Re: [virt-tools-list] [PATCH virt-viewer v2] session-spice: Pass hostname to authentication dialog

On 09/02/17 17:22, Pavel Grunt wrote: > On Thu, 2017-02-09 at 15:32 -0200, Eduardo Lima (Etrunko) wrote: >> With this patch the dialog now shows the host we are connecting to. >> >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > Acked-by: Pavel Gru

Re: [virt-tools-list] [virt-viewer updated PATCH] Show errors generated by connection dialog

goto retry_dialog; > } > Sorry for starting this endless discussion about checking for error->message, it has been shown that it is not necessary (TIL). As this version addresses the comments of explicit checking, from Pavel, it's an Ack. Acked-by: Eduardo Lima (Etrunko) <e

[virt-tools-list] [PATCH virt-viewer v2] session-spice: Pass hostname to authentication dialog

With this patch the dialog now shows the host we are connecting to. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- v2: Use proper uri if connecting via proxy. --- src/virt-viewer-session-spice.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sr

Re: [virt-tools-list] [PATCH virt-viewer] iso-dialog: Avoid crash when closing dialog early

Looks like this v2 never made to the list? I am sending it again. On 03/02/17 15:28, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at anytime, > even during an operation of fetch or set ISO has not been finished. This > will cause the

[virt-tools-list] [PATCH virt-viewer v2] iso-dialog: Avoid crash when closing dialog early

a GCancellable to the asynchronous operations, so they can be cancelled if the dialog happens to get closed before they complete. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- v2: * Move call to g_cancellable_cancel() to response handler. * Don't leak error objects if ope

Re: [virt-tools-list] [PATCH virt-viewer v2] iso-dialog: Avoid crash when closing dialog early

On 09/02/17 15:13, Eduardo Lima (Etrunko) wrote: > We must take into account that users can close the dialog at anytime, > even during an operation of fetch or set ISO has not been finished. This > will cause the callbacks for those operations to be invoked with an > invalid obje

Re: [virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

On 16/02/17 10:06, Pavel Grunt wrote: > Hi, > > On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote: >> This whole series is the result of the initial idea of having the >> new >> iso-dialog to use this widget. Having it done only for the iso- >> di

Re: [virt-tools-list] [PATCH virt-viewer 3/5] iso-dialog: Use header bar for buttons

On 20/01/17 13:26, Fabiano Fidêncio wrote: > On Fri, Jan 20, 2017 at 4:21 PM, Christophe Fergeau > wrote: >> I haven't looked at this patch at all, as I don't know what the plan is >> for virt-viewer regarding gtk+ versions. It's easy to move last in the >> series though.

[virt-tools-list] [PATCH virt-viewer 0/4 v8] Replace oVirt foreign menu with dedicated dialog

In this version, I have addressed the comments on the ISO dialog code, also providing a better message for that commit. Also, put the headerbar patch at the end, as others were already acked and should be ready to merge. Eduardo Lima (Etrunko) (4): Introduce ISO List dialog Run ISO dialog

[virt-tools-list] [PATCH virt-viewer 1/4] Introduce ISO List dialog

files in a treeview. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 365 + src/remote-viewer-is

[virt-tools-list] [PATCH virt-viewer 3/4] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

<    1   2   3   4   >