[virt-tools-list] [PATCH virt-viewer 4/4] iso-dialog: Use header bar for buttons

s gone too. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac | 4 +- src/remote-viewer-iso-list-dialog.c| 31 +-- src/resources/ui/remote-viewer-iso-list.ui | 87 +++--- 3 files changed, 60 insertions(

[virt-tools-list] [PATCH virt-viewer 2/4] Run ISO dialog when 'Change CD' menu is activated

. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 37 + src/resources/ui/virt-viewer.ui | 19 ++- src/virt-viewer-window.c| 37 + 3 files chang

[virt-tools-list] [PATCH virt-viewer 07/10] about-dialog: Use GtkHeaderBar

For this one, we use the application version as the subtitle. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer-about.ui | 20 ++-- src/virt-viewer-window.c | 9 ++--- 2 files changed, 20 insertions(+), 9 del

[virt-tools-list] [PATCH virt-viewer 05/10] remote-viewer-connect: Use GtkHeaderBar

Just like the virt-viewer-connect dialog, the connect button has been moved to the header bar. Additionally, the example text is now presented as the subtitle. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-connect.c | 20 +--- src/resour

[virt-tools-list] [PATCH virt-viewer 04/10] virt-viewer-vm-connection: Use GtkHeaderBar

Here we moved the connect button to the header bar. Unfortunately, I could not find a "connect-symbolic" icon to be used here, so I ended up with the stock icon. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer-vm-co

[virt-tools-list] [PATCH virt-viewer 01/10] Update Gtk+ requirements to 3.12

This is new version ships with GtkHeaderBar code, which we will require for the dialogs on the application. In the future the main window could also make use of this widget, following the style of other applications. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.

[virt-tools-list] [PATCH virt-viewer 02/10] iso-dialog: Use GtkHeaderBar

We now display the current ISO as subtitle on the HeaderBar. On the glade UI file, we get rid of the GtkAlignment object that was used to put some space between the tree view and dialog buttons. The "Select ISO" label is gone too. Signed-off-by: Eduardo Lima (Etrunko) <etru.

[virt-tools-list] [PATCH virt-viewer 06/10] virt-viewer-preferences: Use GtkHeaderBar

This dialog changed very little when compared to the old version. I did change the way widgets are organized within the dialog, as it now groups the file selector together with the read-only checkbox. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-

[virt-tools-list] [PATCH virt-viewer 03/10] guest-details-dialog: Use GtkHeaderBar

This is the simplest dialog on the application, there was not much to change here. In order to not leave a big amount of unused space on the HeaderBar, we set the guest name as the subtitle. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer

[virt-tools-list] [PATCH virt-viewer 10/10] usb_device_selection: Use GtkHeaderBar

We could get rid of the auxiliary text and present it as the subtitle of the dialog, but this is handled by the widget itself. In this case, all we have to do is to set the "use-headerbar" property, and like other dialogs, the close button is not necessary anymore. Signed-off-by: Ed

[virt-tools-list] [PATCH virt-viewer 09/10] file-transfer-dialog: Use GtkHeaderBar

This dialog now presents the progress as a level bar, and also shows the percentage as on the text. The cancel button is not necessary anymore, because the all transfers are cancelled automatically when the dialog is closed before they finish. Signed-off-by: Eduardo Lima (Etrunko) <e

Re: [virt-tools-list] [PATCH virt-viewer 07/10] iso-dialog: Implement functionality provided by oVirt foreign menu

On 17/01/17 14:01, Christophe Fergeau wrote: > On Fri, Jan 13, 2017 at 07:11:09PM -0200, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> src/remote-viewer-iso-list-dialog.c| 205 >> +

Re: [virt-tools-list] [PATCH virt-viewer 05/10] remote-viewer: Make ovirt-foreign-menu a property

On 17/01/17 14:00, Christophe Fergeau wrote: > On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote: >> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and >> we make it acessible via property to avoid interdependency between >> obje

Re: [virt-tools-list] [PATCH virt-viewer 05/10] remote-viewer: Make ovirt-foreign-menu a property

On 18/01/17 09:53, Eduardo Lima (Etrunko) wrote: > On 17/01/17 14:00, Christophe Fergeau wrote: >> On Fri, Jan 13, 2017 at 07:11:07PM -0200, Eduardo Lima (Etrunko) wrote: >>> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and >>> we make it aces

Re: [virt-tools-list] [PATCH virt-viewer 5/9] ovirt-foreign-menu: Add accessors for current iso and iso list

On 19/01/17 10:55, Christophe Fergeau wrote: > On Wed, Jan 18, 2017 at 12:16:56PM -0200, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> src/ovirt-foreign-menu.c | 11 +-- >> src/ovirt-foreign-menu.

Re: [virt-tools-list] [PATCH virt-viewer 6/9] iso-dialog: Implement functionality provided by oVirt foreign menu

out problems. > Christophe > > On Wed, Jan 18, 2017 at 12:16:57PM -0200, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> src/remote-viewer-iso-list-dialog.c| 204 >>

Re: [virt-tools-list] [PATCH virt-viewer 8/9] Run iso-dialog when 'Change CD' menu is activated

On 19/01/17 11:06, Christophe Fergeau wrote: > On Wed, Jan 18, 2017 at 12:16:59PM -0200, Eduardo Lima (Etrunko) wrote: >> Also makes 'Change CD' menu item a submenu under 'File' toplevel menu >> >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >&

Re: [virt-tools-list] [PATCH virt-viewer 3/9] remote-viewer: Make ovirt-foreign-menu a property

an 18, 2017 at 12:16:54PM -0200, Eduardo Lima (Etrunko) wrote: >> The OvirtForeignMenu pointer is needed by the new ISO list dialog, and >> we make it acessible via property to avoid interdependency between >> objects. >> >> Signed-off-by: Eduardo Lima (Etru

Re: [virt-tools-list] [PATCH virt-viewer 1/9] ovirt-foreign-menu: Set new ISO name using GTask API

On 18/01/17 14:31, Christophe Fergeau wrote: > On Wed, Jan 18, 2017 at 12:16:52PM -0200, Eduardo Lima (Etrunko) wrote: >> This is done with the new ovirt_foreign_menu_set_current_iso_name_async >> function. >> >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@re

Re: [virt-tools-list] [PATCH virt-viewer 2/9] ovirt-foreign-menu: Fetch ISO names using GTask API

On 18/01/17 15:45, Christophe Fergeau wrote: > On Wed, Jan 18, 2017 at 12:16:53PM -0200, Eduardo Lima (Etrunko) wrote: >> Similar to the previous commit, the ISO dialog will fetch the result >> asynchronously, rather than relying on the "notify::files" signal from &

Re: [virt-tools-list] [PATCH virt-viewer 03/10] ovirt-foreign-menu: Fetch ISO names using GTask API

On 17/01/17 13:57, Christophe Fergeau wrote: > On Fri, Jan 13, 2017 at 07:11:05PM -0200, Eduardo Lima (Etrunko) wrote: >> Similar to the previous commit, the ISO dialog will fetch the result >> asynchronously, rather than relying on the "notify::files" signal from &

[virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Fetch ISO names using GTask API

Similar to the previous commit, the ISO dialog will fetch the result asynchronously, rather than relying on the "notify::files" signal from OvirtForeignMenu object. It also enables error to be shown if anything goes wrong. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

Re: [virt-tools-list] [PATCH virt-viewer 05/10] remote-viewer: Make ovirt-foreign-menu a property

On 18/01/17 11:06, Christophe Fergeau wrote: > On Wed, Jan 18, 2017 at 10:56:59AM -0200, Eduardo Lima (Etrunko) wrote: >> On 18/01/17 10:53, Christophe Fergeau wrote: >>> On Wed, Jan 18, 2017 at 10:08:42AM -0200, Eduardo Lima (Etrunko) wrote: >>>> On 18/01/17 09:53

Re: [virt-tools-list] [PATCH virt-viewer 01/10] remote-viewer: Extend #ifdef HAVE_OVIRT block

On 17/01/17 13:51, Christophe Fergeau wrote: > Acked-by: Christophe Fergeau <cferg...@redhat.com> Pushed, thanks > > On Fri, Jan 13, 2017 at 07:11:03PM -0200, Eduardo Lima (Etrunko) wrote: >> The #endif is closing a #ifdef HAVE_OVIRT block, while another one is >

[virt-tools-list] [PATCH virt-viewer 3/9] remote-viewer: Make ovirt-foreign-menu a property

The OvirtForeignMenu pointer is needed by the new ISO list dialog, and we make it acessible via property to avoid interdependency between objects. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 37 + 1 file chang

[virt-tools-list] [PATCH virt-viewer 4/9] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 121 ++ src/remote-viewer-iso-list-dialog.h

[virt-tools-list] [PATCH virt-viewer 1/9] ovirt-foreign-menu: Set new ISO name using GTask API

This is done with the new ovirt_foreign_menu_set_current_iso_name_async function. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 117 ++- src/ovirt-foreign-menu.h | 10 2 files changed, 96 inse

[virt-tools-list] [PATCH virt-viewer 2/9] ovirt-foreign-menu: Fetch ISO names using GTask API

Similar to the previous commit, the ISO dialog will fetch the result asynchronously, rather than relying on the "notify::files" signal from OvirtForeignMenu object. It also enables error to be shown if anything goes wrong. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

[virt-tools-list] [PATCH virt-viewer 9/9] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

[virt-tools-list] [PATCH virt-viewer 5/9] ovirt-foreign-menu: Add accessors for current iso and iso list

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 11 +-- src/ovirt-foreign-menu.h | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 50a8ea6..e2216a2 100644 ---

[virt-tools-list] [PATCH virt-viewer 1/5] ovirt-foreign-menu: Add accessors for current iso and iso list

Also, to keep consistency around the codebase, changed the return value of ovirt_foreign_menu_get_current_iso_name() from char * to gchar *. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 11 +-- src/ovirt-foreign-menu.h | 2 ++ 2 files c

[virt-tools-list] [PATCH virt-viewer 2/5] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 365 + src/remote-viewer-iso-list-dialog.h

[virt-tools-list] [PATCH virt-viewer 4/5] Run ISO dialog when 'Change CD' menu is activated

. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 37 + src/resources/ui/virt-viewer.ui | 19 ++- src/virt-viewer-window.c| 37 + 3 files chang

[virt-tools-list] [PATCH virt-viewer 5/5] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

Re: [virt-tools-list] RFC: time for a 5.0 release ?

On 10/10/16 12:05, Daniel P. Berrange wrote: > On Mon, Oct 10, 2016 at 04:26:29PM +0200, Fabiano Fidêncio wrote: >> On Mon, Oct 10, 2016 at 2:38 PM, Daniel P. Berrange >> wrote: >>> The 4.0 release was in June, and there have not been very many changes >>> since then, but

[virt-tools-list] [PATCH virt-viewer v4 12/12] ovirt-foreign-menu: Fetch ISO names using GTask API

Similar to the previous commit, the ISO dialog will fetch the result asynchronously, rather than relying on the "notify::files" signal from OvirtForeignMenu object. It also enables error to be shown if anything goes wrong. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

[virt-tools-list] [PATCH virt-viewer v4 11/12] ovirt-foreign-menu: Set new ISO name using GTask API

From: Christophe Fergeau <cferg...@redhat.com> This is done with the new ovirt_foreign_menu_set_current_iso_name_async function. Also, an error dialog will be shown in case anything goes wrong with the async method. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

[virt-tools-list] [PATCH virt-viewer v4 06/12] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 106 src/remote-viewer-iso-list-dialog.h

[virt-tools-list] [PATCH virt-viewer v4 05/12] UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/resources/ui/virt-viewer.ui b/src/resources/ui/virt-viewer.ui index 6e3c5ad..af3ae46 100644 --- a/src/res

[virt-tools-list] [PATCH virt-viewer v4 01/12] ovirt-foreign-menu: Remove timer used to refresh iso list

With the new ISO dialog, the user triggers the refresh manually. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-f

[virt-tools-list] [PATCH virt-viewer v4 00/12] Replace oVirt foreign menu with dedicated dialog

Back to work on this feature after some time away. In this version we replace the notify signals with asynchronous callbacks using GTask API. Christophe Fergeau (1): ovirt-foreign-menu: Set new ISO name using GTask API Eduardo Lima (Etrunko) (11): ovirt-foreign-menu: Remove timer used

[virt-tools-list] [PATCH virt-viewer v4 04/12] ovirt-foreign-menu: Notify of new files even if nothing changed

When user presses the Refresh button in ISO dialog, the list is cleared, and currently, the only way it is informed of the new list is by the notify signal. The same applies when an error occurs while trying to change the current ISO. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.

[virt-tools-list] [PATCH virt-viewer v4 03/12] ovirt-foreign-menu: Remove GtkMenu related functions

With this commit, we finish cleaning up ovirt foreign menu code, which only deals with data, leaving the UI bits to be handled properly in the new ISO list dialog. This patch also updates remote-viewer to reflect the change. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

Re: [virt-tools-list] [PATCH virt-viewer v4 00/12] Replace oVirt foreign menu with dedicated dialog

On 11/02/2016 03:20 PM, Christophe Fergeau wrote: > On Wed, Nov 02, 2016 at 06:15:45PM +0100, Christophe Fergeau wrote: >> This does not seem to apply on top of git master. > > Ah, just minor merge conflict in src/Makefile.am, easy to fix locally ;) > The file transfer dialog has been merged

Re: [virt-tools-list] [PATCH virt-viewer v4 11/12] ovirt-foreign-menu: Set new ISO name using GTask API

On 11/01/2016 06:33 PM, Eduardo Lima (Etrunko) wrote: > From: Christophe Fergeau <cferg...@redhat.com> > > This is done with the new ovirt_foreign_menu_set_current_iso_name_async > function. Also, an error dialog will be shown in case anything goes > wrong with the async me

[virt-tools-list] [PATCH virt-viewer] ovirt-foreign-menu: Set new ISO name using GTask API

From: Christophe Fergeau <cferg...@redhat.com> This is done with the new ovirt_foreign_menu_set_current_iso_name_async function. Also, an error dialog will be shown in case anything goes wrong with the async method. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --

[virt-tools-list] [PATCH virt-viewer] Add ovirt_foreign_menu_set_current_iso_name_async

From: Christophe Fergeau <cferg...@redhat.com> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- I tweaked your patch a bit with a proper dialog for showing error if it happens, this is going to be reused for the case of fetching the ISO list as well. --- src/ovirt-fo

[virt-tools-list] [PATCH virt-viewer v4 10/12] iso-dialog: Use header bar for buttons

s gone too. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac | 4 +- src/remote-viewer-iso-list-dialog.c| 31 +-- src/resources/ui/remote-viewer-iso-list.ui | 87 +++--- 3 files changed, 60 insertions(

[virt-tools-list] [PATCH virt-viewer v4 09/12] iso-dialog: Implement functionality provided by oVirt foreign menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c| 180 - src/resources/ui/remote-viewer-iso-list.ui | 5 +- 2 files changed, 181 insertions(+), 4 deletions(-) diff --git a/src/remote-viewer-iso-list-di

[virt-tools-list] [PATCH virt-viewer v4 02/12] ovirt-foreign-menu: Add accessors for current iso and iso list

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 49 ++-- src/ovirt-foreign-menu.h | 5 - 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-

[virt-tools-list] [PATCH virt-viewer 07/10] iso-dialog: Implement functionality provided by oVirt foreign menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-iso-list-dialog.c| 205 - src/resources/ui/remote-viewer-iso-list.ui | 5 +- 2 files changed, 206 insertions(+), 4 deletions(-) diff --git a/src/remote-viewer-iso-list-di

[virt-tools-list] [PATCH virt-viewer 03/10] ovirt-foreign-menu: Fetch ISO names using GTask API

Similar to the previous commit, the ISO dialog will fetch the result asynchronously, rather than relying on the "notify::files" signal from OvirtForeignMenu object. It also enables error to be shown if anything goes wrong. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com>

[virt-tools-list] [PATCH virt-viewer 02/10] ovirt-foreign-menu: Set new ISO name using GTask API

This is done with the new ovirt_foreign_menu_set_current_iso_name_async function. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 117 ++- src/ovirt-foreign-menu.h | 10 2 files changed, 96 inse

[virt-tools-list] [PATCH virt-viewer 04/10] Introduce ISO List dialog

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- po/POTFILES.in | 2 + src/Makefile.am| 3 + src/remote-viewer-iso-list-dialog.c| 106 src/remote-viewer-iso-list-dialog.h

[virt-tools-list] [PATCH virt-viewer 06/10] ovirt-foreign-menu: Add accessors for current iso and iso list

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 9 - src/ovirt-foreign-menu.h | 2 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 6892f0d..e244719 100644 --- a/src

[virt-tools-list] [PATCH virt-viewer 09/10] Run iso-dialog when 'Change CD' menu is activated

Also makes 'Change CD' menu item a submenu under 'File' toplevel menu Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/resources/ui/virt-viewer.ui | 19 ++- src/virt-viewer-window.c| 37 + 2 files chang

[virt-tools-list] [PATCH virt-viewer 08/10] iso-dialog: Use header bar for buttons

s gone too. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac | 4 +- src/remote-viewer-iso-list-dialog.c| 31 +-- src/resources/ui/remote-viewer-iso-list.ui | 87 +++--- 3 files changed, 60 insertions(

[virt-tools-list] [PATCH virt-viewer 00/10] Replace oVirt foreign menu with dedicated dialog

Final version of this series, this time I changed the order of the patches so that the set/get ISO names port to GTask API will come first, and only after that the dialog is introduced. Finally, the last patch will remove the old code. Eduardo Lima (Etrunko) (10): remote-viewer: Extend #ifdef

Re: [virt-tools-list] [PATCH virt-viewer] vnc: Set display as enabled on init

On 29/03/17 07:36, Pavel Grunt wrote: > It will enable some functionality, like zoom. > You could maybe elaborate a bit better, as you are also setting enabled to FALSE it when the session gets disconnected. Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > R

Re: [virt-tools-list] [PATCH virt-viewer] Remove unused virt_viewer_app_set_zoom_level

_set_hotkeys(VirtViewerApp *self, const gchar *hotkeys); > Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com ___ virt-tools-list mailing list virt-tools-lis

Re: [virt-tools-list] [PATCH virt-viewer] virt-viewer: Fix comparison in domain selection

https://twitter.com/codinghorror/status/506010907021828096 Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> On 15/03/17 14:12, Pavel Grunt wrote: > Related: rhbz#1399077 > --- > src/virt-viewer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [virt-tools-list] [PATCH virt-viewer] vnc: Set display as enabled on init

On 04/04/17 08:55, Pavel Grunt wrote: > On Wed, 2017-03-29 at 14:39 -0300, Eduardo Lima (Etrunko) wrote: >> On 29/03/17 07:36, Pavel Grunt wrote: >>> It will enable some functionality, like zoom. >>> >> >> You could maybe elaborate a bit better, as you

Re: [virt-tools-list] [PATCH 1/2] Add missing ifdef HAVE_OVIRT (virt-viewer-window.c)

Hi Uri, Victor has already sent and merged patches fixing those warnings. Can you try with latest upstream if you still have warnings? By the way, I like some parts of your patches a bit better than his, but as the patches are already in, I am not sure if it is worth to change the code once

Re: [virt-tools-list] [virt-viewer v1] Fix implicit fallthrough warning on new gcc

o avoid the following > warnings. Meh, it seems that babysitting compilers are the rule nowadays. :/ Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > > ovirt-foreign-menu.c: In function 'ovirt_foreign_menu_next_async_step': > ovirt-foreign-menu.c:293:12: w

Re: [virt-tools-list] [PATCH virt-viewer 1/6] file: make constructor accept NULL location

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > We are going to make empty/fake VirtViewerFile. > > Signed-off-by: Marc-André Lureau > --- > src/virt-viewer-file.c | 8 +--- > 1 file changed, 5

Re: [virt-tools-list] [PATCH virt-viewer 2/6] session: remove virt_viewer_session_new() declaration

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > The function was removed in commit > 05333f0e93fb988c2fd9302e67671490941aedb0. Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > > Si

Re: [virt-tools-list] [PATCH virt-viewer 5/6] remote-viewer: add a --dbus-controller

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Allow to set connection details via DBus, and add a Connect method. > This is intended to replace the Spice controller. > > Sample usage: > > DEST=`remote-viewer --dbus-controller`

Re: [virt-tools-list] [PATCH virt-viewer 3/6] app: add dbus-ctrl property

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > If the dbus-ctrl property is set, we should call open_uri() without > guri set. > My general feeling is that this patch could be merged with the option parsing on the follow up

Re: [virt-tools-list] [PATCH virt-viewer 4/6] remote-viewer: factor our remote_viewer_initial_connect()

On 23/06/17 12:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > -

[virt-tools-list] [PATCH virt-viewer 2/3] ovirt-foreign-menu: Fetch host, cluster and data center information

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467 https://bugzilla.redhat.com/show_bug.cgi?id=1428401 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 141 +++ 1 file changed, 141 inse

[virt-tools-list] [PATCH virt-viewer 1/3] foreign-menu: Use query for fetching virtual machines

This can save us some bandwidth, as we are searching for the specific virtual machine instead of retrieving the collection with all VMs, and then iterating over the results after the transfer finishes. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu

[virt-tools-list] [PATCH virt-viewer 3/3] foreign-menu: Check if storage domain is active for data center

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am | 2 ++ src/glib-compat.c| 35 +++ src/glib-compat.h| 39 +++ src/ovirt-foreign-menu.c | 22 ++ 4

Re: [virt-tools-list] [PATCH virt-viewer 1/3] foreign-menu: Use query for fetching virtual machines

On 06/08/17 18:53, Pavel Grunt wrote: > Hi, > > 2017-08-04 23:53 GMT+02:00 Eduardo Lima (Etrunko) <etru...@redhat.com > <mailto:etru...@redhat.com>>: > > This can save us some bandwidth, as we are searching for the specific > virtual machine instead of r

Re: [virt-tools-list] [PATCH virt-viewer 2/2] Quit application if in kiosk mode and authentication has been cancelled

On 21/05/17 04:23, Xiaodai Wang wrote: > > - Original Message - >> From: "Victor Toso" <li...@victortoso.com> >> To: "Eduardo Lima (Etrunko)" <etru...@redhat.com> >> Cc: virt-tools-list@redhat.com >> Sent: Saturday, May 20,

[virt-tools-list] [PATCH virt-viewer 1/2] window: Do not show fullscreen toolbar if in kiosk mode

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer-window.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c index 8

[virt-tools-list] [PATCH virt-viewer 2/2] Quit application if in kiosk mode and authentication has been cancelled

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer-app.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index f0fcf21..1975af0 100644 --- a/sr

Re: [virt-tools-list] [virt-viewer v3] spice: do not show error on cancel/close of auth dialog

On 02/06/17 09:57, Pavel Grunt wrote: > On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote: >> From: Victor Toso >> >> Mainly an issue for kiosk mode. >> >> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 >> Signed-off-by: Victor Toso >>

Re: [virt-tools-list] [virt-viewer v3] spice: do not show error on cancel/close of auth dialog

On 05/06/17 09:12, Victor Toso wrote: > On Fri, Jun 02, 2017 at 11:59:04AM -0300, Eduardo Lima (Etrunko) wrote: >> On 02/06/17 09:57, Pavel Grunt wrote: >>> On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote: >>>> From: Victor Toso <m...@victortoso.com> >

Re: [virt-tools-list] [PATCH virt-viewer v2 2/2] kiosk: Show authentication dialog again if cancelled

Pushed, thanks On 31/05/17 10:40, Victor Toso wrote: > Hi, > > On Wed, May 31, 2017 at 10:23:16AM -0300, Eduardo Lima (Etrunko) wrote: >> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 >> >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat

Re: [virt-tools-list] [PATCH virt-viewer v2 1/2] window: Do not show fullscreen toolbar if in kiosk mode

Pushed, thanks. On 31/05/17 10:27, Victor Toso wrote: > On Wed, May 31, 2017 at 10:23:15AM -0300, Eduardo Lima (Etrunko) wrote: >> Regression since commit cc455b7f916110d7cfae6b7af753349e070c9494. >> >> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 >> >

Re: [virt-tools-list] [PATCH virt-viewer] screenshot: Prefill filename suffix

On 08/06/17 10:38, Victor Toso wrote: > Hi, > > On Thu, Jun 08, 2017 at 03:08:02PM +0200, Pavel Grunt wrote: >> Use .png as the default >> >> Related: rhbz#1455832 > > Small clarification of the rationale behind would be good (#1455832) - > Still, not a full solution, is it? > > This will check

Re: [virt-tools-list] [PATCH virt-viewer v3] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

ot;remote-viewer: Show auth dialog on kiosk mode if connecting to ovirt" > > Up to you if you want to change it. I would like to keep "again" word, but I could indeed actually use "auth" instead of "authentication". > > On Thu, Jun 08, 2017 at 06:30:19PM -

Re: [virt-tools-list] [PATCH virt-viewer] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

On 08/06/17 18:00, Eduardo Lima (Etrunko) wrote: > Similar to previous commits, but the case for connecting directly to > ovirt:// URIs was not dealt with. NACK! While it does work for kiosk mode, it will never get past from the dialog in non-kiosk. -- Eduardo de Barros Lima (Etrunko) So

[virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

Similar to previous commits, but the case for connecting directly to ovirt:// URIs was not dealt with. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- v2: Fix loop conditional --- src/remote-viewer.

Re: [virt-tools-list] [PATCH virt-viewer v2] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

On 08/06/17 18:21, Eduardo Lima (Etrunko) wrote: > Similar to previous commits, but the case for connecting directly to > ovirt:// URIs was not dealt with. > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 > > Signed-off-by: Eduardo Lima (Etrunko) <etru...@r

Re: [virt-tools-list] [PATCH virt-viewer] remote-viewer: Show authentication dialog again if in kiosk mode and connecting to ovirt

On 08/06/17 18:19, Victor Toso wrote: > On Thu, Jun 08, 2017 at 06:00:39PM -0300, Eduardo Lima (Etrunko) wrote: >> Similar to previous commits, but the case for connecting directly to >> ovirt:// URIs was not dealt with. >> >> Related: https://bugzilla.redhat.

Re: [virt-tools-list] [virt-viewer v2] vnc: do not show error on cancel/close of auth dialog

more and more complex over time. I did really not see anything wrong in showing the message dialog if authentication is canceled, but now that we have this feature in, we should make the behavior consistent for both SPICE and VNC. Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com&

Re: [virt-tools-list] [remote-viewer v2] remote-viewer-connect: Keep the 'dialog' window on top

On 09/06/17 13:07, Victor Toso wrote: > From: Victor Toso <m...@victortoso.com> > > Otherwise, in kiosk mode, it'll be hidden from user. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1459800 > > Signed-off-by: Victor Toso <victort...@redhat.com>

[virt-tools-list] [PATCH virt-viewer v2 2/2] kiosk: Show authentication dialog again if cancelled

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- v2: Retry authentication dialog if cancelled instead of quitting the application. --- src/virt-viewer-app.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[virt-tools-list] [PATCH virt-viewer v2 1/2] window: Do not show fullscreen toolbar if in kiosk mode

Regression since commit cc455b7f916110d7cfae6b7af753349e070c9494. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer-window.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [virt-tools-list] [PATCH virt-viewer v2 0/4] Support for ovirt data center related functions

On 06/10/17 09:43, Victor Toso wrote: > Ack > Pushed, thanks > - Original Message - >> v2: >> - Check for new functions in configure. >> - Added #ifdef guards for the new functions. >> >> Eduardo Lima (Etrunko) (4): >> configure: chec

[virt-tools-list] [PATCH virt-viewer v2 1/4] configure: check for new functions in libgovirt

Lima (Etrunko) <etru...@redhat.com> --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 9ca6cb6..61374fa 100644 --- a/configure.ac +++ b/configure.ac @@ -190,6 +190,10 @@ AS_IF([test "x$with_ovirt" = "xyes&q

[virt-tools-list] [PATCH virt-viewer v2 4/4] foreign-menu: Check if storage domain is active for data center

. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467 https://bugzilla.redhat.com/show_bug.cgi?id=1428401 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am | 2 ++ src/glib-compat.c| 35 +++ sr

[virt-tools-list] [PATCH virt-viewer v2 0/4] Support for ovirt data center related functions

v2: - Check for new functions in configure. - Added #ifdef guards for the new functions. Eduardo Lima (Etrunko) (4): configure: check for new functions in libgovirt foreign-menu: Use query for fetching virtual machines ovirt-foreign-menu: Fetch host, cluster and data center information

[virt-tools-list] [PATCH virt-viewer v2 3/4] ovirt-foreign-menu: Fetch host, cluster and data center information

with that scenario. We fix this problem by making use of new functions in libgovirt, adding support or hosts, clusters and data centers. Related: https://bugzilla.redhat.com/show_bug.cgi?id=1427467 https://bugzilla.redhat.com/show_bug.cgi?id=1428401 Signed-off-by: Eduardo Lima (Etrunko) <e

[virt-tools-list] [PATCH virt-viewer v2 2/4] foreign-menu: Use query for fetching virtual machines

This can save us some bandwidth, as we are searching for the specific virtual machine instead of retrieving the collection with all VMs, and then iterating over the results after the transfer finishes. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu

Re: [virt-tools-list] [PATCH virt-viewer v2] Fixes to spec file

On 22/11/17 16:35, Christophe Fergeau wrote: > On Wed, Nov 22, 2017 at 04:21:49PM -0200, Eduardo Lima (Etrunko) wrote: >> - Use macros for paths instead of absolute paths. >> - Fix scope of enable_autotools macro to avoid warning during build. >> warning: Macro %ena

[virt-tools-list] [PATCH virt-viewer v3] Fixes to spec file

- Use macros for paths instead of absolute paths. - Remove dangling %{gtk_arg} macro in configure. - Fix scope of enable_autotools macro to avoid warning during build. warning: Macro %enable_autotools defined but not used within scope Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.

[virt-tools-list] [PATCH virt-viewer] doc: Adjust reference to spice-gtk man page for remote-viewer

Similar to last commit, as noticed by reporter in bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1477966 Man page should reference spice-client, not spice-gtk. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- man/remote-viewer.pod | 2 +- 1 file changed, 1 insertion

Re: [virt-tools-list] [PATCH virt-viewer v3] Fixes to spec file

On 27/11/17 07:37, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau <cferg...@redhat.com> Pushed, Thanks. > > On Thu, Nov 23, 2017 at 11:52:53AM -0200, Eduardo Lima (Etrunko) wrote: >> - Use macros for paths instead of absolute paths. >> - Re

<    1   2   3   4   >