Re: [virt-tools-list] [PATCH] fix source name attribute for gluster volumes

2015-01-29 Thread Cole Robinson
Thanks! Pushed now commit e44b95149bdfe83d49b1b6026969fc7304eb1761 Author: Anatoly Belikov wormbl...@gmail.com Date: Tue Jan 27 16:10:12 2015 +0300 devicedisk: fix source name attribute for gluster volumes - Cole On 01/29/2015 11:19 AM, Anatoly Belikov wrote: Ok, here it is.

Re: [virt-tools-list] [PATCH] fix source name attribute for gluster volumes

2015-01-29 Thread Anatoly Belikov
Ok, here it is. 2015-01-29 18:26 GMT+03:00 Cole Robinson crobi...@redhat.com: Ah okay, that pool output explains things, I didn't realize there could be a dir path that's more than just '/' Can you provide an example volume XML from that pool as well? With that I will apply your patch and

Re: [virt-tools-list] [PATCH] fix source name attribute for gluster volumes

2015-01-28 Thread Anatoly Belikov
I got this error when i made few subdirectories in gluster volume, and changed dir path / in libvirt pool xml accordingly. Here is command line and debug output in attached file: python /usr/share/virt-manager/virt-install --name=vm3vv --disk vol=gluster-pool/vm3vv.qcow2,bus=ide,cache=none

Re: [virt-tools-list] [PATCH] fix source name attribute for gluster volumes

2015-01-27 Thread Cole Robinson
On 01/27/2015 01:52 PM, Cole Robinson wrote: On 01/27/2015 08:10 AM, anatoly.belikov.wormbl...@gmail.com wrote: From: Anatoly Belikov wormbl...@gmail.com --- virtinst/devicedisk.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/virtinst/devicedisk.py

Re: [virt-tools-list] [PATCH] fix source name attribute for gluster volumes

2015-01-27 Thread Cole Robinson
On 01/27/2015 08:10 AM, anatoly.belikov.wormbl...@gmail.com wrote: From: Anatoly Belikov wormbl...@gmail.com --- virtinst/devicedisk.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py index ac03716..df2befc 100644

[virt-tools-list] [patch] fix source name attribute for gluster volumes

2015-01-27 Thread Anatoly . Belikov . wormblood
Hello!! I found that virt-install truncates disk path for gluster volumes. Xml always looks like this: disk type='network' device='disk' source protocol='gluster' name='gluster_volname/disk_filename' /disk Instead of disk filename should be path relative to gluster volume root.

[virt-tools-list] [PATCH] fix source name attribute for gluster volumes

2015-01-27 Thread Anatoly . Belikov . wormblood
From: Anatoly Belikov wormbl...@gmail.com --- virtinst/devicedisk.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py index ac03716..df2befc 100644 --- a/virtinst/devicedisk.py +++ b/virtinst/devicedisk.py @@ -627,7 +627,11