Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-07 Thread Eduardo Lima (Etrunko)
On 12/07/2015 10:43 AM, Eduardo Lima (Etrunko) wrote: > On 12/02/2015 11:25 PM, Jim Fehlig wrote: >> On 12/02/2015 04:15 AM, Daniel P. Berrange wrote: >>> Yep, we need to agree which min platform we're targetting. It is nice >>> to see RHEL7 rebasing GTK, as that makes life easier. We should not

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-07 Thread Jim Fehlig
Eduardo Lima (Etrunko) wrote: > On 12/02/2015 11:25 PM, Jim Fehlig wrote: >> On 12/02/2015 04:15 AM, Daniel P. Berrange wrote: >>> Yep, we need to agree which min platform we're targetting. It is nice >>> to see RHEL7 rebasing GTK, as that makes life easier. We should not >>> only consider RHEL

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-07 Thread Eduardo Lima (Etrunko)
On 12/02/2015 11:25 PM, Jim Fehlig wrote: > On 12/02/2015 04:15 AM, Daniel P. Berrange wrote: >> Yep, we need to agree which min platform we're targetting. It is nice >> to see RHEL7 rebasing GTK, as that makes life easier. We should not >> only consider RHEL though. It would be desirable if

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-03 Thread Eduardo Lima (Etrunko)
On 11/30/2015 07:29 PM, Jonathon Jongsma wrote: >> - All Window objects must be associated with the Application, and with >> this, there is no need to emit our own 'window-added' signal, it will >> be done by GtkApplication by the time gtk_application_add_window() is >> called. The

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-03 Thread Eduardo Lima (Etrunko)
On 12/02/2015 09:21 AM, Christophe Fergeau wrote: > On Mon, Nov 30, 2015 at 03:29:37PM -0600, Jonathon Jongsma wrote: >>> +app_class->add_main_options = remote_viewer_add_main_options; >>> +app_class->handle_options = remote_viewer_handle_options; >>> +app_class->version_string =

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-03 Thread Daniel P. Berrange
On Thu, Dec 03, 2015 at 12:17:41PM -0200, Eduardo Lima (Etrunko) wrote: > On 12/02/2015 09:09 AM, Christophe Fergeau wrote: > > Hey, > > > > On Fri, Nov 27, 2015 at 05:24:00PM -0200, Eduardo Lima (Etrunko) wrote: > >> Most of this patch consists in code being shuffled around to fit the > >>

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-03 Thread Eduardo Lima (Etrunko)
On 12/02/2015 09:09 AM, Christophe Fergeau wrote: > Hey, > > On Fri, Nov 27, 2015 at 05:24:00PM -0200, Eduardo Lima (Etrunko) wrote: >> Most of this patch consists in code being shuffled around to fit the >> expected flow while using the new APIs. I tried my best to make this >> patch the less

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-03 Thread Daniel P. Berrange
On Wed, Dec 02, 2015 at 06:25:12PM -0700, Jim Fehlig wrote: > On 12/02/2015 04:15 AM, Daniel P. Berrange wrote: > > Yep, we need to agree which min platform we're targetting. It is nice > > to see RHEL7 rebasing GTK, as that makes life easier. We should not > > only consider RHEL though. It would

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-02 Thread Christophe Fergeau
On Mon, Nov 30, 2015 at 03:29:37PM -0600, Jonathon Jongsma wrote: > > +app_class->add_main_options = remote_viewer_add_main_options; > > +app_class->handle_options = remote_viewer_handle_options; > > +app_class->version_string = remote_viewer_version_string; > > + > > #ifdef

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-02 Thread Christophe Fergeau
Hey, On Fri, Nov 27, 2015 at 05:24:00PM -0200, Eduardo Lima (Etrunko) wrote: > Most of this patch consists in code being shuffled around to fit the > expected flow while using the new APIs. I tried my best to make this > patch the less intrusive as possible. Main changes are: > > - VirtViewerApp

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-02 Thread Daniel P. Berrange
On Wed, Dec 02, 2015 at 12:09:56PM +0100, Christophe Fergeau wrote: > Hey, > > On Fri, Nov 27, 2015 at 05:24:00PM -0200, Eduardo Lima (Etrunko) wrote: > > Most of this patch consists in code being shuffled around to fit the > > expected flow while using the new APIs. I tried my best to make this

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-12-02 Thread Jim Fehlig
On 12/02/2015 04:15 AM, Daniel P. Berrange wrote: > Yep, we need to agree which min platform we're targetting. It is nice > to see RHEL7 rebasing GTK, as that makes life easier. We should not > only consider RHEL though. It would be desirable if someone can provide > a list of GTK versions in

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-11-30 Thread Jonathon Jongsma
On Fri, 2015-11-27 at 17:24 -0200, Eduardo Lima (Etrunko) wrote: > Most of this patch consists in code being shuffled around to fit the > expected flow while using the new APIs. I tried my best to make this > patch the less intrusive as possible. Main changes are: > > - VirtViewerApp is now a

[virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

2015-11-27 Thread Eduardo Lima (Etrunko)
Most of this patch consists in code being shuffled around to fit the expected flow while using the new APIs. I tried my best to make this patch the less intrusive as possible. Main changes are: - VirtViewerApp is now a subclass of GtkApplication Also, some mainloop calls were replaced, as