Re: [virt-tools-list] [PATCH 7/7] Make GApplication port compatible with older glib

2015-12-18 Thread Christophe Fergeau
On Thu, Dec 17, 2015 at 09:19:39PM +0100, Fabiano Fidêncio wrote: > In one hand having all the code in a way that we can just drop the > compat functions when SLES starts using GLib 2.40 may be really > handful. On the other hand, as pointed by Jonathon and Daniel, it's an > awful lot of code

Re: [virt-tools-list] [PATCH 7/7] Make GApplication port compatible with older glib

2015-12-17 Thread Fabiano Fidêncio
On Mon, Dec 14, 2015 at 10:42 PM, Jonathon Jongsma wrote: > On Fri, 2015-12-11 at 17:11 +, Daniel P. Berrange wrote: >> On Fri, Dec 11, 2015 at 02:40:36PM -0200, Eduardo Lima (Etrunko) wrote: >> > Signed-off-by: Eduardo Lima (Etrunko) >> > --- >> >

Re: [virt-tools-list] [PATCH 7/7] Make GApplication port compatible with older glib

2015-12-16 Thread Eduardo Lima (Etrunko)
On 12/14/2015 07:42 PM, Jonathon Jongsma wrote: > On Fri, 2015-12-11 at 17:11 +, Daniel P. Berrange wrote: >> On Fri, Dec 11, 2015 at 02:40:36PM -0200, Eduardo Lima (Etrunko) wrote: >>> Signed-off-by: Eduardo Lima (Etrunko) >>> --- >>> configure.ac | 2 +- >>>

Re: [virt-tools-list] [PATCH 7/7] Make GApplication port compatible with older glib

2015-12-14 Thread Jonathon Jongsma
On Fri, 2015-12-11 at 17:11 +, Daniel P. Berrange wrote: > On Fri, Dec 11, 2015 at 02:40:36PM -0200, Eduardo Lima (Etrunko) wrote: > > Signed-off-by: Eduardo Lima (Etrunko) > > --- > > configure.ac | 2 +- > > src/remote-viewer.c| 9 + > >

Re: [virt-tools-list] [PATCH 7/7] Make GApplication port compatible with older glib

2015-12-11 Thread Daniel P. Berrange
On Fri, Dec 11, 2015 at 02:40:36PM -0200, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > configure.ac | 2 +- > src/remote-viewer.c| 9 + > src/virt-glib-compat.c | 29 + >