Radostin Stoyanov (5):
pylint: Use pylint.lint module
pylint: Silence inconsistent-return-statements
pylint: Resolve logging-not-lazy
pylint: Resolve consider-using-enumerate
pycodestyle: Use module instead of executable
setup.py| 33 -
Use enumerate instead of iterating with range and len.
This pylint message is emitted when code that iterates with range and
len is encountered. Such code can be simplified by using the enumerate
built-in. [1]
In addition, remove some unused variables to avoid warnings
`unused-argument` and `redef
A new Python checker was added to warn about "inconsistent return
statements" [1]. A function or a method has inconsistent return
statements if it returns both explicit and implicit values.
[1] https://pylint.readthedocs.io/en/latest/whatsnew/1.8.html
Signed-off-by: Radostin Stoyanov
---
tests/
The `pycodestyle-3` executable is provided by the
`python3-pycodestyle` rpm package.
On Debian the corresponding executable is called `pycodestyle3`.
Arch Linux uses Python 3 by default and `python2-pycodestyle`
package is used for the py2 version.
To get around this inconsistency, import the `pyc
The `pylint-3` executable is provided by the python3-pylint rpm
package on Fedora.
For Debian the equivalent is `pylint3`.
On Arch Linux the default version of Python is 3.
Pylint lints for the version of Python it is running. Instead of
spawning an executable, import the `pylint.lint` module and
A new Python checker was added to warn about using a + operator inside
call of logging methods when one of the operands is a literal string.
https://pylint.readthedocs.io/en/latest/whatsnew/1.8.html
Signed-off-by: Radostin Stoyanov
---
tests/clitest.py | 2 +-
virtManager/addhardware.
Signed-off-by: Radostin Stoyanov
---
virtinst/progress.py | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/virtinst/progress.py b/virtinst/progress.py
index 29bff358..4284f854 100644
--- a/virtinst/progress.py
+++ b/virtinst/progress.py
@@ -253,10 +253,8 @@ class T
On 03/02/2018 07:27 AM, Dylan Stephano-Shachter wrote:
> I have added a feature to show a VM's first IP address next to the VM state
> (Running, etc.). This feature can be toggled in the preferences menu and is
> disabled by default. It uses the qemu-guest agent to query the IP address.
>
> Dyla
That is interesting. Could you possibly run virt-manager with --debug and
send me any stacktraces you see?
On Mar 2, 2018 7:55 AM, "Michal Privoznik" wrote:
> On 03/02/2018 07:27 AM, Dylan Stephano-Shachter wrote:
> > I have added a feature to show a VM's first IP address next to the VM
> state
