[virt-tools-list] [vhostmd] configure: fix logic in init script check

2018-06-11 Thread Jim Fehlig
The logic introduced in commit d1276646to check for init script type is a bit flawed. If the init script type is specified, init_systemv is always set to 'yes', even when '--with-init-script=systemd'. Split the logic to only check for init script type when '--with-init-script=check'.

Re: [virt-tools-list] vhostmd - virtio channel support

2018-06-11 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 12:01:48PM -0600, Jim Fehlig wrote: > On 06/08/2018 02:30 AM, Daniel P. Berrangé wrote: > > On Thu, Jun 07, 2018 at 04:23:32PM -0600, Jim Fehlig wrote: > > > On 06/07/2018 09:42 AM, Trapp, Michael wrote: > > > > I fully understand the requirements regarding coding style and

Re: [virt-tools-list] virt-bootstrap: libvirt and SELinux issues

2018-06-11 Thread Richard W.M. Jones
(Adding virt-tools-list) On Fri, Jun 08, 2018 at 02:20:22PM +0200, Timothée Floure wrote: > Hello, > > I'm trying to package virt-bootstrap [0], but various tests fail due to > SELinux. I know some selinux basics from redhat's selinux manual [1], > but am unsure about how to approach the issue.

Re: [virt-tools-list] virt-bootstrap: libvirt and SELinux issues

2018-06-11 Thread Fabiano Fidêncio
So, several things ... On Mon, Jun 11, 2018 at 4:41 PM, Richard W.M. Jones wrote: > (Adding virt-tools-list) > > On Fri, Jun 08, 2018 at 02:20:22PM +0200, Timothée Floure wrote: >> Hello, >> >> I'm trying to package virt-bootstrap [0], but various tests fail due to >> SELinux. I know some

Re: [virt-tools-list] virt-bootstrap: libvirt and SELinux issues

2018-06-11 Thread Fabiano Fidêncio
On Mon, Jun 11, 2018 at 5:34 PM, Fabiano Fidêncio wrote: > So, several things ... > > On Mon, Jun 11, 2018 at 4:41 PM, Richard W.M. Jones wrote: >> (Adding virt-tools-list) >> >> On Fri, Jun 08, 2018 at 02:20:22PM +0200, Timothée Floure wrote: >>> Hello, >>> >>> I'm trying to package

[virt-tools-list] [PATCH virt-manager] cli: add codec support

2018-06-11 Thread Anya Harter
Add codec support to virt-install so that it can accommodate multiple instances of codec configuration. The commandline argument: --sound codec0.type=micro,codec1.type=duplex,codec2.type=output maps to the sound XML below: Signed-off-by: Anya Harter ---

Re: [virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

2018-06-11 Thread Stefan Berger
On 06/11/2018 11:54 AM, Cole Robinson wrote: On 06/08/2018 05:42 PM, Stefan Berger wrote: Show the TPM device model and allow updating it. If a TPM 1.2 has been chosen, we only allow the TIS interface to be selected. In case of a TPM 2.0 we also enable the choice of the CRB interface. Patches

Re: [virt-tools-list] [PATCH virt-manager] cli: Add --disk geometry attribute options

2018-06-11 Thread Cole Robinson
On 06/07/2018 11:29 AM, Anya Harter wrote: > Attribute options are: > - geometry.cyls=W > - geometry.heads=X > - geometry.secs=Y > - geometry.trans=Z > > This maps to disk XML like: > > > > > > Signed-off-by: Anya Harter Thanks, pushed now - Cole

Re: [virt-tools-list] [PATCH virt-manager] cli: add codec support

2018-06-11 Thread Cole Robinson
Thanks, I pushed with the following changes: - Add --sound to the title to make it more clear On 06/11/2018 11:48 AM, Anya Harter wrote: > Add codec support to virt-install so that it can accommodate > multiple instances of codec configuration. > > The commandline argument: > > --sound

Re: [virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

2018-06-11 Thread Cole Robinson
On 06/11/2018 12:00 PM, Stefan Berger wrote: > On 06/11/2018 11:54 AM, Cole Robinson wrote: >> On 06/08/2018 05:42 PM, Stefan Berger wrote: >>> Show the TPM device model and allow updating it. If a TPM 1.2 has been >>> chosen, we only allow the TIS interface to be selected. In case of a >>> TPM