Re: [virt-tools-list] [virt-manager PATCH] Install the AppStream file to the canonical location

2020-01-14 Thread Cole Robinson
On 1/6/20 8:43 AM, Pino Toscano wrote: > The canonical location for AppStream XML files has been changed to > /usr/share/metainfo four years ago at least, with /usr/share/appdata > left as legacy location. It is time to switch to the right location. > > Signed-off-by: Pino Toscano Reviewed-by:

Re: [virt-tools-list] [virt-manager PATCH] Avoid string puzzle

2020-01-14 Thread Cole Robinson
On 1/6/20 8:29 AM, Pino Toscano wrote: > Do not join two parts of sentences together, because it is problematic > to translate. Instead, use a different sentence depending on the > condition. > > Fixes commit d52c9d1ffa2d8c204fbb2a714f89b007fa6227ec. > > Signed-off-by: Pino Toscano

Re: [virt-tools-list] [PATCH] virtManager: Folder sharing implementation for SPICE session

2020-01-14 Thread Cole Robinson
On 12/28/19 7:12 AM, Jitao Lu wrote: > * This implements folder sharing for the built-in Spice client, tested >working with Win10 guest. > * The basic idea is taken from virt-viewer. > > Signed-off-by: Jitao Lu > --- > Feel free to improve the patch! > Nice work! This looks pretty good.

[virt-tools-list] [virt-manager PATCH v2] details: Fix showing the firmware type in case of firmware auto selection

2020-01-14 Thread Lin Ma
For a shutoff VM, If user select uefi firmware auto selection, e.g. ... Its firmware information is set to 'BIOS' in details, This is incorrect. This fixes it. Signed-off-by: Lin Ma --- virtManager/details/details.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git