Re: [virt-tools-list] [PATCH 1/2] session: Only create a hashtable if apply_monitor_geometry class exists

ACK Although I think you could add a description for this patch in the message a memory leak on error path. On 10/21/2015 11:23 AM, Fabiano Fidêncio wrote: > Related: rhbz#1267184 > --- > src/virt-viewer-session.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

[virt-tools-list] [PATCH 1/5] Call intltoolize after autoreconf

' With this patch, the error is gone. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index b8d3c4d..a688ad4 100755 --- a/autogen.sh +++ b/autogen.sh @@ -27,8 +27,8 @@ fi # exists

[virt-tools-list] Some cosmetic fixes

While working on adding support to GtkApplication for virt-viewer and remote-viewer, I fixed some small things. I figured it was time to flush them to avoid those to pile up. Regards, Eduardo -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com

[virt-tools-list] [PATCH 5/5] Remove useless {get, set}_property functions

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/virt-viewer.c b/src/virt-viewer.c index dd8dbba..10f624d 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -74,26 +74,6 @@

[virt-tools-list] [PATCH 2/5] Fix MAINTAINERCLEANFILES variable

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- man/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/Makefile.am b/man/Makefile.am index 6ee3116..39b6019 100644 --- a/man/Makefile.am +++ b/man/Makefile.am @@ -10,7 +10,7 @@ EXTR

[virt-tools-list] [PATCH 4/5] Move declaration to the beginning of the file

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/virt-viewer.c b/src/virt-viewer.c index ca264c8..dd8dbba 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -71,6 +71,7 @@

Re: [virt-tools-list] [PATCH 2/2] Fix spice includes

On 11/11/2015 05:11 AM, Pavel Grunt wrote: > Hi Eduardo, > > these warnings were introduced after spice-gtk v0.30 release, virt-viewer > currently depends on spice-gtk v0.29.35. You can make the code conditional or > wait for the spice-gtk v0.31 release. > Alright, I guess it is better to wait

[virt-tools-list] [PATCH 1/2] Remove unused 'window-removed' signal

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer-app.c | 14 -- src/virt-viewer-app.h | 1 - 2 files changed, 15 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 653b30c..b14b509 100644 --- a/src/virt-viewer-app.c +++

[virt-tools-list] [PATCH virt-viewer 0/2] More cleanups

Here are a couple more clean-up patches I had on my staging area that I think could be merged as they are independent of any feature. Please take a look. Regards, Eduardo Eduardo Lima (Etrunko) (2): Remove unused 'window-removed' signal Fix spice includes src/remote-viewer-main.c

[virt-tools-list] [PATCH 2/2] Fix spice includes

[-Wcpp] Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-main.c| 2 +- src/virt-viewer-display-spice.c | 2 +- src/virt-viewer-display-spice.h | 3 +-- src/virt-viewer-main.c | 2 +- src/virt-viewer-session-spice.c | 5 + src/virt-viewer-sessio

Re: [virt-tools-list] Some cosmetic fixes

On 02/11/15 04:26, Fabiano Fidêncio wrote: > Hey, > > On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko) > <etru...@redhat.com> wrote: >> While working on adding support to GtkApplication for virt-viewer and >> remote-viewer, I fixed some small things. I figure

Re: [virt-tools-list] [PATCH 1/5] Call intltoolize after autoreconf

On 02/11/15 04:08, Fabiano Fidêncio wrote: > Hey! > > On Thu, Oct 29, 2015 at 9:40 PM, Eduardo Lima (Etrunko) > <etru...@redhat.com> wrote: >> After a calling 'git clean -d -x -f' I got this error: >> >> ln: failed to create symbolic link ‘m4/intltool.m4’:

Re: [virt-tools-list] [PATCH 3/5] Update gitignore

On 02/11/15 08:36, Christophe Fergeau wrote: > On Thu, Oct 29, 2015 at 06:40:38PM -0200, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> Makefile.am | 5 + >> git.mk | 2 +- >> m4/.

Re: [virt-tools-list] [PATCH v2 0/6] [virt-viewer] Some cosmetic fixes

Daniel, On 11/05/2015 12:27 PM, Daniel P. Berrange wrote: > On Wed, Nov 04, 2015 at 12:32:41PM -0200, Eduardo Lima (Etrunko) wrote: >> Resend of my cleanup series, please take a look. In this new version, >> I have found what was causing the errors running autogen.sh and updated

Re: [virt-tools-list] [PATCH 3/5] Update gitignore

On 11/03/2015 10:57 AM, Christophe Fergeau wrote: > Hey, > > On Tue, Nov 03, 2015 at 09:38:24AM -0200, Eduardo Lima (Etrunko) wrote: >> >> Yes, you can find those in the final Makefile, but test-driver is the >> only one missing. Maybe a bug in aut

[virt-tools-list] [PATCH 4/6] Update MAINTAINERCLEANFILES variables

Makefile.am: Use helper variables from git.mk man/Makefile.am: This should be $(dist_man_MANS) instead of $(man_MANS) Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- Makefile.am | 18 +++--- man/Makefile.am | 2 +- 2 files changed, 4 insertions(+), 16 del

[virt-tools-list] [PATCH 3/6] Update git.mk from latest upstream version

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- git.mk | 221 - 1 file changed, 178 insertions(+), 43 deletions(-) diff --git a/git.mk b/git.mk index 0b26b23..bd39ae1 100644 --- a/git.mk +++ b/git.mk @@ -1,14

[virt-tools-list] [PATCH 5/6] Move declaration to the beginning of the file

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/virt-viewer.c b/src/virt-viewer.c index ca264c8..dd8dbba 100644 --- a/src/virt-viewer.c +++ b/src/virt-viewer.c @@ -71,6 +71,7 @@

[virt-tools-list] [PATCH 2/6] Call intltoolize after autoreconf

'/usr/share/aclocal/intltool.m4' to 'm4/intltool.m4' The problem is that intltoolize requires te m4/ directory to be present, and this directory is actually created by running autoreconf, so it should be called before intltoolize. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.

Re: [virt-tools-list] [PATCH 1/5] Call intltoolize after autoreconf

On 04/11/15 11:39, Fabiano Fidêncio wrote: > On Tue, Nov 3, 2015 at 3:20 PM, Fabiano Fidêncio <fiden...@redhat.com> wrote: >> On Tue, Nov 3, 2015 at 12:14 PM, Eduardo Lima (Etrunko) >> <etru...@redhat.com> wrote: >>> On 02/11/15 04:08, Fabiano Fidêncio wrote

[virt-tools-list] [PATCH v2 0/6] [virt-viewer] Some cosmetic fixes

Resend of my cleanup series, please take a look. In this new version, I have found what was causing the errors running autogen.sh and updated git.mk from upstream. Eduardo Lima (Etrunko) (6): Remove m4/.gitignore file Call intltoolize after autoreconf Update git.mk from latest upstream

[virt-tools-list] [PATCH 1/6] Remove m4/.gitignore file

All .gitignore files are handled by git.mk and should not be part of the repository. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- m4/.gitignore | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 m4/.gitignore diff --git a/m4/.gitignore b/m4/.git

[virt-tools-list] [PATCH 4/4] Port to GtkApplicationWindow API's

, in a following patch. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer-app.c| 1 - src/virt-viewer-window.c | 57 --- src/virt-viewer.xml | 416 +++ 3 files changed, 234 insertions(+), 240 deletions(-)

[virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

e time gtk_application_add_window() is called. The 'window-removed' signal has also been removed, as it was not being used anyway. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer-main.c | 122 +- src/remote-viewer.

[virt-tools-list] [PATCH 1/4] Drop support to gtk2

From: Fabiano Fidêncio The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. --- configure.ac | 39 +++

[virt-tools-list] [PATCH 2/4] Move variable declaration to the top of the function

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-viewer.c index 8e4754f..3f530a3 100644 --- a/src/remote-viewer.c +++ b/src/remote-viewer.c @@ -

[virt-tools-list] [PATCH virt-viewer 0/4] Port virt-viewer to GtkApplication APIs

branch in my github repository, in case you are interested in trying it easier, without the need to apply the patches on your tree. http://github.com/etrunko/virt-viewer Regards, Eduardo. Eduardo Lima (Etrunko) (3): Move variable declaration to the top of the function Port to GtkApplication API's

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

On 12/07/2015 10:43 AM, Eduardo Lima (Etrunko) wrote: > On 12/02/2015 11:25 PM, Jim Fehlig wrote: >> On 12/02/2015 04:15 AM, Daniel P. Berrange wrote: >>> Yep, we need to agree which min platform we're targetting. It is nice >>> to see RHEL7 rebasing GTK, as that m

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

On 11/30/2015 07:29 PM, Jonathon Jongsma wrote: >> - All Window objects must be associated with the Application, and with >> this, there is no need to emit our own 'window-added' signal, it will >> be done by GtkApplication by the time gtk_application_add_window() is >> called. The

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

On 12/02/2015 09:21 AM, Christophe Fergeau wrote: > On Mon, Nov 30, 2015 at 03:29:37PM -0600, Jonathon Jongsma wrote: >>> +app_class->add_main_options = remote_viewer_add_main_options; >>> +app_class->handle_options = remote_viewer_handle_options; >>> +app_class->version_string =

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

On 12/02/2015 09:09 AM, Christophe Fergeau wrote: > Hey, > > On Fri, Nov 27, 2015 at 05:24:00PM -0200, Eduardo Lima (Etrunko) wrote: >> Most of this patch consists in code being shuffled around to fit the >> expected flow while using the new APIs. I tried my best to make t

Re: [virt-tools-list] [PATCH 4/4] Port to GtkApplicationWindow API's

On 12/01/2015 03:17 PM, Jonathon Jongsma wrote: > Hmm, I don't quite understand most of these changes. > > Why are you removing the window from the xml file instead of just changing the > 'class' attribute to GtkApplicationWindow? (Of course, we can't set the > 'application' property of the

Re: [virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

On 12/02/2015 11:25 PM, Jim Fehlig wrote: > On 12/02/2015 04:15 AM, Daniel P. Berrange wrote: >> Yep, we need to agree which min platform we're targetting. It is nice >> to see RHEL7 rebasing GTK, as that makes life easier. We should not >> only consider RHEL though. It would be desirable if

[virt-tools-list] [PATCH 2/7] Minor code cleanups

- Reuse #ifdef HAVE_SPICE_GTK block for include. - Move declaration of vfunc together with others of the same class. - Move variable declaration to the top of the function. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 13 +++-- 1 file chan

[virt-tools-list] [PATCH 5/7] Backport GVariantDict code from glib 2.40

Same case as last GApplication patch, but kept split for easier understanding. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-glib-compat.c | 204 + src/virt-glib-compat.h | 32 2 files changed, 236 inse

[virt-tools-list] [PATCH 6/7] Adapt glib code to build out of the tree

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-glib-compat.c | 97 +++--- 1 file changed, 68 insertions(+), 29 deletions(-) diff --git a/src/virt-glib-compat.c b/src/virt-glib-compat.c index a61a3a6..0118e45 100644 ---

[virt-tools-list] [PATCH 3/7] Port to GtkApplication API's

emoved' signals, as those will be emited by GtkApplication whenever gtk_application_add_window() and gtk_application_remove_window() are called. Also, 'window-removed' was not being used anywhere. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac |

[virt-tools-list] [PATCH 4/7] Backport GApplication code from glib 2.40

Ideally, glib was required to be at least 2.40.0, but due to the fact that SLES still uses 2.38, we need to backport the code that is available only in glib version 2.40.0 onwards. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-glib-compat.c

Re: [virt-tools-list] [PATCH 3/7] Port to GtkApplication API's

Hi Jonathon, It seems I got a bit lost with the all comments on the previous series and some of them became were not addressed. Once again, thanks for the review. My comments follow inline. I am working on the new version of this series. On 12/14/2015 08:46 PM, Jonathon Jongsma wrote: >> @@

Re: [virt-tools-list] [PATCH 7/7] Make GApplication port compatible with older glib

On 12/14/2015 07:42 PM, Jonathon Jongsma wrote: > On Fri, 2015-12-11 at 17:11 +, Daniel P. Berrange wrote: >> On Fri, Dec 11, 2015 at 02:40:36PM -0200, Eduardo Lima (Etrunko) wrote: >>> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >>> ---

[virt-tools-list] [PATCH 1/7] Drop support to gtk2

From: Fabiano Fidêncio The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. --- configure.ac | 39 +++

[virt-tools-list] [PATCH v2 0/7] Port to GtkApplication API's

are the adaptations of the glib code to build outside of the tree and integrate with virt-viewer. Eduardo Lima (Etrunko) (6): Minor code cleanups Port to GtkApplication API's Backport GApplication code from glib 2.40 Backport GVariantDict code from glib 2.40 Adapt glib code to build out of the tree

Re: [virt-tools-list] [PATCH virt-viewer 0/4] Port virt-viewer to GtkApplication APIs

On 11/30/2015 05:44 PM, Jonathon Jongsma wrote: > On Fri, 2015-11-27 at 17:23 -0200, Eduardo Lima (Etrunko) wrote: >> The subject says it all, and you will find more details in each commit >> message. Unfortunately I was not able to test some options on >> remote-vie

Re: [virt-tools-list] [virt-viewer 3/5] app: Set the resource base path

On 06/14/2016 06:40 PM, Fabiano Fidêncio wrote: > GApplication's resource base path is based on the application-id, for > instamce: type (instance) > - virt-viewer's resource base path: /org/virt-manager/virt-viewer, as >the virt-viewer's application id is: org.virt-manager.virt-viewer. >

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

This is not actually necessary as of C99. You only need to initialize any field of a structure to get all other fields initialized too. On 06/22/2016 03:17 AM, Pavel Grunt wrote: > --- > src/virt-viewer-display-spice.c | 2 +- > src/virt-viewer-display-vnc.c | 2 +- > src/virt-viewer-window.c

Re: [virt-tools-list] [virt-viewer 2/5] remote-viewer: Remove unneeded g_application_hold() call

On 06/14/2016 06:40 PM, Fabiano Fidêncio wrote: > This call was added as hack during the GApplication's port, as the > remote-viewer window was closed as soon as the connection happened. > > This behaviour hapened because we didn't chain-up to the parent's > window_added() method, which already

Re: [virt-tools-list] [virt-viewer 0/5] Preparing the ground for UI changes

On 06/15/2016 07:20 PM, Jim Fehlig wrote: > On 06/15/2016 06:42 AM, Pavel Grunt wrote: >> Hi, >> >> On Tue, 2016-06-14 at 23:40 +0200, Fabiano Fidêncio wrote: >>> These small series has as objective start "preparing the ground" for >>> the work Sagar Huge has been done on re-design/re-write

Re: [virt-tools-list] [virt-viewer 2/2] window: Replace autoDrawer with native Gtk widgets

On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote: > diff --git a/src/view/virt-viewer-timed-revealer.c > b/src/view/virt-viewer-timed-revealer.c > new file mode 100644 > index 000..bba363c > --- /dev/null > +++ b/src/view/virt-viewer-timed-revealer.c > @@ -0,0 +1,224 @@ > +/* > + * Virt

Re: [virt-tools-list] [virt-viewer 2/2] window: Replace autoDrawer with native Gtk widgets

On 06/21/2016 05:50 PM, Fabiano Fidêncio wrote: > On Tue, Jun 21, 2016 at 10:39 PM, Eduardo Lima (Etrunko) > <etru...@redhat.com> wrote: >> On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote: >>> GtkRevealer was intrudced in Gtk+ 3.10 and, combined with Gtk Overlay >&

Re: [virt-tools-list] [virt-viewer 2/2] window: Replace autoDrawer with native Gtk widgets

On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote: > GtkRevealer was intrudced in Gtk+ 3.10 and, combined with Gtk Overlay > (intoduced in Gtk+ 3.2), can provide a more sustainably implementation > of the AutoDrawer functionality. > > This approach is completely based on the approach taken by

Re: [virt-tools-list] [virt-viewer 1/2] window, util: Fix resource path for icons

On 06/21/2016 05:04 PM, Fabiano Fidêncio wrote: > Since commit 1f6f1a48 the resource path for icons has been broken. > The reason is that when moving the .ui files to $(srcdir)/resources/ui, > the define used for the resources was changed to reflect the new > directory. However, this change wasn't

Re: [virt-tools-list] [virt-viewer v2] util: Fix resource path

t-viewer-util.c > @@ -50,8 +50,9 @@ virt_viewer_error_quark(void) > GtkBuilder *virt_viewer_util_load_ui(const char *name) > { > GtkBuilder *builder; > -gchar *resource = g_strdup_printf("%s/%s", > + gchar *resource = g_strdup_printf("%s/%s/%s", Minor: &quo

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On 06/22/2016 05:16 PM, Pavel Grunt wrote: > On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote: >> This is not actually necessary as of C99. You only need to initialize >> any field of a structure to get all other fields initialized too. > > yes, I was just a

[virt-tools-list] [PATCH 1/2] Avoid creating ovirt foreign menu item manually

This patch is a preparation for a upcoming UI change that will present the ISO list in a separate dialog, instead of a submenu. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 26 -- src/resources/ui/virt-viewer.u

[virt-tools-list] [PATCH 2/2] Avoid unecessary debug message if returning NULL

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 9b552eb..959804d 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-f

Re: [virt-tools-list] [virt-viewer] mingw, spec: Bump msitools version

wdata > -BuildRequires: msitools >= 0.95-4 > +BuildRequires: msitools >= 0.95-5 > > BuildArch: noarch > > Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com _

[virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

This patch is a preparation for a upcoming UI change that will present the ISO list in a separate dialog, instead of a submenu. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 23 +++ src/resources/ui/virt-viewer.u

Re: [virt-tools-list] [PATCH virt-viewer 4/4] Fix missing field initializers

On 06/23/2016 10:26 AM, Pavel Grunt wrote: > On Thu, 2016-06-23 at 10:15 -0300, Eduardo Lima (Etrunko) wrote: >> On 06/22/2016 05:16 PM, Pavel Grunt wrote: >>> On Wed, 2016-06-22 at 14:59 -0300, Eduardo Lima (Etrunko) wrote: >>>> This is not actually nece

[virt-tools-list] [PATCH virt-viewer v2 0/2] Changes to ovirt-foreign menu

In this version: - Rebase to latest master - Better commit messages - Additional debug message if returning NULL in patch 2 Eduardo Lima (Etrunko) (2): Get ovirt foreign menu item from UI file Use more accurate debug messages for foreign menu src/ovirt-foreign-menu.c| 3 ++- src

[virt-tools-list] [PATCH virt-viewer v2 2/2] Use more accurate debug messages for foreign menu

Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/ovirt-foreign-menu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c index 9b552eb..2d286fb 100644 --- a/src/ovirt-foreign-menu.c +++ b/src/ovirt-f

[virt-tools-list] [PATCH virt-viewer v2 1/2] Get ovirt foreign menu item from UI file

of a submenu. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 23 +++ src/resources/ui/virt-viewer.ui | 8 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/src/remote-viewer.c b/src/remote-vi

Re: [virt-tools-list] [PATCH virt-viewer v2 0/2] Changes to ovirt-foreign menu

On 06/24/2016 04:16 AM, Christophe Fergeau wrote: > Hey, > > On Fri, Jun 24, 2016 at 02:44:07AM +0200, Fabiano Fidêncio wrote: >> On Thu, Jun 23, 2016 at 7:15 PM, Eduardo Lima (Etrunko) >> <etru...@redhat.com> wrote: >>> In this version: >>> -

Re: [virt-tools-list] [PATCH 2/2] Avoid unecessary debug message if returning NULL

On 06/23/2016 01:36 PM, Christophe Fergeau wrote: > On Thu, Jun 23, 2016 at 10:13:25AM -0300, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> >> --- >> src/ovirt-foreign-menu.c | 2 +- >> 1 file changed, 1 insertion(+

Re: [virt-tools-list] [PATCH v2] Avoid creating ovirt foreign menu item manually

about. Okay fixed. > > Christophe > > On Thu, Jun 23, 2016 at 11:23:11AM -0300, Eduardo Lima (Etrunko) wrote: >> This patch is a preparation for a upcoming UI change that will present >> the ISO list in a separate dialog, instead of a submenu. >> >> Signed-of

[virt-tools-list] [PATCH] Get rid of deprecated functions to customize widget colors

Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94276 Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- As a result of commit cc455b7f916110d7cfae6b7af753349e070c9494, setting custom color for background does not work anymore on my Fedora 23 system. The status label

Re: [virt-tools-list] [PATCH virt-viewer 2/2] display: Remove zoom property

I guess this change answers the question I asked in the previous email. :) Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> On 02/05/2016 01:27 PM, Pavel Grunt wrote: > It is possible to get the same info from the "zoom-level" property. > virt_viewer_display_get_z

Re: [virt-tools-list] [PATCH virt-viewer 1/2] display: Use common code to get preferred size

; +guint zoom_level = virt_viewer_display_get_zoom_level(display); The functions you removed access these fields directly? Any reason for not doing it? Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > +*preferred_dim = round(desktop_dim * zoom_level

[virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

emoved' signals, as those will be emited by GtkApplication whenever gtk_application_add_window() and gtk_application_remove_window() are called. Also, 'window-removed' was not being used anywhere. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac |

[virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

With glib requirements now being 2.38, these functions do not make sense anymore Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-glib-compat.c | 15 --- src/virt-glib-compat.h | 27 --- 2 files changed, 42 deletions(-) diff --git

[virt-tools-list] [PATCH v3 2/5] Minor code cleanups

- Reuse #ifdef HAVE_SPICE_GTK block for include. - Move declaration of vfunc together with others of the same class. - Move variable declaration to the top of the function. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 13 +++-- 1 file chan

[virt-tools-list] [PATCH v3 4/5] remote-viewer: Remove unused properties

The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c

[virt-tools-list] [PATCH v3 1/5] Drop support to gtk2

From: Fabiano Fidêncio The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. --- configure.ac | 39 +++

[virt-tools-list] [PATCH virt-viewer v3 0/5] Port to GtkApplication API's

, and it would be good to have those pushed, avoiding the maintenance burden outside of the tree. Eduardo Lima (Etrunko) (4): Minor code cleanups Port to GtkApplication API's remote-viewer: Remove unused properties Drop old compatibility code Fabiano Fidêncio (1): Drop support to gtk2

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

This does not happen with virt-viewer. I attached the gdb backtrace to this mail. On 02/12/2016 09:35 AM, Eduardo Lima (Etrunko) wrote: [snip] > diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c > index 653b30c..5b0e720 100644 > --- a/src/virt-viewer-app.c > +++ b/src/virt-

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote: > Running remote-viewer will throw some warnings: > > (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: > assertion 'GTK_IS_APPLICATION (application)' failed > > (remote-viewer:

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

On 02/12/2016 03:26 PM, Eduardo Lima (Etrunko) wrote: > On 02/12/2016 10:09 AM, Eduardo Lima (Etrunko) wrote: >> Running remote-viewer will throw some warnings: >> >> (remote-viewer:546): Gtk-CRITICAL **: gtk_application_get_app_menu: >> assertion 'GTK_IS_APPLIC

Re: [virt-tools-list] [PATCH virt-viewer v2 3/3] display: Set value of desktop width and height property directly

ht = g_value_get_int(value); > break; > case PROP_NTH_DISPLAY: > priv->nth_display = g_value_get_int(value); > Acked-by: Eduardo Lima (Etrunko) <etru...@redhat.com> -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com

Re: [virt-tools-list] [PATCH virt-viewer v2 2/3] display: Return early and remove a block

idth, > child_allocation.height); > - gtk_widget_size_allocate(child, _allocation); > -} > +g_debug("Child allocate %dx%d", child_allocation.width, > child_allocation.height); > +gtk_widget_size_allocate(child, _allocation); > > #if !GT

Re: [virt-tools-list] [PATCH virt-viewer] display: Set value of desktop width and height property directly

On 01/27/2016 03:33 PM, Pavel Grunt wrote: > Avoid calling gtk_widget_queue_resize() and emitting > the "display-desktop-resize" signal. Just curious about why this change is necessary? I mean, isn't this signal necessary somewhere else? I see it is handled in VirtViewerWindow. If so, please

Re: [virt-tools-list] [PATCH virt-viewer 2/2] display: Move variable definitions to block where are used

On 01/27/2016 03:03 PM, Pavel Grunt wrote: > --- > src/virt-viewer-display.c | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c > index 72ec56a..d1b088e 100644 > --- a/src/virt-viewer-display.c > +++

Re: [virt-tools-list] [PATCH virt-viewer 1/2] display: Remove unnecessary VIRT_VIEWER_DISPLAY cast

-guint zoom = > virt_viewer_display_get_zoom_level(VIRT_VIEWER_DISPLAY(self)); > +if (virt_viewer_display_get_zoom(self)) { > +guint zoom = virt_viewer_display_get_zoom_level(self); > > preferred->width = round(preferred->width * NORMAL_ZOOM_LEVEL / > (double)

[virt-tools-list] [PATCH] Don't open the default display while parsing command line

Since commit a9ce19f it has not been possible to check app version from a tty without X session running. The issue is that gtk_get_option_group function opens the default display if passed TRUE as argument. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/virt-viewer-app

Re: [virt-tools-list] [virt-viewer 1/3] Bring back libvirt-glib dependency

On 02/25/2016 06:11 PM, Fabiano Fidêncio wrote: > On Thu, Feb 25, 2016 at 3:04 PM, Eduardo Lima (Etrunko) > <etru...@redhat.com> wrote: >> On 02/23/2016 11:32 AM, Fabiano Fidêncio wrote: >>> libvirt-glib dependency was dropped in commit 296f91c in favor to >>&g

Re: [virt-tools-list] [virt-viewer 1/2] util: slightly reorganize _load_ui()

On 02/25/2016 04:21 AM, Fabiano Fidêncio wrote: > The function was a bit hard to read and, mainly, hard to expand in a > readable way when adding one more directory to try to load the ui file > from. > > Signed-off-by: Fabiano Fidêncio > --- > src/virt-viewer-util.c | 60 >

Re: [virt-tools-list] [virt-viewer 0/2] Allow loading in-tree ui files

On 02/25/2016 04:20 AM, Fabiano Fidêncio wrote: > The goal of these two patches are the $(subject). > The first one is just doing a small refactoring in the _load_ui() in the way > that introducing a new path to load a file from wouldn't be too confusing. > > As always, the most dificult part of

Re: [virt-tools-list] [virt-viewer] configure: Simplify libvirt/libvirt-glib handling

gt; $(COMMON_LIBS) \ > $(LIBVIRT_LIBS) \ > - $(LIBVIRT_GLIB_LIBS)\ > $(NULL) > virt_viewer_CFLAGS = \ > $(COMMON_CFLAGS)\ > $(LIBVIRT_CFLAGS)

Re: [virt-tools-list] [virt-viewer] about: Fix the program's name in the title

t; --- a/src/virt-viewer-about.xml > +++ b/src/virt-viewer-about.xml > @@ -4,7 +4,7 @@ > > False > 5 > -About Glade > +About Virt-Viewer > False > True > center-on-parent > Funny :) Acked-by: Eduardo Lima (Etrunko) <

Re: [virt-tools-list] [virt-viewer] Use GResource for loading ui files

m more experienced people. Reviewed-by: Eduardo Lima (Etrunko) <etru...@redhat.com> > Signed-off-by: Fabiano Fidêncio <fiden...@redhat.com> > --- > src/Makefile.am | 25 ++ > src/virt-viewer-about.xml | 1 - > src/virt-viewer-app.c

Re: [virt-tools-list] [PATCH v3 1/5] Drop support to gtk2

On 02/15/2016 11:48 AM, Fabiano Fidêncio wrote: > > This patch got already ACKed in one of the previous iterations? > If yes, I'll push it. If it's not the case, I cannot ACK my own patch > though :-) > I can ack it for you :P. But this one is already outdated due to Pavel's recent changes in

Re: [virt-tools-list] [PATCH v3 2/5] Minor code cleanups

On 02/15/2016 11:51 AM, Fabiano Fidêncio wrote: > > Acked-by: Fabiano Fidêncio > > Anyways. was this patch already ACKed in the previous iterations, no? > It might have, but I don't have write permissions to the repositories, so I can't push. -- Eduardo de Barros Lima

Re: [virt-tools-list] [PATCH v3 3/5] Port to GtkApplication API's

On 02/15/2016 11:47 AM, Fabiano Fidêncio wrote: [snip] >> >> cleanup: >> -g_free(uri); >> -if (viewer) >> -g_object_unref(viewer); >> -g_strfreev(args); >> -g_clear_error(); >> - >> +g_object_unref(viewer); > > g_object_unref() shouldn't be called with a NULL

Re: [virt-tools-list] [PATCH v3 5/5] Drop old compatibility code

On 02/15/2016 11:57 AM, Fabiano Fidêncio wrote: > > NACK from me. > There is no reason for keeping an empty virt-glib-compat.c file. > virt-glib-compat.h also could be removed entirely as g_clear_pointer() > was introduced in 2.34. So, please, remove both files from the tree. > > Reviewed-by:

[virt-tools-list] [PATCH v4 2/5] Minor code cleanups

- Reuse #ifdef HAVE_SPICE_GTK block for include. - Move declaration of vfunc together with others of the same class. - Move variable declaration to the top of the function. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c | 13 +++-- 1 file chan

[virt-tools-list] [PATCH v4 5/5] Drop old compatibility code

With glib requirements now being 2.38, these functions do not make sense anymore. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 - src/virt-glib-compat.c | 34 - src/vir

[virt-tools-list] [PATCH v4 1/5] Drop support to gtk2

From: Fabiano Fidêncio <fiden...@redhat.com> The 3.0 release was the last one that still supports GTK2. For the Windows builds the support to GTK2 was dropped in the previous release. Let's do the same for the entire project now. Signed-off-by: Eduardo Lima (Etrunko) <etru...@r

[virt-tools-list] [PATCH v4 4/5] remote-viewer: Remove unused properties

The reason for using properties to access those members was to ensure that they would only be set during the creation of the object. Now that we removed that restriction, we set private members directly. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/remote-viewer.c

[virt-tools-list] [PATCH v4 virt-viewer 0/5] Port to GtkApplication API's

In this version: Rebased to latest master, fixed conflicts in virt-viewer-display.c. Fix patch #3 according to review by Fabiano Fidencio. Remove virt-glib-compat.[ch] files entirely from the tree. All functions are now covered with new version requirements. Eduardo Lima (Etrunko) (4): Minor

[virt-tools-list] [PATCH v4 3/5] Port to GtkApplication API's

emoved' signals, as those will be emited by GtkApplication whenever gtk_application_add_window() and gtk_application_remove_window() are called. Also, 'window-removed' was not being used anywhere. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- configure.ac |

Re: [virt-tools-list] [PATCH v4 3/5] Port to GtkApplication API's

On 02/15/2016 12:31 PM, Eduardo Lima (Etrunko) wrote: > diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c > index 3a958f0..14549fd 100644 > --- a/src/virt-viewer-window.c > +++ b/src/virt-viewer-window.c > @@ -346,8 +346,7 @@ virt_viewer_window_init (VirtVie

[virt-tools-list] [PATCH v5 3/3] Drop old compatibility code

With glib requirements now being 2.38, these functions do not make sense anymore. Signed-off-by: Eduardo Lima (Etrunko) <etru...@redhat.com> --- src/Makefile.am | 2 - src/ovirt-foreign-menu.c| 1 - src/virt-glib-compat.c | 34 - src/vir

  1   2   3   4   >