[virt-tools-list] [PATCH] virt-manager: Fix VNC connection on hypervisor without GraphicsFD

2016-03-26 Thread Mikhail Feoktistov
Function virDomainOpenGraphicsFD() from libvirt can return -1 But in this case libvirt-python will raise an exception. We should handle this case and return -1 as invalid FD. In commit 5c451b64 Viewer._open() there is a code to open graphics console in case of invalid GraphicsFD. --- virtManager/d

Re: [virt-tools-list] [PATCH] virt-manager: Fix VNC connection on hypervisor without GraphicsFD

2016-03-29 Thread Mikhail Feoktistov
Hello Cole! Can you look at this patch? What do you think? On 26.03.2016 13:02, Mikhail Feoktistov wrote: Function virDomainOpenGraphicsFD() from libvirt can return -1 But in this case libvirt-python will raise an exception. We should handle this case and return -1 as invalid FD. In commit

[virt-tools-list] [PATCH 0/2] Virtuozzo hypervisor basic support

2016-04-14 Thread Mikhail Feoktistov
-manager to support all virtuozzo features. Mikhail Feoktistov (2): Add GUI and basic functionality to support virtuozzo hypervisor Set bridged network as default for virtuozzo hypervisor ui/create.ui | 155 +- virtManager/connect.py

[virt-tools-list] [PATCH 2/2] Set bridged network as default for virtuozzo hypervisor

2016-04-14 Thread Mikhail Feoktistov
After clean installation virtuozzo hypervisor doesn't have network with "default" name. Intead of this it has "Bridged" network. In this patch we set "Bridged" network as default network. --- virtManager/netlist.py | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[virt-tools-list] [PATCH 1/2] Add GUI and basic functionality to support virtuozzo hypervisor

2016-04-14 Thread Mikhail Feoktistov
GUI changes: Add virtuozzo hypervisor to connection list. Add radio buttons for choosing VM or container virtualization type. New wizzard window for setting template name for containers. Creating guest: We don't call createXML() for virtuozzo guests, because virtuozzo driver in libvirt doesn't sup

[virt-tools-list] [PATCH] virt-manager: fix exception when create virtuozzo container

2016-10-05 Thread Mikhail Feoktistov
In _do_async_install we have a race. We create domain in guest.start_install() and it begins to start. Then we check vm.is_shutoff() but domain doesn't have "running" state. It's still starting. Then we try to start it by vm.startup() and we get an exception from libvirt. This patch change this lo

Re: [virt-tools-list] [PATCH] virt-manager: fix exception when create virtuozzo container

2016-10-17 Thread Mikhail Feoktistov
On 11.10.2016 17:30, Cole Robinson wrote: On 10/05/2016 12:01 PM, Mikhail Feoktistov wrote: In _do_async_install we have a race. We create domain in guest.start_install() and it begins to start. Then we check vm.is_shutoff() but domain doesn't have "running" state. It's

[virt-tools-list] [PATCH v2] Virtuozzo hypervisor basic support

2017-02-15 Thread Mikhail Feoktistov
This patch introduces virtuozzo hypervisor support. Here we implemented only basic functionality. User can create/start/stop/delete containers. Also we allow to change hardware configuration (basic devices) and connect via VNC. We are very intrested in the development of virt-manager to support all

[virt-tools-list] [PATCH v3 1/6] Add GUI to create wizzard for virtuozzo containers

2017-02-21 Thread Mikhail Feoktistov
Add virtuozzo hypervisor to connection list. Add radio buttons for choosing VM or container virtualization type. New wizzard window for setting template name for containers. --- ui/create.ui | 149 +- virtManager/connect.py| 8 ++- vir

[virt-tools-list] [PATCH v3 6/6] Add tests for Virtuozzo hypervisor

2017-02-21 Thread Mikhail Feoktistov
UI and CLI tests --- tests/capabilities-xml/vz.xml | 53 ++ .../compare/virt-install-vz-ct-template.xml| 26 +++ tests/clitest.py | 15 ++ tests/uitests/newvm.py | 23

[virt-tools-list] [PATCH v3 4/6] Tune default device list for Virtuozzo containers

2017-02-21 Thread Mikhail Feoktistov
--- virtManager/addhardware.py | 2 +- virtinst/guest.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index e63ad3d..3ceb27c 100644 --- a/virtManager/addhardware.py +++ b/virtManager/addhardware.py @@ -5

[virt-tools-list] [PATCH v3 5/6] Do not use createXML for non transient domains

2017-02-21 Thread Mikhail Feoktistov
For these domains use defineXML Also do not call secocd defineXML if install_xml == final_xml --- virtinst/guest.py | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/virtinst/guest.py b/virtinst/guest.py index ae23847..dd579ff 100644 --- a/virtinst/guest.py +++ b/vir

[virt-tools-list] [PATCH v3 3/6] Update tests because we use destroy as a default action for on_crash

2017-02-21 Thread Mikhail Feoktistov
--- tests/cli-test-xml/clone-disk-noexist.xml| 2 +- tests/cli-test-xml/compare/virt-clone-clone-auto1.xml| 2 +- tests/cli-test-xml/compare/virt-clone-clone-auto2.xml| 2 +- tests/cli-test-xml/compare/virt-convert-ovf-compare.xml | 2 +- tests/cli-test

[virt-tools-list] [PATCH v3 2/6] Set default action in case of on_crash as destroy

2017-02-21 Thread Mikhail Feoktistov
Virtuozzo hypervisor doesn't support restart on_crash for containers. Also for common qemu usage it's not going to have any functional difference. --- virtinst/guest.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/virtinst/guest.py b/virtinst/guest.py index 7d3fb9d..5b8bc7

[virt-tools-list] [PATCH v3 0/6] Virtuozzo hypervisor basic support

2017-02-21 Thread Mikhail Feoktistov
support all virtuozzo features. Mikhail Feoktistov (6): Add GUI to create wizzard for virtuozzo containers Set default action in case of on_crash as destroy Update tests cause we use destroy as default action for on_crash Tune default device list for Virtuozzo containers Do not use createXML

Re: [virt-tools-list] [PATCH v2] Virtuozzo hypervisor basic support

2017-02-21 Thread Mikhail Feoktistov
below On 02/15/2017 07:01 AM, Mikhail Feoktistov wrote: This patch introduces virtuozzo hypervisor support. Here we implemented only basic functionality. User can create/start/stop/delete containers. Also we allow to change hardware configuration (basic devices) and connect via VNC. We are very

Re: [virt-tools-list] [PATCH v3 1/6] Add GUI to create wizzard for virtuozzo containers

2017-03-13 Thread Mikhail Feoktistov
On 01.03.2017 23:56, Cole Robinson wrote: On 02/21/2017 09:27 AM, Mikhail Feoktistov wrote: Add virtuozzo hypervisor to connection list. Add radio buttons for choosing VM or container virtualization type. New wizzard window for setting template name for containers. --- ui/create.ui

[virt-tools-list] [PATCH v4 1/5] Add VM capabilities to vz.xml

2017-03-13 Thread Mikhail Feoktistov
--- tests/capabilities-xml/vz.xml | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/capabilities-xml/vz.xml b/tests/capabilities-xml/vz.xml index fac68d9..318f5b0 100644 --- a/tests/capabilities-xml/vz.xml +++ b/tests/capabilities-xml/vz.xml @@ -29,6 +29,28 @@

[virt-tools-list] [PATCH v4 4/5] Tune default device list for Virtuozzo containers

2017-03-13 Thread Mikhail Feoktistov
Virtuozzo supports virtio NIC. Also add default VNC graphics. Privnet feature and emulator device have no sense for vz containers. --- virtManager/addhardware.py | 2 +- virtinst/guest.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/virtManager/addhardware.py

[virt-tools-list] [PATCH v4 3/5] Add GUI test for Virtuozzo containers

2017-03-13 Thread Mikhail Feoktistov
--- tests/uitests/newvm.py | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/uitests/newvm.py b/tests/uitests/newvm.py index 83b4d67..d6782da 100644 --- a/tests/uitests/newvm.py +++ b/tests/uitests/newvm.py @@ -285,6 +285,27 @@ class NewVM(unittest.TestCase):

[virt-tools-list] [PATCH v4 5/5] Fix test xml for Virtuozzo containers

2017-03-13 Thread Mikhail Feoktistov
Privnet feature and emulator device have no sense for vz containers Add VNC graphics by default --- tests/cli-test-xml/compare/virt-install-vz-ct-template.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/cli-test-xml/compare/virt-install-vz-ct-template.xml b/tests

[virt-tools-list] [PATCH v4 2/5] Add GUI to create wizard for virtuozzo containers

2017-03-13 Thread Mikhail Feoktistov
Add virtuozzo hypervisor to connection list. Add radio buttons for choosing VM or container virtualization type. New wizard window for setting template name for containers. --- ui/create.ui | 149 +- virtManager/connect.py| 8 ++- virt

[virt-tools-list] [PATCH v4 0/5] Virtuozzo hypervisor basic support

2017-03-13 Thread Mikhail Feoktistov
Mikhail Feoktistov (5): Add VM capabilities to vz.xml Add GUI to create wizard for virtuozzo containers Add GUI test for Virtuozzo containers Tune default device list for Virtuozzo containers Fix test xml for Virtuozzo containers tests/capabilities-xml/vz.xml | 22

Re: [virt-tools-list] [PATCH v4 1/5] Add VM capabilities to vz.xml

2017-03-17 Thread Mikhail Feoktistov
On 17.03.2017 20:57, Cole Robinson wrote: On 03/13/2017 08:01 AM, Mikhail Feoktistov wrote: --- tests/capabilities-xml/vz.xml | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/capabilities-xml/vz.xml b/tests/capabilities-xml/vz.xml index fac68d9..318f5b0