Re: [virt-tools-list] [virt-viewer PATCH] ovirt-foreign-menu: Fix warnings on Rawhide

2019-08-15 Thread Fabiano Fidêncio 
On Thu, Aug 15, 2019 at 9:03 PM Eduardo Lima (Etrunko)
 wrote:
>
> On 8/15/19 12:07 PM, Fabiano Fidêncio wrote:
> > gmaovirt-foreign-menu.c: In function 'storage_domains_fetched_cb':
> > ovirt-foreign-menu.c:721:9: error: format not a string literal and no 
> > format arguments [-Werror=format-security]
> >   721 | g_debug(msg);
> >   | ^~~
> > ovirt-foreign-menu.c:722:9: error: format not a string literal and no 
> > format arguments [-Werror=format-security]
> >   722 | g_task_return_new_error(task, OVIRT_ERROR, 
> > OVIRT_ERROR_FAILED, msg);
> >   | ^~~
> > cc1: some warnings being treated as errors
> > gmake[3]: *** [Makefile:963: libvirt_viewer_la-ovirt-foreign-menu.lo] Error 
> > 1
> > gmake[2]: *** [Makefile:647: all] Error 2
> > gmake[1]: *** [Makefile:482: all-recursive] Error 1
> > make: *** [Makefile:410: all] Error 2
> > error: Bad exit status from /var/tmp/rpm-tmp.f14Lmj (%build)
> >
> > Errors have been caught by 
> > https://ci.centos.org/job/virt-viewer-rpm/systems=libvirt-fedora-rawhide/589/
> >
> > Signed-off-by: Fabiano Fidêncio 
> > ---
> >  src/ovirt-foreign-menu.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
> > index 75f9ac4..4ec0858 100644
> > --- a/src/ovirt-foreign-menu.c
> > +++ b/src/ovirt-foreign-menu.c
> > @@ -718,8 +718,8 @@ static void storage_domains_fetched_cb(GObject 
> > *source_object,
> >  const char *msg = domain_valid ? "Could not find ISO file 
> > collection"
> > : "Could not find valid ISO storage 
> > domain";
> >
> > -g_debug(msg);
> > -g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, 
> > msg);
> > +g_debug("%s", msg);
> > +g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, 
> > "%s", msg);
> >  g_object_unref(task);
> >  }
> >  }
> >
> Acked-by: Eduardo Lima (Etrunko) 

Pushed, thanks for the review!

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [virt-viewer PATCH] ovirt-foreign-menu: Fix warnings on Rawhide

2019-08-15 Thread Eduardo Lima (Etrunko) 
On 8/15/19 12:07 PM, Fabiano Fidêncio wrote:
> gmaovirt-foreign-menu.c: In function 'storage_domains_fetched_cb':
> ovirt-foreign-menu.c:721:9: error: format not a string literal and no format 
> arguments [-Werror=format-security]
>   721 | g_debug(msg);
>   | ^~~
> ovirt-foreign-menu.c:722:9: error: format not a string literal and no format 
> arguments [-Werror=format-security]
>   722 | g_task_return_new_error(task, OVIRT_ERROR, 
> OVIRT_ERROR_FAILED, msg);
>   | ^~~
> cc1: some warnings being treated as errors
> gmake[3]: *** [Makefile:963: libvirt_viewer_la-ovirt-foreign-menu.lo] Error 1
> gmake[2]: *** [Makefile:647: all] Error 2
> gmake[1]: *** [Makefile:482: all-recursive] Error 1
> make: *** [Makefile:410: all] Error 2
> error: Bad exit status from /var/tmp/rpm-tmp.f14Lmj (%build)
> 
> Errors have been caught by 
> https://ci.centos.org/job/virt-viewer-rpm/systems=libvirt-fedora-rawhide/589/
> 
> Signed-off-by: Fabiano Fidêncio 
> ---
>  src/ovirt-foreign-menu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
> index 75f9ac4..4ec0858 100644
> --- a/src/ovirt-foreign-menu.c
> +++ b/src/ovirt-foreign-menu.c
> @@ -718,8 +718,8 @@ static void storage_domains_fetched_cb(GObject 
> *source_object,
>  const char *msg = domain_valid ? "Could not find ISO file collection"
> : "Could not find valid ISO storage 
> domain";
>  
> -g_debug(msg);
> -g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg);
> +g_debug("%s", msg);
> +g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, "%s", 
> msg);
>  g_object_unref(task);
>  }
>  }
> 
Acked-by: Eduardo Lima (Etrunko) 

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - Red Hat
etru...@redhat.com

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

[virt-tools-list] [virt-viewer PATCH] ovirt-foreign-menu: Fix warnings on Rawhide

2019-08-15 Thread Fabiano Fidêncio 
gmaovirt-foreign-menu.c: In function 'storage_domains_fetched_cb':
ovirt-foreign-menu.c:721:9: error: format not a string literal and no format 
arguments [-Werror=format-security]
  721 | g_debug(msg);
  | ^~~
ovirt-foreign-menu.c:722:9: error: format not a string literal and no format 
arguments [-Werror=format-security]
  722 | g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, 
msg);
  | ^~~
cc1: some warnings being treated as errors
gmake[3]: *** [Makefile:963: libvirt_viewer_la-ovirt-foreign-menu.lo] Error 1
gmake[2]: *** [Makefile:647: all] Error 2
gmake[1]: *** [Makefile:482: all-recursive] Error 1
make: *** [Makefile:410: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.f14Lmj (%build)

Errors have been caught by 
https://ci.centos.org/job/virt-viewer-rpm/systems=libvirt-fedora-rawhide/589/

Signed-off-by: Fabiano Fidêncio 
---
 src/ovirt-foreign-menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 75f9ac4..4ec0858 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -718,8 +718,8 @@ static void storage_domains_fetched_cb(GObject 
*source_object,
 const char *msg = domain_valid ? "Could not find ISO file collection"
: "Could not find valid ISO storage 
domain";
 
-g_debug(msg);
-g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg);
+g_debug("%s", msg);
+g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, "%s", 
msg);
 g_object_unref(task);
 }
 }
-- 
2.21.0

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list