Re: [virt-tools-list] Plugins for virt-manager

2016-09-19 Thread Martin Kletzander

On Fri, Sep 16, 2016 at 05:06:00PM +0100, Daniel P. Berrange wrote:

On Fri, Sep 16, 2016 at 10:56:37AM -0500, David Ashley wrote:

Does virt-manager support plugins? I have looked through the source code and
can not find any supporting mechanism for this functionality. I have an idea
for extending virt-manager but it would involve functionality that would
only be useful for some users. I would hate to impose the overhead for this
new functionality for all users so I think it should be implemented as a
plugin.

I can add the plugin code to virt-manager once an architecture has been
established. Obviously a lot of input would be needed to get this right.
Would others be interested in contributing (ideas, code, testing, etc.) to
this? Or is this even the correct way to add new functionality to
virt-manager? is there a better way?

Discussion anyone?


The natural approach to plugins for any GTK app these days is to integrate
with libpeas. It would not relaly be all that much work. The harder thing
is deciding what kind of API gaurantees to provide plugin authors. eg will
changes in virt-manager break plugins on every release :-)



Creating a plug-in architecture is IMHO not as much work as maintaining
a plug-in API.  It doesn't need to be stable if the plug-ins are in the
same repository.  Also, wouldn't it be possible to have that part of the
code and enabled opt-in by some checkbox?  There already is an optional
code, that is integration of libguestfs.  If it's not on your system, it
will not fail, but if you have that installed, you can get some info
about your machines, with a little overhead.



Regards,
Daniel
--
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list


signature.asc
Description: Digital signature
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] Plugins for virt-manager

2016-09-16 Thread Daniel P. Berrange
On Fri, Sep 16, 2016 at 10:56:37AM -0500, David Ashley wrote:
> Does virt-manager support plugins? I have looked through the source code and
> can not find any supporting mechanism for this functionality. I have an idea
> for extending virt-manager but it would involve functionality that would
> only be useful for some users. I would hate to impose the overhead for this
> new functionality for all users so I think it should be implemented as a
> plugin.
> 
> I can add the plugin code to virt-manager once an architecture has been
> established. Obviously a lot of input would be needed to get this right.
> Would others be interested in contributing (ideas, code, testing, etc.) to
> this? Or is this even the correct way to add new functionality to
> virt-manager? is there a better way?
> 
> Discussion anyone?

The natural approach to plugins for any GTK app these days is to integrate
with libpeas. It would not relaly be all that much work. The harder thing
is deciding what kind of API gaurantees to provide plugin authors. eg will
changes in virt-manager break plugins on every release :-)


Regards,
Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list


[virt-tools-list] Plugins for virt-manager

2016-09-16 Thread David Ashley
Does virt-manager support plugins? I have looked through the source code 
and can not find any supporting mechanism for this functionality. I have 
an idea for extending virt-manager but it would involve functionality 
that would only be useful for some users. I would hate to impose the 
overhead for this new functionality for all users so I think it should 
be implemented as a plugin.


I can add the plugin code to virt-manager once an architecture has been 
established. Obviously a lot of input would be needed to get this right. 
Would others be interested in contributing (ideas, code, testing, etc.) 
to this? Or is this even the correct way to add new functionality to 
virt-manager? is there a better way?


Discussion anyone?

W. David Ashley

___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list