Re: [virt-tools-list] [virt-manager][PATCH] setup.py: Distribute virtinst/ subdirectories
On 04/11/2018 07:09 AM, Michal Privoznik wrote: > On 04/11/2018 12:43 PM, Radostin Stoyanov wrote: >> Hi Michal, >> >> This commit was also created as a pull request by @z3ntu on github >> https://github.com/virt-manager/virt-manager/pull/29 > > Ah, haven't noticed because we don't use github pull requests. I don't > care which patch gets merged. > FYI the github patch was merged commit e9ba30a255f5c5a985bade205456c24c35ec55ac Author: Luca Weiss Date: Sun Apr 8 18:40:04 2018 +0200 setup: Install files in new virtinst folders - Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager][PATCH] setup.py: Distribute virtinst/ subdirectories
On 04/11/2018 12:43 PM, Radostin Stoyanov wrote: > Hi Michal, > > This commit was also created as a pull request by @z3ntu on github > https://github.com/virt-manager/virt-manager/pull/29 Ah, haven't noticed because we don't use github pull requests. I don't care which patch gets merged. Michal ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
Re: [virt-tools-list] [virt-manager][PATCH] setup.py: Distribute virtinst/ subdirectories
Hi Michal, This commit was also created as a pull request by @z3ntu on github https://github.com/virt-manager/virt-manager/pull/29 Radostin On 11/04/18 10:55, Michal Privoznik wrote: > In fe9ed2340cd5b6 and 3909c10441a5f4eb two new virtinst/ > subdirectories were introduced. However, we forget to distribute > them therefore installed virt-manager fails to start. > > Signed-off-by: Michal Privoznik > --- > setup.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/setup.py b/setup.py > index 7ca6d677..50f97f07 100755 > --- a/setup.py > +++ b/setup.py > @@ -671,6 +671,8 @@ distutils.core.setup( > ("share/virt-manager/virtcli", > glob.glob("virtcli/*.py") + glob.glob("virtcli/cli.cfg")), > ("share/virt-manager/virtinst", glob.glob("virtinst/*.py")), > +("share/virt-manager/virtinst/devices", > glob.glob("virtinst/devices/*.py")), > +("share/virt-manager/virtinst/domain", > glob.glob("virtinst/domain/*.py")), > ("share/virt-manager/virtconv", glob.glob("virtconv/*.py")), > ], > ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list