Re: [virtio-dev] [PATCH v17 1/2] virtio-crypto: Add virtio crypto device specification

2017-04-21 Thread Stefan Hajnoczi
On Thu, Apr 13, 2017 at 05:11:13PM +0800, Gonglei wrote: > +The request of dataq, mixing both session and stateless mode is as follows: It sounds more natural when "request" is plural: "Dataq requests for both session and stateless modes are as follows:" > + > +\begin{lstlisting} > +struct

[virtio-dev] Re: [PATCH RFC (resend) net-next 0/6] virtio-net: Add support for virtio-net header extensions

2017-04-21 Thread Vlad Yasevich
On 04/21/2017 12:05 AM, Jason Wang wrote: > > > On 2017年04月20日 23:34, Vlad Yasevich wrote: >> On 04/17/2017 11:01 PM, Jason Wang wrote: >>> >>> On 2017年04月16日 00:38, Vladislav Yasevich wrote: Curreclty virtion net header is fixed size and adding things to it is rather difficult

[virtio-dev] virtio-blk: What's up with VIRTIO_BLK_T_GET_ID (8)?

2017-04-21 Thread Cornelia Huck
I see the request type in $SUBJECT implemented in both Linux and QEMU, but I can't find it in the standard. If we believe that getting a s/n is useful, we should spec it; otherwise, if we consider it just a legacy request type, it wouldn't hurt to mention it in the legacy section.

[virtio-dev] Require for English style review (was RE: [PATCH v17 0/2] virtio-crypto: virtio crypto device specification)

2017-04-21 Thread Gonglei (Arei)
Hi all, As a non-native English speaker, I sincerely hope you give me more suggestions about English style and/or grammar for the spec. Thanks in advance! -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, April 13, 2017 5:11 PM > To: qemu-de...@nongnu.org;