[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-13 Thread Siwei Liu
On Tue, Mar 13, 2018 at 5:28 PM, Samudrala, Sridhar wrote: > On 3/12/2018 3:44 PM, Siwei Liu wrote: >> >> Apologies, still some comments going. Please see inline. >> >> On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala >> wrote: >>> >>>

[virtio-dev] [PATCH] github: PULL_REQUEST_TEMPLATE.md

2018-03-13 Thread Michael S. Tsirkin
Document that we don't accept pull requests at this point. Signed-off-by: Michael S. Tsirkin --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git

Re: [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-13 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 10:43:01AM +0800, Wei Wang wrote: > On 03/14/2018 12:49 AM, Michael S. Tsirkin wrote: > > On Wed, Mar 07, 2018 at 08:34:24PM +0800, Wei Wang wrote: > > > > > Signed-off-by: Wei Wang > > > Signed-off-by: Liang Li > > > CC:

[virtio-dev] Re: [PATCH v4 4/4] migration: use the free page hint feature from balloon

2018-03-13 Thread Michael S. Tsirkin
On Wed, Mar 14, 2018 at 10:41:36AM +0800, Wei Wang wrote: > On 03/14/2018 12:35 AM, Michael S. Tsirkin wrote: > > On Wed, Mar 07, 2018 at 08:34:25PM +0800, Wei Wang wrote: > > > Start the free page optimization after the migration bitmap is > > > synchronized. This can't be used in the stop phase

Re: [virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-13 Thread Wei Wang
On 03/14/2018 12:49 AM, Michael S. Tsirkin wrote: On Wed, Mar 07, 2018 at 08:34:24PM +0800, Wei Wang wrote: Signed-off-by: Wei Wang Signed-off-by: Liang Li CC: Michael S. Tsirkin CC: Dr. David Alan Gilbert

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-13 Thread Michael S. Tsirkin
On Tue, Mar 13, 2018 at 05:28:07PM -0700, Samudrala, Sridhar wrote: > > I am not sure if it's a good idea to leave the > > virtio_bypass around if running into failure: the guest is not > > migratable as the VF doesn't have a backup path, > > Are you talking about a failure when registering

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-13 Thread Samudrala, Sridhar
On 3/12/2018 2:08 PM, Jiri Pirko wrote: Mon, Mar 12, 2018 at 09:58:06PM CET, sridhar.samudr...@intel.com wrote: On 3/12/2018 1:12 PM, Jiri Pirko wrote: Thu, Mar 01, 2018 at 09:08:43PM CET, sridhar.samudr...@intel.com wrote: This patch enables virtio_net to switch over to a VF datapath when a

[virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-13 Thread Samudrala, Sridhar
On 3/12/2018 3:44 PM, Siwei Liu wrote: Apologies, still some comments going. Please see inline. On Thu, Mar 1, 2018 at 12:08 PM, Sridhar Samudrala wrote: This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC

[virtio-dev] [PULL 03/22] virtio-net: add linkspeed and duplex settings to virtio-net

2018-03-13 Thread Michael S. Tsirkin
From: Jason Baron Although linkspeed and duplex can be set in a linux guest via 'ethtool -s', this requires custom ethtool commands for virtio-net by default. Introduce a new feature flag, VIRTIO_NET_F_SPEED_DUPLEX, which allows the hypervisor to export a linkspeed and duplex

[virtio-dev] [PULL 02/22] virtio-net: use 64-bit values for feature flags

2018-03-13 Thread Michael S. Tsirkin
From: Jason Baron In prepartion for using some of the high order feature bits, make sure that virtio-net uses 64-bit values everywhere. Signed-off-by: Jason Baron Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc:

[virtio-dev] [PULL 01/22] scripts/update-linux-headers: add ethtool.h and update to 4.16.0-rc4

2018-03-13 Thread Michael S. Tsirkin
From: Jason Baron A subsequent patch to add support for setting linkspeed/duplex in virtio-net, requires a few definitions from ethtool.h, which ends up pulling in kernel.h and sysinfo.h as well. Signed-off-by: Jason Baron Cc: "Michael S. Tsirkin"

[virtio-dev] [pci PATCH v6 4/5] nvme: Migrate over to unmanaged SR-IOV support

2018-03-13 Thread Alexander Duyck
From: Alexander Duyck Instead of implementing our own version of a SR-IOV configuration stub in the nvme driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

[virtio-dev] [pci PATCH v6 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs

2018-03-13 Thread Alexander Duyck
From: Alexander Duyck Add a new driver called "pci-pf-stub" to act as a "white-list" for PF devices that provide no other functionality other then acting as a means of allocating a set of VFs. For now I only have one example ID provided by Amazon in terms of devices

[virtio-dev] [pci PATCH v6 3/5] ena: Migrate over to unmanaged SR-IOV support

2018-03-13 Thread Alexander Duyck
From: Alexander Duyck Instead of implementing our own version of a SR-IOV configuration stub in the ena driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

[virtio-dev] [pci PATCH v6 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-03-13 Thread Alexander Duyck
From: Alexander Duyck Hardware-realized virtio_pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio_net PF and virtio_net VFs. These are hardware realizations of what has been

[virtio-dev] [pci PATCH v6 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-03-13 Thread Alexander Duyck
From: Alexander Duyck This patch adds a common configuration function called pci_sriov_configure_simple that will allow for managing VFs on devices where the PF is not capable of managing VF resources. Signed-off-by: Alexander Duyck ---

[virtio-dev] [pci PATCH v6 0/5] Add support for unmanaged SR-IOV

2018-03-13 Thread Alexander Duyck
This series is meant to add support for SR-IOV on devices when the VFs are not managed by the kernel. Examples of recent patches attempting to do this include: virto - https://patchwork.kernel.org/patch/10241225/ pci-stub - https://patchwork.kernel.org/patch/10109935/ vfio -

[virtio-dev] Re: [PATCH v4 3/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-03-13 Thread Michael S. Tsirkin
On Wed, Mar 07, 2018 at 08:34:24PM +0800, Wei Wang wrote: > The new feature enables the virtio-balloon device to receive hints of > guest free pages from the free page vq. > > balloon_free_page_start - start guest free page hint reporting. > balloon_free_page_stop - stop guest free page hint

[virtio-dev] Re: [PATCH v4 4/4] migration: use the free page hint feature from balloon

2018-03-13 Thread Michael S. Tsirkin
On Wed, Mar 07, 2018 at 08:34:25PM +0800, Wei Wang wrote: > Start the free page optimization after the migration bitmap is > synchronized. This can't be used in the stop phase since the guest > is paused. Make sure the guest reporting has stopped before > synchronizing the migration dirty bitmap.

[virtio-dev] Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

2018-03-13 Thread Alexander Duyck
On Tue, Mar 13, 2018 at 1:12 AM, David Woodhouse wrote: > On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote: >> >> - .sriov_configure = ena_sriov_configure, >> +#ifdef CONFIG_PCI_IOV >> + .sriov_configure = pci_sriov_configure_simple, >> +#endif >> }; > >