[virtio-dev] Re: [PATCH v1 2/2] virtio-mmio: add features for virtio-mmio specification version 3

2020-01-08 Thread Liu, Jing2
On 1/5/2020 7:04 PM, Michael S. Tsirkin wrote: On Wed, Dec 25, 2019 at 10:50:23AM +0800, Zha Bin wrote: From: Liu Jiang Userspace VMMs (e.g. Qemu microvm, Firecracker) take advantage of using virtio over mmio devices as a lightweight machine model for modern cloud. The standard virtio over

Re: [virtio-dev][PATCH v1 1/2] virtio-mmio: Add MSI and different notification address support

2020-01-08 Thread Liu, Jing2
On 1/7/2020 12:18 AM, Stefan Hajnoczi wrote: On Fri, Dec 20, 2019 at 11:25:03PM +0800, Jing Liu wrote: Upgrade virtio-mmio to version 3, with the abilities to support MSI interrupt and notification features. The details of version 2 will be appended as part of legacy interface in next patch.

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Keiichi Watanabe
Hi Gerd, On Thu, Dec 19, 2019 at 10:12 PM Gerd Hoffmann wrote: > > Hi, > > > > However that still doesn't let the driver know which buffers will be > > > dequeued when. A simple example of this scenario is when the guest is > > > done displaying a frame and requeues the buffer back to the

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Keiichi Watanabe
Hi Gerd, Thank you so much for the review. I'm sorry for not replying earlier. On Thu, Dec 19, 2019 at 10:02 PM Gerd Hoffmann wrote: > > Hi, > > > > Not clearly defined in the spec: When is the decoder supposed to send > > > the response for a queue request? When it finished decoding (i.e.

Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Keiichi Watanabe
On Wed, Jan 8, 2020 at 10:11 PM Dmitry Sepp wrote: > > Hi Tomasz, Keiichi, > > On Mittwoch, 8. Januar 2020 13:46:25 CET Tomasz Figa wrote: > > On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe > wrote: > > > Hi Dmitry, > > > > > > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp > wrote: > > > > Hi

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Dmitry Sepp
Hi Tomasz, Keiichi, On Mittwoch, 8. Januar 2020 13:46:25 CET Tomasz Figa wrote: > On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote: > > Hi Dmitry, > > > > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp wrote: > > > Hi Keiichi, > > > > > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Keiichi Watanabe
On Wed, Jan 8, 2020 at 9:46 PM Tomasz Figa wrote: > > On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote: > > > > Hi Dmitry, > > > > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp > > wrote: > > > > > > Hi Keiichi, > > > > > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote: > >

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Tomasz Figa
On Wed, Jan 8, 2020 at 9:15 PM Keiichi Watanabe wrote: > > Hi Dmitry, > > On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp > wrote: > > > > Hi Keiichi, > > > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote: > > > Hi Dmitry, > > > > > > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp > >

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Keiichi Watanabe
Hi Dmitry, On Wed, Dec 18, 2019 at 10:02 PM Keiichi Watanabe wrote: > > From: Dmitry Sepp > > The virtio video encoder device and decoder device provide functionalities to > encode and decode video stream respectively. > Though video encoder and decoder are provided as different devices, they

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Keiichi Watanabe
Hi Dmitry, On Wed, Jan 8, 2020 at 7:00 PM Dmitry Sepp wrote: > > Hi Keiichi, > > On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote: > > Hi Dmitry, > > > > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp > wrote: > > > Hi Keiichi, > > > > > > thanks for the updates, please see my

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-08 Thread David Stevens
> Is there a specific reason why you want the host pick the uuid? I would > let the guest define the uuid, i.e. move the uuid fields to > virtio_gpu_export_resource and scratch virtio_gpu_resp_export_resource. Sending the uuid in the original request doesn't really buy us anything, at least in

[virtio-dev] Re: [PATCH v4] virtio-snd: add virtio sound device specification

2020-01-08 Thread Anton Yakovlev
On 08.01.2020 11:34, Gerd Hoffmann wrote: On Tue, Jan 07, 2020 at 01:50:49PM +0100, Anton Yakovlev wrote: This patch proposes virtio specification for a new virtio sound device, that may be useful in case when having audio is required but a device passthrough or emulation is not an option.

Re: [virtio-dev][RFC PATCH v1 1/2] content: define what exporting a resource is

2020-01-08 Thread David Stevens
> > Hmm, I'd suggest to move the whole thing into the virtio-gpu section. > There is no such thing as a "resource" in general virtio context ... > If this is moved into the virtio-gpu section, then any device type that imports resources will have to refer to something defined by the GPU device

Re: [virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-08 Thread Gerd Hoffmann
> +\begin{lstlisting} > +struct virtio_gpu_export_resource { > +struct virtio_gpu_ctrl_hdr hdr; > +le32 resource_id; > +le32 padding; > +}; > + > +struct virtio_gpu_resp_export_resource { > +struct virtio_gpu_ctrl_hdr hdr; > +le64 uuid_low; > +le64

Re: [virtio-dev][RFC PATCH v1 1/2] content: define what exporting a resource is

2020-01-08 Thread Gerd Hoffmann
On Wed, Jan 08, 2020 at 06:01:58PM +0900, David Stevens wrote: > Define a mechanism for sharing resources between different virtio > devices. > > Signed-off-by: David Stevens > --- > content.tex | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/content.tex

[virtio-dev] Re: [PATCH v4] virtio-snd: add virtio sound device specification

2020-01-08 Thread Gerd Hoffmann
On Tue, Jan 07, 2020 at 01:50:49PM +0100, Anton Yakovlev wrote: > This patch proposes virtio specification for a new virtio sound device, > that may be useful in case when having audio is required but a device > passthrough or emulation is not an option. Looks pretty good overall. Some small

[virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

2020-01-08 Thread Dmitry Sepp
Hi Keiichi, On Mittwoch, 8. Januar 2020 07:59:22 CET Keiichi Watanabe wrote: > Hi Dmitry, > > On Wed, Jan 8, 2020 at 1:50 AM Dmitry Sepp wrote: > > Hi Keiichi, > > > > thanks for the updates, please see my comments below. > > > > On Dienstag, 7. Januar 2020 14:24:31 CET Keiichi Watanabe

[virtio-dev][RFC PATCH v1 1/2] content: define what exporting a resource is

2020-01-08 Thread David Stevens
Define a mechanism for sharing resources between different virtio devices. Signed-off-by: David Stevens --- content.tex | 18 ++ 1 file changed, 18 insertions(+) diff --git a/content.tex b/content.tex index b1ea9b9..73bd28e 100644 --- a/content.tex +++ b/content.tex @@ -373,6

[virtio-dev][RFC PATCH v1 2/2] virtio-gpu: add the ability to export resources

2020-01-08 Thread David Stevens
Signed-off-by: David Stevens --- virtio-gpu.tex | 29 + 1 file changed, 29 insertions(+) diff --git a/virtio-gpu.tex b/virtio-gpu.tex index af4ca61..522f478 100644 --- a/virtio-gpu.tex +++ b/virtio-gpu.tex @@ -186,12 +186,16 @@ \subsubsection{Device Operation:

[virtio-dev][RFC PATCH v1 0/2] Cross-device resource sharing

2020-01-08 Thread David Stevens
This RFC comes from the recent discussion on buffer sharing [1], specifically about the need to share resources between different virtio devices. For a concrete use case, this can be used to share virtio-gpu allocated buffers with the recently proposed virtio video device [2], without the need to