[virtio-dev] Re: [PATCH v2 1/1] video_video: Add the Virtio Video V4L2 driver

2020-03-12 Thread Dmitry Sepp
Hi Hans, One more thing: > GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that. GFP_DMA32 had no effect for me on arm64. Probably I need to recheck. Best regards, Dmitry. On Donnerstag, 12. März 2020 11:18:26 CET Hans Verkuil wrote: > On 3/12/20 11:15 AM, Dmitry Sepp wrot

[virtio-dev] Re: [PATCH v2 0/1] Virtio Video V4L2 driver

2020-03-12 Thread Dmitry Sepp
Hi Hans, I'm not sure about crosvm, for us it is probably still feasible to implement FWHT in the device (but it is unfortunately not supposed to be upstreamed yet). The main question is what would be the proper user-space tool to test that? Is v4l2-ctl OK for that? As for gstreamer, AFAIK it

[virtio-dev] Re: [PATCH v2 0/1] Virtio Video V4L2 driver

2020-03-12 Thread Keiichi Watanabe
On Thu, Mar 12, 2020 at 6:54 PM Hans Verkuil wrote: > > On 3/12/20 10:49 AM, Keiichi Watanabe wrote: > > Hi Hans, > > > > On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote: > >> > >> Hi Dmitry, > >> > >> On 2/18/20 9:27 PM, Dmitry Sepp wrote: > >>> Hi all, > >>> > >>> This is a v4l2 virtio vide

[virtio-dev] Re: [PATCH v2 0/1] Virtio Video V4L2 driver

2020-03-12 Thread Keiichi Watanabe
Hi Hans, On Wed, Mar 11, 2020 at 10:26 PM Hans Verkuil wrote: > > Hi Dmitry, > > On 2/18/20 9:27 PM, Dmitry Sepp wrote: > > Hi all, > > > > This is a v4l2 virtio video driver for the virtio-video device > > specification v3 [1]. > > > > The first version of the driver was introduced here [2]. > >

[virtio-dev] Re: [PATCH v2 0/1] Virtio Video V4L2 driver

2020-03-12 Thread Dmitry Sepp
Hi Hans, Thanks for reviewing. Sure, we understand the driver must pass v4l2-compliance. But the spec is not finalized yet, so it was a bit out of the scope. Best regards, Dmitry. On Mittwoch, 11. März 2020 14:26:46 CET Hans Verkuil wrote: > Hi Dmitry, > > On 2/18/20 9:27 PM, Dmitry Sepp wrot