Re: [virtio-dev] Re: [Virtio-networking] Doorbell mapping of vDPA

2020-04-16 Thread Jason Wang
On 2020/4/17 下午12:19, Jason Wang wrote: On 2020/4/15 上午12:20, Michael S. Tsirkin wrote: On Tue, Apr 14, 2020 at 01:12:51PM +, Vitaly Mireyno wrote: -Original Message- From: virtio-networking-boun...@redhat.com On Behalf Of Jason Wang Sent: Tuesday, 7 April, 2020 10:56 To:

[virtio-dev] Re: [Virtio-networking] Doorbell mapping of vDPA

2020-04-16 Thread Jason Wang
On 2020/4/15 上午12:20, Michael S. Tsirkin wrote: On Tue, Apr 14, 2020 at 01:12:51PM +, Vitaly Mireyno wrote: -Original Message- From: virtio-networking-boun...@redhat.com On Behalf Of Jason Wang Sent: Tuesday, 7 April, 2020 10:56 To: virtio-network...@redhat.com; Virtio-Dev Cc:

[virtio-dev] Re: [Virtio-networking] Doorbell mapping of vDPA

2020-04-16 Thread Jason Wang
On 2020/4/14 下午9:12, Vitaly Mireyno wrote: -Original Message- From: virtio-networking-boun...@redhat.com On Behalf Of Jason Wang Sent: Tuesday, 7 April, 2020 10:56 To: virtio-network...@redhat.com; Virtio-Dev Cc: Michael S. Tsirkin Subject: [Virtio-networking] Doorbell mapping of

Re: [virtio-dev] Re: [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled

2020-04-16 Thread Alexander Duyck
On Thu, Apr 16, 2020 at 3:13 PM Michael S. Tsirkin wrote: > > On Thu, Apr 16, 2020 at 12:30:38PM -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > > > If we have free page hinting or page reporting enabled we should disable it > > if the pages are poisoned or initialized on free and we

[virtio-dev] Re: [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled

2020-04-16 Thread Michael S. Tsirkin
On Thu, Apr 16, 2020 at 12:30:38PM -0700, Alexander Duyck wrote: > From: Alexander Duyck > > If we have free page hinting or page reporting enabled we should disable it > if the pages are poisoned or initialized on free and we cannot notify the > hypervisor. > > Fixes: 5d757c8d518d

[virtio-dev] [PATCH v20 QEMU 3/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. So if free page hinting is active we should add page poisoning support and let the guest disable it if it isn't using it. Page

[virtio-dev] [PATCH v20 QEMU 4/5] linux-headers: update to contain virito-balloon free page reporting

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck Sync the latest upstream changes for free page reporting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h |1 + 1 file changed, 1 insertion(+) diff --git

[virtio-dev] [PATCH v20 QEMU 5/5] virtio-balloon: Provide an interface for free page reporting

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into

[virtio-dev] [PATCH v20 QEMU 2/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report' with

[virtio-dev] [PATCH v20 QEMU 0/5] virtio-balloon: add support for free page reporting

2020-04-16 Thread Alexander Duyck
This series provides an asynchronous means of reporting free guest pages to QEMU through virtio-balloon so that the memory associated with those pages can be dropped and reused by other processes and/or guests on the host. Using this it is possible to avoid unnecessary I/O to disk and greatly

[virtio-dev] [PATCH v20 QEMU 1/5] linux-headers: Update to allow renaming of free_page_report_cmd_id

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck Sync to the latest upstream changes for free page hinting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[virtio-dev] [PATCH] virtio-balloon: Disable free page hinting/reporting if page poison is disabled

2020-04-16 Thread Alexander Duyck
From: Alexander Duyck If we have free page hinting or page reporting enabled we should disable it if the pages are poisoned or initialized on free and we cannot notify the hypervisor. Fixes: 5d757c8d518d ("virtio-balloon: add support for providing free page reports to host") Signed-off-by:

[virtio-dev] Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
> The other thing to keep in mind is that the poison value only really > comes into play with hinting/reporting. In the case of the standard > balloon the pages are considered allocated from the guest's Currently just as free page hinting IMHO. They are temporarily considered allocated. >

[virtio-dev] Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Alexander Duyck
On Thu, Apr 16, 2020 at 7:55 AM David Hildenbrand wrote: > > >> We should document our result of page poisoning, free page hinting, and > >> free page reporting there as well. I hope you'll have time for the latter. > >> > >>

[virtio-dev] Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
>> We should document our result of page poisoning, free page hinting, and >> free page reporting there as well. I hope you'll have time for the latter. >> >> - >> Semantics of VIRTIO_BALLOON_F_PAGE_POISON >>

[virtio-dev] Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread Michael S. Tsirkin
On Thu, Apr 16, 2020 at 10:18:49AM +0200, David Hildenbrand wrote: > >> > >> Postcopy is a very good point, bought! > >> > >> But (what you wrote above) it sounds like that this is really what we > >> *have to* do, not an optimization. I‘ll double check the spec tomorrow > >> (hopefully it was

[virtio-dev] Preferred layout for request/response structs

2020-04-16 Thread Keiichi Watanabe
Hi, I'm designing virtio-video protocol [1] and thinking about its structs' layouts. The virtio-video protocol adopts the request-response model like virtio-gpu and virtio-fs. While I looked at these two protocols, I found they used different designs of having request headers. So, I’m wondering

Re: [virtio-dev] Dirty Page Tracking (DPT)

2020-04-16 Thread Eugenio Perez Martin
Hi everyone. As proposed in the previous virtio-networking Meeting, I summarized in this document the different proposed requirements/architectures about vDPA live migration, and a starting draft about the proposed actions. Feedback is welcome. Thanks!

[virtio-dev] Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
On 16.04.20 10:18, David Hildenbrand wrote: >>> >>> Postcopy is a very good point, bought! >>> >>> But (what you wrote above) it sounds like that this is really what we *have >>> to* do, not an optimization. I‘ll double check the spec tomorrow (hopefully >>> it was documented). We should

[virtio-dev] Re: [PATCH v19 QEMU 1/4] virtio-balloon: Implement support for page poison tracking feature

2020-04-16 Thread David Hildenbrand
>> >> Postcopy is a very good point, bought! >> >> But (what you wrote above) it sounds like that this is really what we *have >> to* do, not an optimization. I‘ll double check the spec tomorrow (hopefully >> it was documented). We should rephrase the comment then. > > Do you have a link to the