Re: [virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Michael S. Tsirkin
On Mon, Feb 28, 2022 at 08:17:49PM +0800, Xuan Zhuo wrote: > On Mon, 28 Feb 2022 06:40:33 -0500, "Michael S. Tsirkin" > wrote: > > On Tue, Feb 15, 2022 at 03:47:43PM +0800, Xuan Zhuo wrote: > > > This patch allows the driver to obtain some statistics from the device. > > > > > > In the back-end

Re: [virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 06:40:33 -0500, "Michael S. Tsirkin" wrote: > On Tue, Feb 15, 2022 at 03:47:43PM +0800, Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 06:55:27 -0500, "Michael S. Tsirkin" wrote: > On Mon, Feb 28, 2022 at 07:21:39PM +0800, Xuan Zhuo wrote: > > > struct stats{ > > > /* the counters that doesn't need any features */ > > > /* the counters that needs CSUM */ > > > /* the counters that needs GSO */ > > > /* the

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Michael S. Tsirkin
On Mon, Feb 28, 2022 at 07:21:39PM +0800, Xuan Zhuo wrote: > > struct stats{ > > /* the counters that doesn't need any features */ > > /* the counters that needs CSUM */ > > /* the counters that needs GSO */ > > /* the counters that needs reset */ > > } > > > > Or even split them into different

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Michael S. Tsirkin
On Tue, Feb 15, 2022 at 03:47:43PM +0800, Xuan Zhuo wrote: > This patch allows the driver to obtain some statistics from the device. > > In the back-end implementation, we can count a lot of such information, > which can be used for debugging and judging the running status of the > back-end. We

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Xuan Zhuo
On Mon, 28 Feb 2022 17:07:54 +0800, Jason Wang wrote: > On Tue, Feb 15, 2022 at 3:47 PM Xuan Zhuo wrote: > > > > This patch allows the driver to obtain some statistics from the device. > > > > In the back-end implementation, we can count a lot of such information, > > which can be used for

[virtio-dev] Re: [PATCH v9] virtio-net: support device stats

2022-02-28 Thread Jason Wang
On Tue, Feb 15, 2022 at 3:47 PM Xuan Zhuo wrote: > > This patch allows the driver to obtain some statistics from the device. > > In the back-end implementation, we can count a lot of such information, > which can be used for debugging and judging the running status of the > back-end. We hope to