Re: [virtio-dev] Re: [PATCH 5/6] virtio/vsock: add support for dgram

2022-08-16 Thread Arseniy Krasnov
On 17.08.2022 08:01, Arseniy Krasnov wrote: > On 16.08.2022 05:32, Bobby Eshleman wrote: >> CC'ing virtio-dev@lists.oasis-open.org >> >> On Mon, Aug 15, 2022 at 10:56:08AM -0700, Bobby Eshleman wrote: >>> This patch supports dgram in virtio and on the vhost side. > Hello, > > sorry, i don't unders

Re: [virtio-dev] Re: [PATCH 2/6] vsock: return errors other than -ENOMEM to socket

2022-08-16 Thread Arseniy Krasnov
On 16.08.2022 05:30, Bobby Eshleman wrote: > CC'ing virtio-dev@lists.oasis-open.org > > On Mon, Aug 15, 2022 at 10:56:05AM -0700, Bobby Eshleman wrote: >> This commit allows vsock implementations to return errors >> to the socket layer other than -ENOMEM. One immediate effect >> of this is that up

Re: [virtio-dev] Re: [PATCH 5/6] virtio/vsock: add support for dgram

2022-08-16 Thread Arseniy Krasnov
On 16.08.2022 05:32, Bobby Eshleman wrote: > CC'ing virtio-dev@lists.oasis-open.org > > On Mon, Aug 15, 2022 at 10:56:08AM -0700, Bobby Eshleman wrote: >> This patch supports dgram in virtio and on the vhost side. Hello, sorry, i don't understand, how this maintains message boundaries? Or it is u

Re: [virtio-dev] [RFC PATCH v3] virtio-blk: add zoned block device specification

2022-08-16 Thread Dmitry Fomichev
On Sat, 2022-08-06 at 17:20 -0400, Stefan Hajnoczi wrote: > On Thu, 4 Aug 2022 at 18:41, Dmitry Fomichev wrote: > > Hi Dmitry, > I think RFC can be removed from the Subject line for the next revision > of this patch. > > For instructions on how to bring this to a Technical Committee vote, see: >

[virtio-dev] Re: [PATCH 6/6] vsock_test: add tests for vsock dgram

2022-08-16 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org On Mon, Aug 15, 2022 at 10:56:09AM -0700, Bobby Eshleman wrote: > From: Jiang Wang > > Added test cases for vsock dgram types. > > Signed-off-by: Jiang Wang > --- > tools/testing/vsock/util.c | 105 + > tools/testing/vsock/util.h

[virtio-dev] Re: [PATCH 5/6] virtio/vsock: add support for dgram

2022-08-16 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org On Mon, Aug 15, 2022 at 10:56:08AM -0700, Bobby Eshleman wrote: > This patch supports dgram in virtio and on the vhost side. > > Signed-off-by: Jiang Wang > Signed-off-by: Bobby Eshleman > --- > drivers/vhost/vsock.c | 2 +- > include/

[virtio-dev] Re: [PATCH 4/6] virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit

2022-08-16 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org On Mon, Aug 15, 2022 at 10:56:07AM -0700, Bobby Eshleman wrote: > This commit adds a feature bit for virtio vsock to support datagrams. > > Signed-off-by: Jiang Wang > Signed-off-by: Bobby Eshleman > --- > drivers/vhost/vsock.c | 3 ++- > incl

[virtio-dev] Re: [PATCH 3/6] vsock: add netdev to vhost/virtio vsock

2022-08-16 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org On Mon, Aug 15, 2022 at 10:56:06AM -0700, Bobby Eshleman wrote: > In order to support usage of qdisc on vsock traffic, this commit > introduces a struct net_device to vhost and virtio vsock. > > Two new devices are created, vhost-vsock for vhost and virtio-v

[virtio-dev] Re: [PATCH 2/6] vsock: return errors other than -ENOMEM to socket

2022-08-16 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org On Mon, Aug 15, 2022 at 10:56:05AM -0700, Bobby Eshleman wrote: > This commit allows vsock implementations to return errors > to the socket layer other than -ENOMEM. One immediate effect > of this is that upon the sk_sndbuf threshold being reached -EAGAIN > w

[virtio-dev] Re: [PATCH 1/6] vsock: replace virtio_vsock_pkt with sk_buff

2022-08-16 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org On Mon, Aug 15, 2022 at 10:56:04AM -0700, Bobby Eshleman wrote: > This patch replaces virtio_vsock_pkt with sk_buff. > > The benefit of this series includes: > > * The bug reported @ https://bugzilla.redhat.com/show_bug.cgi?id=2009935 > does not present i

[virtio-dev] Re: [PATCH 0/6] virtio/vsock: introduce dgrams, sk_buff, and qdisc

2022-08-16 Thread Bobby Eshleman
CC'ing virtio-dev@lists.oasis-open.org On Mon, Aug 15, 2022 at 10:56:03AM -0700, Bobby Eshleman wrote: > Hey everybody, > > This series introduces datagrams, packet scheduling, and sk_buff usage > to virtio vsock. > > The usage of struct sk_buff benefits users by a) preparing vsock to use > othe

[virtio-dev] Re: [virtio] [PATCH RFC v7 6/8] ccw: disallow ADMIN_VQ

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 11:48:51AM -0400, Michael S. Tsirkin wrote: > On Tue, Aug 16, 2022 at 04:48:11PM +0200, Halil Pasic wrote: > > On Fri, 12 Aug 2022 13:19:20 -0400 > > "Michael S. Tsirkin" wrote: > > > > > Signed-off-by: Michael S. Tsirkin > > > --- > > > content.tex | 10 ++ > > >

[virtio-dev] Re: [virtio] [PATCH RFC v7 6/8] ccw: disallow ADMIN_VQ

2022-08-16 Thread Michael S. Tsirkin
On Tue, Aug 16, 2022 at 04:48:11PM +0200, Halil Pasic wrote: > On Fri, 12 Aug 2022 13:19:20 -0400 > "Michael S. Tsirkin" wrote: > > > Signed-off-by: Michael S. Tsirkin > > --- > > content.tex | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/content.tex b/content.tex >

[virtio-dev] Re: [virtio] [PATCH RFC v7 6/8] ccw: disallow ADMIN_VQ

2022-08-16 Thread Halil Pasic
On Fri, 12 Aug 2022 13:19:20 -0400 "Michael S. Tsirkin" wrote: > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/content.tex b/content.tex > index 76b5a28..53be680 100644 > --- a/content.tex > +++ b/content.tex > @@ -26

[virtio-dev] [PATCH v7] virtio_net: support split header

2022-08-16 Thread Heng Qi
From: Xuan Zhuo The purpose of this feature is to split the header and the payload of the packet. |receive buffer| | 0th descriptor | 1th descriptor| | virtnet hdr | mac | ip hdr | tcp hdr|<-- hold -->|