[virtio-dev] Re: [PATCH v9 05/10] pci: add admin vq registers to virtio over pci

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 3:14 PM Michael S. Tsirkin wrote: > > On Thu, Nov 24, 2022 at 02:00:54PM +0800, Jason Wang wrote: > > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > > > Add new registers to the PCI common configuration structure. > > > > > > These registers will be

[virtio-dev] Re: [PATCH v9 06/10] mmio: document ADMIN_VQ as reserved

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 02:03:30PM +0800, Jason Wang wrote: > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > Adding relevant registers needs more work and it's not > > clear what the use-case will be as currently only > > the PCI transport is supported. But let's keep the > >

[virtio-dev] Re: [PATCH v9 03/10] admin: introduce group administration commands

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 3:12 PM Michael S. Tsirkin wrote: > > On Thu, Nov 24, 2022 at 01:52:41PM +0800, Jason Wang wrote: > > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > > > This introduces a general structure for group administration commands, > > > used to control device

Re: [virtio-dev] Re: [PATCH v9 02/10] admin: introduce device group and related concepts

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 3:08 PM Michael S. Tsirkin wrote: > > On Thu, Nov 24, 2022 at 01:41:41PM +0800, Jason Wang wrote: > > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > > > Each device group has a type. For now, define one initial group: > > > > > > SR-IOV type - PCI

[virtio-dev] Re: [PATCH v9 01/10] virtio: document forward compatibility guarantees

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 2:59 PM Michael S. Tsirkin wrote: > > On Thu, Nov 24, 2022 at 12:33:52PM +0800, Jason Wang wrote: > > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > > > Feature negotiation forms the basis of forward compatibility > > > guarantees of virtio but has

[virtio-dev] Re: [PATCH v9 05/10] pci: add admin vq registers to virtio over pci

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 02:00:54PM +0800, Jason Wang wrote: > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > Add new registers to the PCI common configuration structure. > > > > These registers will be used for querying the indices of the admin > > virtqueues of the owner

[virtio-dev] Re: [PATCH v9 03/10] admin: introduce group administration commands

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 01:52:41PM +0800, Jason Wang wrote: > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > This introduces a general structure for group administration commands, > > used to control device groups through their owner. > > > > Following patches will introduce

[virtio-dev] Re: [PATCH v9 02/10] admin: introduce device group and related concepts

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 01:41:41PM +0800, Jason Wang wrote: > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > Each device group has a type. For now, define one initial group: > > > > SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given > > PCI SR-IOV physical function

[virtio-dev] Re: [PATCH v9 01/10] virtio: document forward compatibility guarantees

2022-11-23 Thread Michael S. Tsirkin
On Thu, Nov 24, 2022 at 12:33:52PM +0800, Jason Wang wrote: > On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > > > Feature negotiation forms the basis of forward compatibility > > guarantees of virtio but has never been properly documented. > > Do it now. > > > > Suggested-by: Halil

[virtio-dev] Re: [PATCH RFC v9 10/10] ccw: document more reserved features

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > vq reset and shared memory are unsupported, too. > > Signed-off-by: Michael S. Tsirkin I wonder if it's better to split this series into two since it doesn't have direct connection with the admin stuffs then the compatibility part

[virtio-dev] Re: [PATCH v9 09/10] admin: conformance clauses

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > Add conformance clauses for admin commands and admin virtqueues. > > Signed-off-by: Michael S. Tsirkin > --- > admin.tex | 158 ++ > 1 file changed, 158 insertions(+) > > diff --git

[virtio-dev] Re: [PATCH v9 08/10] admin: command list discovery

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > Add commands to find out which commands does each group support, > as well as enable their use by driver. > This will be especially useful once we have multiple group types. > > An alternative is per-type VQs. This is possible but will

[virtio-dev] Re: [PATCH v9 06/10] mmio: document ADMIN_VQ as reserved

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > Adding relevant registers needs more work and it's not > clear what the use-case will be as currently only > the PCI transport is supported. But let's keep the > door open on this. > We already say it's reserved in a central place, but

[virtio-dev] Re: [PATCH v9 05/10] pci: add admin vq registers to virtio over pci

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > Add new registers to the PCI common configuration structure. > > These registers will be used for querying the indices of the admin > virtqueues of the owner device. To configure, reset or enable the admin > virtqueues, the driver

[virtio-dev] Re: [PATCH v9 03/10] admin: introduce group administration commands

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > This introduces a general structure for group administration commands, > used to control device groups through their owner. > > Following patches will introduce specific commands and an interface for > submitting these commands to the

[virtio-dev] Re: [PATCH v9 02/10] admin: introduce device group and related concepts

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > Each device group has a type. For now, define one initial group: > > SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given > PCI SR-IOV physical function (PF). This group may contain one or more > virtio devices. > > Each device

[virtio-dev] Re: [PATCH v9 01/10] virtio: document forward compatibility guarantees

2022-11-23 Thread Jason Wang
On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: > > Feature negotiation forms the basis of forward compatibility > guarantees of virtio but has never been properly documented. > Do it now. > > Suggested-by: Halil Pasic > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 42

Re: [virtio-dev] [PATCH 0/2] introduce virtio-ism: internal shared memory device

2022-11-23 Thread Xuan Zhuo
On Wed, 23 Nov 2022 16:27:00 +0100, Jan Kiszka wrote: > On 16.11.22 03:13, Xuan Zhuo wrote: > > On Mon, 14 Nov 2022 22:30:53 +0100, Jan Kiszka > > wrote: > >> On 18.10.22 09:32, Jan Kiszka wrote: > >>> On 17.10.22 09:47, Xuan Zhuo wrote: > Hello everyone, > > # Background >

[virtio-dev] [PATCH RFC v9 10/10] ccw: document more reserved features

2022-11-23 Thread Michael S. Tsirkin
vq reset and shared memory are unsupported, too. Signed-off-by: Michael S. Tsirkin --- This is not strictly part of this patchset, but just to give you the idea of how we can expand this down the road. content.tex | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content.tex

[virtio-dev] [PATCH v9 09/10] admin: conformance clauses

2022-11-23 Thread Michael S. Tsirkin
Add conformance clauses for admin commands and admin virtqueues. Signed-off-by: Michael S. Tsirkin --- admin.tex | 158 ++ 1 file changed, 158 insertions(+) diff --git a/admin.tex b/admin.tex index eec12a9..e83a9f5 100644 --- a/admin.tex +++

[virtio-dev] [PATCH v9 08/10] admin: command list discovery

2022-11-23 Thread Michael S. Tsirkin
Add commands to find out which commands does each group support, as well as enable their use by driver. This will be especially useful once we have multiple group types. An alternative is per-type VQs. This is possible but will require more per-transport work. Discovery through the vq helps keep

[virtio-dev] [PATCH v9 07/10] ccw: document ADMIN_VQ as reserved

2022-11-23 Thread Michael S. Tsirkin
Adding relevant registers needs more work and it's not clear what the use-case will be as currently only the PCI transport is supported. But let's keep the door open on this. We already say it's reserved in a central place, but it does not hurt to remind implementers to mask it. Note: there are

[virtio-dev] [PATCH v9 04/10] admin: introduce virtio admin virtqueues

2022-11-23 Thread Michael S. Tsirkin
The admin virtqueues will be the first interface to issue admin commands. Currently virtio specification defines control virtqueue to manipulate features and configuration of the device it operates on. However, control virtqueue commands are device type specific, which makes it very difficult to

[virtio-dev] [PATCH v9 05/10] pci: add admin vq registers to virtio over pci

2022-11-23 Thread Michael S. Tsirkin
Add new registers to the PCI common configuration structure. These registers will be used for querying the indices of the admin virtqueues of the owner device. To configure, reset or enable the admin virtqueues, the driver should follow existing queue configuration/setup sequence. Signed-off-by:

[virtio-dev] [PATCH v9 06/10] mmio: document ADMIN_VQ as reserved

2022-11-23 Thread Michael S. Tsirkin
Adding relevant registers needs more work and it's not clear what the use-case will be as currently only the PCI transport is supported. But let's keep the door open on this. We already say it's reserved in a central place, but it does not hurt to remind implementers to mask it. Signed-off-by:

[virtio-dev] [PATCH v9 02/10] admin: introduce device group and related concepts

2022-11-23 Thread Michael S. Tsirkin
Each device group has a type. For now, define one initial group: SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given PCI SR-IOV physical function (PF). This group may contain one or more virtio devices. Each device within a group has a unique identifier. This identifier is the group

[virtio-dev] [PATCH v9 03/10] admin: introduce group administration commands

2022-11-23 Thread Michael S. Tsirkin
This introduces a general structure for group administration commands, used to control device groups through their owner. Following patches will introduce specific commands and an interface for submitting these commands to the owner. Signed-off-by: Max Gurtovoy Signed-off-by: Michael S. Tsirkin

[virtio-dev] [PATCH v9 01/10] virtio: document forward compatibility guarantees

2022-11-23 Thread Michael S. Tsirkin
Feature negotiation forms the basis of forward compatibility guarantees of virtio but has never been properly documented. Do it now. Suggested-by: Halil Pasic Signed-off-by: Michael S. Tsirkin --- content.tex | 42 ++ 1 file changed, 42 insertions(+)

[virtio-dev] [PATCH v9 00/10] Introduce device group and device management

2022-11-23 Thread Michael S. Tsirkin
Change log: since v8: addressed comments by Cornelia - as we agreed on list since v7: make high level error codes match linux, with virtio specific codes in a separate field renamed _ACCEPT to _USE since that's what it does clarified

Re: [virtio-dev] [PATCH 0/2] introduce virtio-ism: internal shared memory device

2022-11-23 Thread Jan Kiszka
On 16.11.22 03:13, Xuan Zhuo wrote: > On Mon, 14 Nov 2022 22:30:53 +0100, Jan Kiszka wrote: >> On 18.10.22 09:32, Jan Kiszka wrote: >>> On 17.10.22 09:47, Xuan Zhuo wrote: Hello everyone, # Background Nowadays, there is a common scenario to accelerate communication

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 11:33:40AM +0100, Cornelia Huck wrote: > On Wed, Nov 23 2022, "Michael S. Tsirkin" wrote: > > > On Wed, Nov 23, 2022 at 11:09:26AM +0100, Cornelia Huck wrote: > >> On Wed, Nov 23 2022, "Michael S. Tsirkin" wrote: > >> > >> > On Wed, Nov 23, 2022 at 10:51:31AM +0100,

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-23 Thread Cornelia Huck
On Wed, Nov 23 2022, "Michael S. Tsirkin" wrote: > On Wed, Nov 23, 2022 at 11:09:26AM +0100, Cornelia Huck wrote: >> On Wed, Nov 23 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Nov 23, 2022 at 10:51:31AM +0100, Cornelia Huck wrote: >> >> On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote:

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 11:09:26AM +0100, Cornelia Huck wrote: > On Wed, Nov 23 2022, "Michael S. Tsirkin" wrote: > > > On Wed, Nov 23, 2022 at 10:51:31AM +0100, Cornelia Huck wrote: > >> On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > >> > >> > On Tue, Nov 22, 2022 at 04:25:23PM +0100,

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-23 Thread Cornelia Huck
On Wed, Nov 23 2022, "Michael S. Tsirkin" wrote: > On Wed, Nov 23, 2022 at 10:51:31AM +0100, Cornelia Huck wrote: >> On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: >> >> > On Tue, Nov 22, 2022 at 04:25:23PM +0100, Cornelia Huck wrote: >> >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote:

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 10:51:31AM +0100, Cornelia Huck wrote: > On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > > > On Tue, Nov 22, 2022 at 04:25:23PM +0100, Cornelia Huck wrote: > >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > > Using 0x instead of h suffix? Sure. > > > > We should

[virtio-dev] Re: [PATCH v8 4/9] admin: introduce virtio admin virtqueues

2022-11-23 Thread Cornelia Huck
On Wed, Nov 23 2022, "Michael S. Tsirkin" wrote: > On Wed, Nov 23, 2022 at 10:30:25AM +0100, Cornelia Huck wrote: >> On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: >> >> > On Tue, Nov 22, 2022 at 02:14:23PM +0100, Cornelia Huck wrote: >> >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote:

[virtio-dev] Re: [PATCH v8 9/9] admin: conformance clauses

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Tue, Nov 22, 2022 at 05:06:04PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: >> > +List of supported commands MUST NOT change: after reporting a >> >> s/List/The list/ >> >> > +given command as supported

[virtio-dev] Re: [PATCH v8 8/9] admin: command list discovery

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Tue, Nov 22, 2022 at 04:25:23PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > Using 0x instead of h suffix? Sure. > > We should probably document the syntax in introduction.tex > though this seems low

[virtio-dev] Re: [PATCH v8 5/9] pci: add admin vq registers to virtio over pci

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 10:36:25AM +0100, Cornelia Huck wrote: > On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > > > On Tue, Nov 22, 2022 at 03:46:38PM +0100, Cornelia Huck wrote: > >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > >> > >> > Add new registers to the PCI common

[virtio-dev] Re: [PATCH v8 5/9] pci: add admin vq registers to virtio over pci

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Tue, Nov 22, 2022 at 03:46:38PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: >> >> > Add new registers to the PCI common configuration structure. >> > >> > These registers will be used for querying the

[virtio-dev] Re: [PATCH v8 4/9] admin: introduce virtio admin virtqueues

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 10:30:25AM +0100, Cornelia Huck wrote: > On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > > > On Tue, Nov 22, 2022 at 02:14:23PM +0100, Cornelia Huck wrote: > >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > >> > +Administration virtqueues exists for a certain

[virtio-dev] Re: [PATCH v8 4/9] admin: introduce virtio admin virtqueues

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Tue, Nov 22, 2022 at 02:14:23PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: >> > +Administration virtqueues exists for a certain owner device if >> > +VIRTIO_F_ADMIN_VQ feature has been negotiated. The

[virtio-dev] Re: [PATCH v8 1/9] virtio: document forward compatibility guarantees

2022-11-23 Thread Michael S. Tsirkin
On Wed, Nov 23, 2022 at 10:21:52AM +0100, Cornelia Huck wrote: > On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > > > On Mon, Nov 21, 2022 at 04:24:26PM +0100, Cornelia Huck wrote: > >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: > >> > \drivernormative{\subsection}{Feature Bits}{Basic

[virtio-dev] Re: [PATCH v8 2/9] admin: introduce device group and related concepts

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Tue, Nov 22, 2022 at 01:11:19PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: >> > +\item[Member device] >> > +a device within a group. Owner device itself is not >> >> s/Owner/The owner/ >> >> > +

[virtio-dev] Re: [PATCH v8 1/9] virtio: document forward compatibility guarantees

2022-11-23 Thread Cornelia Huck
On Tue, Nov 22 2022, "Michael S. Tsirkin" wrote: > On Mon, Nov 21, 2022 at 04:24:26PM +0100, Cornelia Huck wrote: >> On Sun, Nov 20 2022, "Michael S. Tsirkin" wrote: >> > \drivernormative{\subsection}{Feature Bits}{Basic Facilities of a Virtio >> > Device / Feature Bits} >> > The driver MUST