[virtio-dev] Re: [PATCH v2] virtio-blk: avoid kernel panic on VIRTIO_BLK_F_ZONED check

2022-12-21 Thread Michael S. Tsirkin
On Wed, Dec 21, 2022 at 02:54:33PM +, Lorenzo Stoakes wrote: > virtio zoned block device support is added by commit 0562d7bf1604 > ("virtio-blk: add support for zoned block devices") which adds > VIRTIO_BLK_F_ZONED to the features array in virtio_blk.c but makes it > conditional on

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2022-12-21 Thread Alexander Gordeev
On 20.12.22 18:39, Cornelia Huck wrote: +\subsubsection{Image formats}\label{sec:Device Types / Video Device / Supported formats / Image formats} + +The fourcc code of each supported image format is given, as well as its +number of planes, physical buffers, and eventual subsampling. +

Re: [virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

2022-12-21 Thread Xuan Zhuo
On Wed, 21 Dec 2022 13:48:59 +0200, Alvaro Karsz wrote: > Hi, > > > I want to know which one is better than NetDim(Coalesce Adaptive) in driver. > > > > I know Heng Qi's work in this. > > > > Thanks > > > Why choose? we can have both. > ethtool can handle both pkt_rate_low/pkt_rate_high and >

Re: [virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

2022-12-21 Thread Heng Qi
在 2022/12/21 下午7:48, Alvaro Karsz 写道: Hi, I want to know which one is better than NetDim(Coalesce Adaptive) in driver. I know Heng Qi's work in this. Thanks Why choose? we can have both. ethtool can handle both pkt_rate_low/pkt_rate_high and

Re: [virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

2022-12-21 Thread Alvaro Karsz
Hi, > I want to know which one is better than NetDim(Coalesce Adaptive) in driver. > > I know Heng Qi's work in this. > > Thanks Why choose? we can have both. ethtool can handle both pkt_rate_low/pkt_rate_high and use_adaptive_rx_coalesce/use_adaptive_tx_coalesce. The adaptive algorithm can

Re: [virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

2022-12-21 Thread Xuan Zhuo
On Wed, 21 Dec 2022 12:17:29 +0200, Alvaro Karsz wrote: > This patch adds a new feature VIRTIO_NET_F_NOTF_COAL_LOW_HIGH, > and adds 2 new commands to VIRTIO_NET_CTRL_NOTF_COAL class: > * VIRTIO_NET_CTRL_NOTF_COAL_LOW_SET - create a low-rate set of > coalescing parameters. the

[virtio-dev] [PATCH] virtio_net: support low and high rate of notification coalescing sets

2022-12-21 Thread Alvaro Karsz
This patch adds a new feature VIRTIO_NET_F_NOTF_COAL_LOW_HIGH, and adds 2 new commands to VIRTIO_NET_CTRL_NOTF_COAL class: * VIRTIO_NET_CTRL_NOTF_COAL_LOW_SET - create a low-rate set of coalescing parameters. the device should switch to this set when the packet rate